From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Paul Subject: Re: [PATCH] drm/i915: Only enable hotplug interrupts if the display interrupts are enabled Date: Wed, 15 Mar 2017 16:39:53 -0400 Message-ID: <1489610393.2837.4.camel@redhat.com> References: <87lgs9dugv.fsf@intel.com> <20170313170231.18633-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8FB4B6E2E9 for ; Wed, 15 Mar 2017 20:39:55 +0000 (UTC) In-Reply-To: <20170313170231.18633-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: jani.nikula@intel.com, Daniel Vetter , stable@vger.kernel.org, Hans de Goede List-Id: intel-gfx@lists.freedesktop.org QWNrZWQtYnk6IEx5dWRlIDxseXVkZUByZWRoYXQuY29tPgoKT24gTW9uLCAyMDE3LTAzLTEzIGF0 IDE3OjAyICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gSW4gb3JkZXIgdG8gcHJldmVudCBh Y2Nlc3NpbmcgdGhlIGhwZCByZWdpc3RlcnMgb3V0c2lkZSBvZiB0aGUKPiBkaXNwbGF5Cj4gcG93 ZXIgd2VsbHMsIHdlIHNob3VsZCByZWZyYWluIGZyb20gd3JpdGluZyB0byB0aGUgcmVnaXN0ZXJz IGJlZm9yZQo+IHRoZQo+IGRpc3BsYXkgaW50ZXJydXB0cyBhcmUgZW5hYmxlZC4KPiAKPiBbwqDC oMKgwqA0Ljc0MDEzNl0gV0FSTklORzogQ1BVOiAxIFBJRDogMjIxIGF0Cj4gZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmM6Nzk1Cj4gX191bmNsYWltZWRfcmVnX2RlYnVnKzB4NDQv MHg1MCBbaTkxNV0KPiBbwqDCoMKgwqA0Ljc0MDE1NV0gVW5jbGFpbWVkIHJlYWQgZnJvbSByZWdp c3RlciAweDFlMTExMAo+IFvCoMKgwqDCoDQuNzQwMTY4XSBNb2R1bGVzIGxpbmtlZCBpbjogaTkx NSgrKSBpbnRlbF9ndHQgZHJtX2ttc19oZWxwZXIKPiBwcmltZV9udW1iZXJzCj4gW8KgwqDCoMKg NC43NDAxOTBdIENQVTogMSBQSUQ6IDIyMSBDb21tOiBzeXN0ZW1kLXVkZXZkIE5vdCB0YWludGVk Cj4gNC4xMC4wLXJjNisgIzM4NAo+IFvCoMKgwqDCoDQuNzQwMjAzXSBIYXJkd2FyZSBuYW1lOsKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoC/CoMKgwqDCoMKgwqDCoMKgLCBCSU9T Cj4gUFlCU1dDRUwuODZBLjAwMjcuMjAxNS4wNTA3LjE3NTggMDUvMDcvMjAxNQo+IFvCoMKgwqDC oDQuNzQwMjIwXSBDYWxsIFRyYWNlOgo+IFvCoMKgwqDCoDQuNzQwMjM2XcKgwqBkdW1wX3N0YWNr KzB4NGQvMHg2Zgo+IFvCoMKgwqDCoDQuNzQwMjUxXcKgwqBfX3dhcm4rMHhjMS8weGUwCj4gW8Kg wqDCoMKgNC43NDAyNjVdwqDCoHdhcm5fc2xvd3BhdGhfZm10KzB4NGEvMHg1MAo+IFvCoMKgwqDC oDQuNzQwMjgxXcKgwqA/IGluc2VydF93b3JrKzB4NzcvMHhjMAo+IFvCoMKgwqDCoDQuNzQwMzU1 XcKgwqA/IGZ3dGFibGVfd3JpdGUzMisweDkwLzB4MTMwIFtpOTE1XQo+IFvCoMKgwqDCoDQuNzQw NDMxXcKgwqBfX3VuY2xhaW1lZF9yZWdfZGVidWcrMHg0NC8weDUwIFtpOTE1XQo+IFvCoMKgwqDC oDQuNzQwNTA3XcKgwqBmd3RhYmxlX3JlYWQzMisweGQ4LzB4MTMwIFtpOTE1XQo+IFvCoMKgwqDC oDQuNzQwNTc1XcKgwqBpOTE1X2hwZF9pcnFfc2V0dXArMHhhNS8weDEwMCBbaTkxNV0KPiBbwqDC oMKgwqA0Ljc0MDY0OV3CoMKgaW50ZWxfaHBkX2luaXQrMHg2OC8weDgwIFtpOTE1XQo+IFvCoMKg wqDCoDQuNzQwNzE2XcKgwqBpOTE1X2RyaXZlcl9sb2FkKzB4ZTE5LzB4MTM4MCBbaTkxNV0KPiBb wqDCoMKgwqA0Ljc0MDc4NF3CoMKgaTkxNV9wY2lfcHJvYmUrMHgzMi8weDkwIFtpOTE1XQo+IFvC oMKgwqDCoDQuNzQwNzk5XcKgwqBwY2lfZGV2aWNlX3Byb2JlKzB4OGIvMHhmMAo+IFvCoMKgwqDC oDQuNzQwODE1XcKgwqBkcml2ZXJfcHJvYmVfZGV2aWNlKzB4MmI2LzB4NDUwCj4gW8KgwqDCoMKg NC43NDA4MjhdwqDCoF9fZHJpdmVyX2F0dGFjaCsweGRhLzB4ZTAKPiBbwqDCoMKgwqA0Ljc0MDg0 MV3CoMKgPyBkcml2ZXJfcHJvYmVfZGV2aWNlKzB4NDUwLzB4NDUwCj4gW8KgwqDCoMKgNC43NDA4 NTNdwqDCoGJ1c19mb3JfZWFjaF9kZXYrMHg1Yi8weDkwCj4gW8KgwqDCoMKgNC43NDA4NjVdwqDC oGRyaXZlcl9hdHRhY2grMHgxOS8weDIwCj4gW8KgwqDCoMKgNC43NDA4NzhdwqDCoGJ1c19hZGRf ZHJpdmVyKzB4MTY2LzB4MjYwCj4gW8KgwqDCoMKgNC43NDA4OTJdwqDCoGRyaXZlcl9yZWdpc3Rl cisweDViLzB4ZDAKPiBbwqDCoMKgwqA0Ljc0MDkwNl3CoMKgPyAweGZmZmZmZmZmYTAxNjYwMDAK PiBbwqDCoMKgwqA0Ljc0MDkyMF3CoMKgX19wY2lfcmVnaXN0ZXJfZHJpdmVyKzB4NDcvMHg1MAo+ IFvCoMKgwqDCoDQuNzQwOTg1XcKgwqBpOTE1X2luaXQrMHg1Yy8weDVlIFtpOTE1XQo+IFvCoMKg wqDCoDQuNzQwOTk5XcKgwqBkb19vbmVfaW5pdGNhbGwrMHgzZS8weDE2MAo+IFvCoMKgwqDCoDQu NzQxMDE1XcKgwqA/IF9fdnVubWFwKzB4N2MvMHhjMAo+IFvCoMKgwqDCoDQuNzQxMDI5XcKgwqA/ IGttZW1fY2FjaGVfYWxsb2MrMHhjZi8weDEyMAo+IFvCoMKgwqDCoDQuNzQxMDQ1XcKgwqBkb19p bml0X21vZHVsZSsweDU1LzB4MWM0Cj4gW8KgwqDCoMKgNC43NDEwNjBdwqDCoGxvYWRfbW9kdWxl KzB4MWYzZi8weDI1YjAKPiBbwqDCoMKgwqA0Ljc0MTA3M13CoMKgPyBfX3N5bWJvbF9wdXQrMHg0 MC8weDQwCj4gW8KgwqDCoMKgNC43NDEwODZdwqDCoD8ga2VybmVsX3JlYWRfZmlsZSsweDEwMC8w eDE5MAo+IFvCoMKgwqDCoDQuNzQxMTAwXcKgwqBTWVNDX2Zpbml0X21vZHVsZSsweGJjLzB4ZjAK PiBbwqDCoMKgwqA0Ljc0MTExMl3CoMKgU3lTX2Zpbml0X21vZHVsZSsweDkvMHgxMAo+IFvCoMKg wqDCoDQuNzQxMTI1XcKgwqBlbnRyeV9TWVNDQUxMXzY0X2Zhc3RwYXRoKzB4MTcvMHg5OAo+IFvC oMKgwqDCoDQuNzQxMTM1XSBSSVA6IDAwMzM6MHg3Zjg1NTlhMTQwZjkKPiBbwqDCoMKgwqA0Ljc0 MTE0NV0gUlNQOiAwMDJiOjAwMDA3ZmZmNzUwOWEzZTggRUZMQUdTOiAwMDAwMDI0NiBPUklHX1JB WDoKPiAwMDAwMDAwMDAwMDAwMTM5Cj4gW8KgwqDCoMKgNC43NDExNjFdIFJBWDogZmZmZmZmZmZm ZmZmZmZkYSBSQlg6IDAwMDA3Zjg1NWFiYTAyZDEgUkNYOgo+IDAwMDA3Zjg1NTlhMTQwZjkKPiBb wqDCoMKgwqA0Ljc0MTE3Ml0gUkRYOiAwMDAwMDAwMDAwMDAwMDAwIFJTSTogMDAwMDU1YjZkYjA5 MTRmMCBSREk6Cj4gMDAwMDAwMDAwMDAwMDAxMQo+IFvCoMKgwqDCoDQuNzQxMTgzXSBSQlA6IDAw MDAwMDAwMDAwMjAwMDAgUjA4OiAwMDAwMDAwMDAwMDAwMDAwIFIwOToKPiAwMDAwMDAwMDAwMDAw MDBlCj4gW8KgwqDCoMKgNC43NDExOTNdIFIxMDogMDAwMDAwMDAwMDAwMDAxMSBSMTE6IDAwMDAw MDAwMDAwMDAyNDYgUjEyOgo+IDAwMDA1NWI2ZGIwODU0ZDAKPiBbwqDCoMKgwqA0Ljc0MTIwNF0g UjEzOiAwMDAwNTViNmRiMDkxMTUwIFIxNDogMDAwMDAwMDAwMDAwMDAwMCBSMTU6Cj4gMDAwMDU1 YjZkYjAzNTkyNAo+IAo+IHYyOiBTZXQgZGV2X3ByaXYtPmRpc3BsYXlfaXJxc19lbmFibGVkIHRv IHRydWUgZm9yIGFsbCBwbGF0Zm9ybXMKPiBvdGhlcgo+IHRoYW4gdmx2L2NodiB0aGF0IG1hbnVh bGx5IGNvbnRyb2wgdGhlIGRpc3BsYXkgcG93ZXIgZG9tYWluLgo+IAo+IENoZXJyeS1waWNrOiAy NjJmZDQ4NWFjNmIgKCJkcm0vaTkxNTogT25seSBlbmFibGUgaG90cGx1ZyBpbnRlcnJ1cHRzCj4g aWYgdGhlIGRpc3BsYXkgaW50ZXJydXB0cyBhcmUgZW5hYmxlZCIpCj4gRml4ZXM6IDE5NjI1ZTg1 YzZlYyAoImRybS9pOTE1OiBFbmFibGUgcG9sbGluZyB3aGVuIHdlIGRvbid0IGhhdmUKPiBocGQi KQo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9p ZD05Nzc5OAo+IFN1Z2dlc3RlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPiBDYzogTHl1ZGUgPGNwYXVsQHJlZGhhdC5jb20+Cj4gQ2M6IERhbmll bCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEhhbnMgZGUgR29lZGUgPGp3cmRl Z29lZGVAZmVkb3JhcHJvamVjdC5vcmc+Cj4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKPiBM aW5rOiBodHRwOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC9tc2dpZC8yMDE3MDIx NTEzMTU0Ny41MDYKPiA0LTEtY2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrCj4gUmV2aWV3ZWQtYnk6 IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4g wqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jwqDCoMKgwqDCoMKgfCAxMCArKysrKysr KysrCj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ob3RwbHVnLmMgfCAxNCArKysrKysr Ky0tLS0tLQo+IMKgMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4g Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gaW5kZXggZTZmZmVmMmY3MDdhLi40 ZmM4OTczNzQ0YjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiBAQCAtNDI2Niw2ICs0 MjY2LDE2IEBAIHZvaWQgaW50ZWxfaXJxX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPiAq ZGV2X3ByaXYpCj4gwqAJaWYgKCFJU19HRU4yKGRldl9wcml2KSkKPiDCoAkJZGV2LT52Ymxhbmtf ZGlzYWJsZV9pbW1lZGlhdGUgPSB0cnVlOwo+IMKgCj4gKwkvKiBNb3N0IHBsYXRmb3JtcyB0cmVh dCB0aGUgZGlzcGxheSBpcnEgYmxvY2sgYXMgYW4gYWx3YXlzLQo+IG9uCj4gKwnCoCogcG93ZXIg ZG9tYWluLiB2bHYvY2h2IGNhbiBkaXNhYmxlIGl0IGF0IHJ1bnRpbWUgYW5kIG5lZWQKPiArCcKg KiBzcGVjaWFsIGNhcmUgdG8gYXZvaWQgd3JpdGluZyBhbnkgb2YgdGhlIGRpc3BsYXkgYmxvY2sK PiByZWdpc3RlcnMKPiArCcKgKiBvdXRzaWRlIG9mIHRoZSBwb3dlciBkb21haW4uIFdlIGRlZmVy IHNldHRpbmcgdXAgdGhlCj4gZGlzcGxheSBpcnFzCj4gKwnCoCogaW4gdGhpcyBjYXNlIHRvIHRo ZSBydW50aW1lIHBtLgo+ICsJwqAqLwo+ICsJZGV2X3ByaXYtPmRpc3BsYXlfaXJxc19lbmFibGVk ID0gdHJ1ZTsKPiArCWlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVX KGRldl9wcml2KSkKPiArCQlkZXZfcHJpdi0+ZGlzcGxheV9pcnFzX2VuYWJsZWQgPSBmYWxzZTsK PiArCj4gwqAJZGV2LT5kcml2ZXItPmdldF92YmxhbmtfdGltZXN0YW1wID0KPiBpOTE1X2dldF92 YmxhbmtfdGltZXN0YW1wOwo+IMKgCWRldi0+ZHJpdmVyLT5nZXRfc2Nhbm91dF9wb3NpdGlvbiA9 Cj4gaTkxNV9nZXRfY3J0Y19zY2Fub3V0cG9zOwo+IMKgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2hvdHBsdWcuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfaG90cGx1Zy5jCj4gaW5kZXggYjYyZTNmOGFkNDE1Li41NDIwOGJlZjdhODMgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jCj4gQEAgLTIxOSw3ICsyMTksNyBAQCBzdGF0 aWMgdm9pZAo+IGludGVsX2hwZF9pcnFfc3Rvcm1fcmVlbmFibGVfd29yayhzdHJ1Y3Qgd29ya19z dHJ1Y3QgKndvcmspCj4gwqAJCQl9Cj4gwqAJCX0KPiDCoAl9Cj4gLQlpZiAoZGV2X3ByaXYtPmRp c3BsYXkuaHBkX2lycV9zZXR1cCkKPiArCWlmIChkZXZfcHJpdi0+ZGlzcGxheV9pcnFzX2VuYWJs ZWQgJiYgZGV2X3ByaXYtCj4gPmRpc3BsYXkuaHBkX2lycV9zZXR1cCkKPiDCoAkJZGV2X3ByaXYt PmRpc3BsYXkuaHBkX2lycV9zZXR1cChkZXZfcHJpdik7Cj4gwqAJc3Bpbl91bmxvY2tfaXJxKCZk ZXZfcHJpdi0+aXJxX2xvY2spOwo+IMKgCj4gQEAgLTQyNSw3ICs0MjUsNyBAQCB2b2lkIGludGVs X2hwZF9pcnFfaGFuZGxlcihzdHJ1Y3QKPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiDC oAkJfQo+IMKgCX0KPiDCoAo+IC0JaWYgKHN0b3JtX2RldGVjdGVkKQo+ICsJaWYgKHN0b3JtX2Rl dGVjdGVkICYmIGRldl9wcml2LT5kaXNwbGF5X2lycXNfZW5hYmxlZCkKPiDCoAkJZGV2X3ByaXYt PmRpc3BsYXkuaHBkX2lycV9zZXR1cChkZXZfcHJpdik7Cj4gwqAJc3Bpbl91bmxvY2soJmRldl9w cml2LT5pcnFfbG9jayk7Cj4gwqAKPiBAQCAtNDcxLDEwICs0NzEsMTIgQEAgdm9pZCBpbnRlbF9o cGRfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZQo+ICpkZXZfcHJpdikKPiDCoAnCoCogSW50 ZXJydXB0IHNldHVwIGlzIGFscmVhZHkgZ3VhcmFudGVlZCB0byBiZSBzaW5nbGUtCj4gdGhyZWFk ZWQsIHRoaXMgaXMKPiDCoAnCoCoganVzdCB0byBtYWtlIHRoZSBhc3NlcnRfc3Bpbl9sb2NrZWQg Y2hlY2tzIGhhcHB5Lgo+IMKgCcKgKi8KPiAtCXNwaW5fbG9ja19pcnEoJmRldl9wcml2LT5pcnFf bG9jayk7Cj4gLQlpZiAoZGV2X3ByaXYtPmRpc3BsYXkuaHBkX2lycV9zZXR1cCkKPiAtCQlkZXZf cHJpdi0+ZGlzcGxheS5ocGRfaXJxX3NldHVwKGRldl9wcml2KTsKPiAtCXNwaW5fdW5sb2NrX2ly cSgmZGV2X3ByaXYtPmlycV9sb2NrKTsKPiArCWlmIChkZXZfcHJpdi0+ZGlzcGxheV9pcnFzX2Vu YWJsZWQgJiYgZGV2X3ByaXYtCj4gPmRpc3BsYXkuaHBkX2lycV9zZXR1cCkgewo+ICsJCXNwaW5f bG9ja19pcnEoJmRldl9wcml2LT5pcnFfbG9jayk7Cj4gKwkJaWYgKGRldl9wcml2LT5kaXNwbGF5 X2lycXNfZW5hYmxlZCkKPiArCQkJZGV2X3ByaXYtPmRpc3BsYXkuaHBkX2lycV9zZXR1cChkZXZf cHJpdik7Cj4gKwkJc3Bpbl91bmxvY2tfaXJxKCZkZXZfcHJpdi0+aXJxX2xvY2spOwo+ICsJfQo+ IMKgfQo+IMKgCj4gwqBzdGF0aWMgdm9pZCBpOTE1X2hwZF9wb2xsX2luaXRfd29yayhzdHJ1Y3Qg d29ya19zdHJ1Y3QgKndvcmspCi0tIApDaGVlcnMsCglMeXVkZQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK