From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH 2/2] drm/i915/vbt: split out defaults that are set when there is no VBT Date: Fri, 17 Mar 2017 17:21:04 -0300 Message-ID: <1489782064.2442.220.camel@intel.com> References: <95c26079ff640d43f53b944f17e9fc356b36daec.1489152288.git.jani.nikula@intel.com> <20170310235759.GB3175@intel.com> <87lgs9fqlo.fsf@intel.com> <20170313163009.GA8626@intel.com> <87mvcotec2.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B9826EDB0 for ; Fri, 17 Mar 2017 20:21:12 +0000 (UTC) In-Reply-To: <87mvcotec2.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Manasi Navare Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org RW0gVGVyLCAyMDE3LTAzLTE0IMOgcyAxMTowOSArMDIwMCwgSmFuaSBOaWt1bGEgZXNjcmV2ZXU6 Cj4gT24gTW9uLCAxMyBNYXIgMjAxNywgTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGlu dGVsLmNvbT4gd3JvdGU6Cj4gPiAKPiA+IE9uIE1vbiwgTWFyIDEzLCAyMDE3IGF0IDExOjU1OjMx QU0gKzAyMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+ID4gPiAKPiA+ID4gT24gU2F0LCAxMSBNYXIg MjAxNywgTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KPiA+ID4gd3Jv dGU6Cj4gPiA+ID4gCj4gPiA+ID4gT24gRnJpLCBNYXIgMTAsIDIwMTcgYXQgMDM6Mjc6NThQTSAr MDIwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IFRoZSBtYWluIHRo aW5nIGFyZSB0aGUgRERJIHBvcnRzLiBJZiB0aGVyZSdzIGEgVkJUIHRoYXQgc2F5cwo+ID4gPiA+ ID4gdGhlcmUgYXJlCj4gPiA+ID4gPiBubyBvdXRwdXRzLCB3ZSBzaG91bGQgdHJ1c3QgdGhhdCwg YW5kIG5vdCBoYXZlIHNlbWktcmFuZG9tCj4gPiA+ID4gPiBkZWZhdWx0cy4gVW5mb3J0dW5hdGVs eSwgdGhlIGRlZmF1bHRzIGhhdmUgcmVzdWx0ZWQgaW4gc29tZQo+ID4gPiA+ID4gQ2hyb21lYm9v a3MKPiA+ID4gPiA+IHdpdGhvdXQgVkJUIHRvIHJlbHkgb24gdGhpcyBiZWhhdmlvdXIsIHNvIHdl IHNwbGl0IG91dCB0aGUKPiA+ID4gPiA+IGRlZmF1bHRzIGZvcgo+ID4gPiA+ID4gdGhlIG1pc3Np bmcgVkJUIGNhc2UuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IENjOiBNYW5hc2kgTmF2YXJlIDxtYW5h c2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+ID4gPiA+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBKYW5p IE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiDC oGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyB8IDE3ICsrKysrKysrKysrKysrKyst Cj4gPiA+ID4gPiDCoDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u KC0pCj4gPiA+ID4gPiAKPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9iaW9zLmMKPiA+ID4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlv cy5jCj4gPiA+ID4gPiBpbmRleCA3MTA5ODhkNzIyNTMuLjYzOWQ0NWMxZGQyZSAxMDA2NDQKPiA+ ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+ID4gPiA+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jCj4gPiA+ID4gPiBAQCAtMTM0 MSw2ICsxMzQxLDcgQEAgcGFyc2VfZGV2aWNlX21hcHBpbmcoc3RydWN0Cj4gPiA+ID4gPiBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ID4gPiA+IMKgCXJldHVybjsKPiA+ID4gPiA+IMKg fQo+ID4gPiA+ID4gwqAKPiA+ID4gPiA+ICsvKiBDb21tb24gZGVmYXVsdHMgd2hpY2ggbWF5IGJl IG92ZXJyaWRkZW4gYnkgVkJULiAqLwo+ID4gPiA+ID4gwqBzdGF0aWMgdm9pZAo+ID4gPiA+ID4g wqBpbml0X3ZidF9kZWZhdWx0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g PiA+ID4gPiDCoHsKPiA+ID4gPiA+IEBAIC0xMzc3LDYgKzEzNzgsMTggQEAgaW5pdF92YnRfZGVm YXVsdHMoc3RydWN0Cj4gPiA+ID4gPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ID4g PiA+IMKgCQkJJmRldl9wcml2LT52YnQuZGRpX3BvcnRfaW5mb1twb3J0XTsKPiA+ID4gPiA+IMKg Cj4gPiA+ID4gPiDCoAkJaW5mby0+aGRtaV9sZXZlbF9zaGlmdCA9Cj4gPiA+ID4gPiBIRE1JX0xF VkVMX1NISUZUX1VOS05PV047Cj4gPiA+ID4gPiArCX0KPiA+ID4gPiA+ICt9Cj4gPiA+ID4gPiAr Cj4gPiA+ID4gPiArLyogRGVmYXVsdHMgdG8gaW5pdGlhbGl6ZSBvbmx5IGlmIHRoZXJlIGlzIG5v IFZCVC4gKi8KPiA+ID4gPiA+ICtzdGF0aWMgdm9pZAo+ID4gPiA+ID4gK2luaXRfdmJ0X21pc3Np bmdfZGVmYXVsdHMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiA+ID4g K3sKPiA+ID4gPiA+ICsJZW51bSBwb3J0IHBvcnQ7Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArCWZv ciAocG9ydCA9IFBPUlRfQTsgcG9ydCA8IEk5MTVfTUFYX1BPUlRTOyBwb3J0KyspIHsKPiA+ID4g PiA+ICsJCXN0cnVjdCBkZGlfdmJ0X3BvcnRfaW5mbyAqaW5mbyA9Cj4gPiA+ID4gPiArCQkJJmRl dl9wcml2LT52YnQuZGRpX3BvcnRfaW5mb1twb3J0XTsKPiA+ID4gPiA+IMKgCj4gPiA+ID4gPiDC oAkJaW5mby0+c3VwcG9ydHNfZHZpID0gKHBvcnQgIT0gUE9SVF9BICYmIHBvcnQKPiA+ID4gPiA+ ICE9IFBPUlRfRSk7Cj4gPiA+ID4gPiDCoAkJaW5mby0+c3VwcG9ydHNfaGRtaSA9IGluZm8tPnN1 cHBvcnRzX2R2aTsKPiA+ID4gPiA+IEBAIC0xNTE2LDggKzE1MjksMTAgQEAgdm9pZCBpbnRlbF9i aW9zX2luaXQoc3RydWN0Cj4gPiA+ID4gPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ ID4gPiA+IMKgCXBhcnNlX2RkaV9wb3J0cyhkZXZfcHJpdiwgYmRiKTsKPiA+ID4gPiA+IMKgCj4g PiA+ID4gPiDCoG91dDoKPiA+ID4gPiA+IC0JaWYgKCF2YnQpCj4gPiA+ID4gPiArCWlmICghdmJ0 KSB7Cj4gPiA+ID4gPiDCoAkJRFJNX0lORk8oIkZhaWxlZCB0byBmaW5kIFZCSU9TIHRhYmxlcwo+ ID4gPiA+ID4gKFZCVClcbiIpOwo+ID4gPiA+ID4gKwkJaW5pdF92YnRfbWlzc2luZ19kZWZhdWx0 cyhkZXZfcHJpdik7Cj4gPiA+ID4gPiArCX0KPiA+ID4gPiAKPiA+ID4gPiBTbyBpbiBjYXNlIHRo ZXJlIGlzIG5vIFZCVCwgdGhpcyB3aWxsIHNldCBzdXBwb3J0c19EUCBmbGFnIG9uCj4gPiA+ID4g UG9ydCBBLgo+ID4gPiA+IFdoYXQgaXMgdGhlcmUgaXMgbm8gVkJUIGFuZCB0aGVyZSBpcyBubyBl RFAgb24gUG9ydCBBPwo+ID4gPiA+IEluIHRoaXMgY2FzZSBpdCB3aWxsIHN0aWxsIHRyeSB0byBs aW5rIHRyYWluIG9uIFBvcnQgQSBhbmQKPiA+ID4gPiBmYWlsLi4/Cj4gPiA+ID4gSSBhbSBub3Qg c3VyZSBpZiB0aGlzIGNhc2UgZXhpc3RzLCBidXQganVzdCBhIHRob3VnaHQgbG9va2luZwo+ID4g PiA+IGF0IGl0Lgo+ID4gPiAKPiA+ID4gSXQncyBwb3NzaWJsZSB0aGUgY2FzZSBleGlzdHMsIGJ1 dCB0aGUgcG9pbnQgaXMgdGhhdCB0aGUKPiA+ID4gYmVoYXZpb3VyIGZvcgo+ID4gPiB0aGUgbm8t VkJUIGNhc2UgcmVtYWlucyB0aGUgc2FtZSBiZWZvcmUgYW5kIGFmdGVyIHRoaXMgcGF0Y2guCj4g PiA+IAo+ID4gPiBCUiwKPiA+ID4gSmFuaS4KPiA+ID4gCj4gPiA+IAo+ID4gCj4gPiBPayBhZ3Jl ZWQuIEluIHRoYXQgY2FzZSBSZXZpZXdlZC1ieTogTWFuYXNpIE5hdmFyZQo+ID4gPG1hbmFzaS5k Lm5hdmFyZUBpbnRlbC5jb20+Cj4gCj4gUHVzaGVkIHRvIGRybS1pbnRlbC1uZXh0LXF1ZXVlZCwg dGhhbmtzIGZvciB0aGUgcmV2aWV3Lgo+IAo+IEkgcmVhbGx5IGhvcGUgdGhlcmUgYXJlIG5vIG1h Y2hpbmVzIG91dCB0aGVyZSB0aGF0IGhhdmUgYSBjcmlwcGxlZAo+IFZCVAo+IHdpdGggbm8gY2hp bGQgZGV2aWNlIGNvbmZpZy4gSSBndWVzcyB3ZSdsbCBmaW5kIG91dC4uLgoKSSBoYXZlIGFjY2Vz cyB0byB0aGlzIHZlcnkgaW50ZXJlc3RpbmcgbWFjaGluZSB3aXRoIEREQiB2ZXJzaW9uIDE2MyBh bmQKYSBjaGlsZCBkZXZpY2Ugc2l6ZSBjb25maWcgdGhhdCdzIDEgaW5zdGVhZCBvZiB0aGUgZXhw ZWN0ZWQgMzMuCgpTbyB3aGF0IGhhcHBlbnMgaGVyZSBpcyB0aGF0IHNpbmNlIHRoZSBWQlQgaXMg c3VwcG9zZWQgdG8gYmUgdmFsaWQgd2UKZG9uJ3QgZW5kIHVwIGNhbGxpbmcgaW5pdF92YnRfbWlz c2luZ19kZWZhdWlsdHMoKS4gV2UgcmV0dXJuIGVhcmx5IGZyb20KcGFyc2VfZGV2aWNlX21hcHBp bmcoKSwgd2hpY2ggbWVhbnMgd2UgZG9uJ3Qgc2V0IHZidC5jaGlsZF9kZXZfbnVtLAp3aGljaCBt ZWFucyB0aGF0IHBhcnNlX2RkaV9wb3J0KCkgcmV0dXJucyBlYXJseS4gU28gaW5mby0+c3VwcG9y dHNfKgpzdGF5cyBmYWxzZSwgYW5kIGludGVsX2RkaV9pbml0KCkgZmFpbHMuCgpHaXZlbiB5b3Vy IGNvbW1pdCBtZXNzYWdlIGl0IHNlZW1zIHRoYXQgd2Ugc2hvdWxkIHByb3Blcmx5IGJlIGFibGUg dG8KZGlzdGluZ3Vpc2ggYmV0d2VlbiAiVkJUIGNvcnJlY3RseSBzYXlzIHRoYXQgdGhlcmUncyBu byBvdXRwdXQiIGFuZAoiVkJUIGlzIGRydW5rIGFuZCBzaG91bGQgZ28gaG9tZSIgaW4gb3JkZXIg dG8gZml4IHRoaXMgcHJvYmxlbS4KCkkgY2FuIGNvbmZpcm0gdGhhdCByZXZlcnRpbmcgdGhpcyBw YXRjaCBtYWtlcyBkaXNwbGF5IGdyZWF0IGFnYWluXndedwp3b3JrIGFnYWluLiBTbyB1bmZvcnR1 bmF0ZWx5IEknbGwgaGF2ZSB0byBjYWxsIHJlZ3Jlc3Npb24gb24gdGhpcwpwYXRjaC4KCj4gCj4g QlIsCj4gSmFuaS4KPiAKPiAKPiA+IAo+ID4gCj4gPiBSZWdhcmRzCj4gPiBNYW5hc2kKPiA+IAo+ ID4gwqAKPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4gSWYgc3VjaCBhIGNhc2UgZG9lcyBub3QgZXhp c3QsIHRoZW4gdGhpcyB3aWxsIHNvbHZlIG91ciBwcm9ibGVtCj4gPiA+ID4gb2YKPiA+ID4gPiBj dXJyZW50IGZhaWx1cmVzIGJlY2F1c2UgbGVhdmluZyBkZWZhdWx0cyBvbiBQb3J0IEEuIFNvIGlu IHRoYXQKPiA+ID4gPiBjYXNlCj4gPiA+ID4gaXQgbGd0bS4KPiA+ID4gPiAKPiA+ID4gPiBSZWdh cmRzCj4gPiA+ID4gTWFuYXNpCj4gPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4gPiAKPiA+ID4gPiA+ IMKgCj4gPiA+ID4gPiDCoAlpZiAoYmlvcykKPiA+ID4gPiA+IMKgCQlwY2lfdW5tYXBfcm9tKHBk ZXYsIGJpb3MpOwo+ID4gPiA+ID4gLS3CoAo+ID4gPiA+ID4gMi4xLjQKPiA+ID4gPiA+IAo+ID4g PiAKPiA+ID4gLS3CoAo+ID4gPiBKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5v bG9neSBDZW50ZXIKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==