From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Oscar Mateo <oscar.mateo@intel.com>,
Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/uc: Make intel_uc_prepare_fw() static
Date: Tue, 21 Mar 2017 11:52:37 +0200 [thread overview]
Message-ID: <1490089957.3132.12.camel@linux.intel.com> (raw)
In-Reply-To: <ea8e7c8b-ee1d-c930-2ae8-5026ed1e149c@intel.com>
On ma, 2017-03-20 at 10:17 -0700, Oscar Mateo wrote:
>
> On 03/15/2017 12:38 PM, Michal Wajdeczko wrote:
> >
> > +static void intel_uc_prepare_fw(struct drm_i915_private *dev_priv,
> > + struct intel_uc_fw *uc_fw)
> > +{
> > + struct pci_dev *pdev = dev_priv->drm.pdev;
> >
> No need for prefix intel_*, since it's a static function?
True so, can you rename Michal and send v2. You can keep my R-b.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-03-21 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 19:38 [PATCH] drm/i915/uc: Make intel_uc_prepare_fw() static Michal Wajdeczko
2017-03-15 19:55 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-03-20 10:01 ` [PATCH] " Joonas Lahtinen
2017-03-20 17:17 ` Oscar Mateo
2017-03-21 9:52 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490089957.3132.12.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
--cc=oscar.mateo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).