From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Oscar Mateo <oscar.mateo@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 01/12] drm/i915/guc: Sanitize GuC client initialization
Date: Wed, 22 Mar 2017 11:28:39 +0200 [thread overview]
Message-ID: <1490174919.2802.10.camel@linux.intel.com> (raw)
In-Reply-To: <1490086977-9282-2-git-send-email-oscar.mateo@intel.com>
It's a good practice to use "git am" to apply the original patch and
then "git commit --amend" to it, so that the "From: " field stays
intact. Or use git commit --amend --author="John Doe <foo@bar.org>" but
that is more prone to typos.
On ti, 2017-03-21 at 02:02 -0700, Oscar Mateo wrote:
> Started adding proper teardown to guc_client_alloc, ended up removing
> quite a few dead ends where errors communicating with the GuC were
> silently ignored. There also seemed to be quite a few erronous
> teardown actions performed in case of an error (ordering wrong).
>
> v2:
> - Increase function symmetry/proximity (Michal/Daniele)
> - Fix __reserve_doorbell accounting for high priority (Daniele)
> - Call __update_doorbell_desc! (Daniele)
> - Isolate __guc_{,de}allocate_doorbell (Michal/Daniele)
>
> v3:
> - "Select" a cacheline is a more accurate verb than "reserve" (Daniele).
> - We cannot update & create the doorbell without reserving it first, so
> move the whole doorbell creation for execbuf_client to the submission
> enable (Oscar).i
> - Add a fixme for ignoring possible doorbell destroy errors.
>
> v4:
> - Remove comment about is_high_priority (Daniele)
> - Debug message typo (Daniele)
> - Reuse __get_doorbell in more places (Daniele)
> - Do not do arithmetic on void pointers (Daniele)
> - Add comment to __reset_doorbell (Daniele)
>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
The R-b should probably be after S-o-b if it was to last version.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-22 9:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 9:02 [PATCH 00/12] Various improvements around the GuC topic Oscar Mateo
2017-03-21 9:02 ` [PATCH 01/12] drm/i915/guc: Sanitize GuC client initialization Oscar Mateo
2017-03-22 9:28 ` Joonas Lahtinen [this message]
2017-03-22 9:46 ` Oscar Mateo
2017-03-21 9:02 ` [PATCH 02/12] drm/i915/guc: Keep the ctx_pool_vaddr mapped, for easy access Oscar Mateo
2017-03-22 9:45 ` Chris Wilson
2017-03-22 9:42 ` Oscar Mateo
2017-03-22 16:57 ` Chris Wilson
2017-03-21 9:02 ` [PATCH 03/12] drm/i915/guc: Add onion teardown to the GuC setup Oscar Mateo
2017-03-21 9:02 ` [PATCH 04/12] drm/i915/guc: The Additional Data Struct (ADS) should get enabled together with GuC submission Oscar Mateo
2017-03-21 17:51 ` Ceraolo Spurio, Daniele
2017-03-21 9:02 ` [PATCH 05/12] drm/i915/guc: Break out the GuC log extras into their own "runtime" struct Oscar Mateo
2017-03-21 9:02 ` [PATCH 06/12] drm/i915/guc: Make intel_guc_send a function pointer Oscar Mateo
2017-03-21 9:02 ` [PATCH 07/12] drm/i915/guc: Improve the GuC documentation & comments about proxy submissions Oscar Mateo
2017-03-21 17:54 ` Ceraolo Spurio, Daniele
2017-03-21 9:02 ` [PATCH 08/12] drm/i915/guc: Wait for doorbell to be inactive before deallocating Oscar Mateo
2017-03-21 18:20 ` Ceraolo Spurio, Daniele
2017-03-21 11:24 ` Oscar Mateo
2017-03-22 9:33 ` Joonas Lahtinen
2017-03-21 9:02 ` [PATCH 09/12] drm/i915/guc: A little bit more of doorbell sanitization Oscar Mateo
2017-03-21 9:02 ` [PATCH 10/12] drm/i915/guc: Refactor the concept "GuC context descriptor" into "GuC stage descriptor" Oscar Mateo
2017-03-22 10:05 ` Joonas Lahtinen
2017-03-21 9:02 ` [PATCH 11/12] drm/i915/guc: Split out the mmio_white_list struct Oscar Mateo
2017-03-21 18:04 ` Ceraolo Spurio, Daniele
2017-03-21 9:02 ` [PATCH 12/12] drm/i915/guc: Move guc_interrupts_release next to guc_interrupts_capture Oscar Mateo
2017-03-21 18:08 ` Ceraolo Spurio, Daniele
2017-03-21 17:42 ` ✗ Fi.CI.BAT: warning for Various improvements around the GuC topic Patchwork
2017-03-22 10:08 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490174919.2802.10.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=oscar.mateo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).