From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH] drm/i915: simplify intel_ddi_pll_select() Date: Wed, 22 Mar 2017 14:33:31 -0300 Message-ID: <1490204011.25640.1.camel@intel.com> References: <1490133430-13999-1-git-send-email-paulo.r.zanoni@intel.com> <1490138651.13532.11.camel@dk-H97M-D3H> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id E01066E94C for ; Wed, 22 Mar 2017 17:33:39 +0000 (UTC) In-Reply-To: <1490138651.13532.11.camel@dk-H97M-D3H> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Pandiyan, Dhinakaran" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org RW0gVGVyLCAyMDE3LTAzLTIxIMOgcyAyMzowNSArMDAwMCwgUGFuZGl5YW4sIERoaW5ha2FyYW4g ZXNjcmV2ZXU6Cj4gT24gVHVlLCAyMDE3LTAzLTIxIGF0IDE4OjU3IC0wMzAwLCBQYXVsbyBaYW5v bmkgd3JvdGU6Cj4gPiAKPiA+IEJlY2F1c2Uge2hzdyxza2wsYnh0fV9kZGlfcGxsX3NlbGVjdCBh bGwgcHJldHR5IG11Y2ggZG8gdGhlIHNhbWUKPiA+IHRoaW5nCj4gPiBpbiBzbGlnaHRseSBkaWZm ZXJlbnQgd2F5cy4gUmVwbGFjZSBldmVyeXRoaW5nIHdpdGggYSBzaW1wbGUgY29weQo+ID4gb2YK PiA+IHRoZSBmdW5jdGlvbiBhbmQgaW5saW5lIGl0IGluc2lkZSBpbnRsZV9kZGlfcGxsX3NlbGVj dCgpLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25p QGludGVsLmNvbT4KPiA+IC0tLQo+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGku YyB8IDU4ICsrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+IC0tLS0tLS0tLS0tLQo+ID4g wqAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA1MSBkZWxldGlvbnMoLSkKPiA+IAo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiBpbmRleCBkODIxNGJhLi5iZDZmZDBi IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiBAQCAtMTEyNyw0NyArMTEy Nyw2IEBAIHZvaWQgaW50ZWxfZGRpX2Nsb2NrX2dldChzdHJ1Y3QKPiA+IGludGVsX2VuY29kZXIg KmVuY29kZXIsCj4gPiDCoAkJYnh0X2RkaV9jbG9ja19nZXQoZW5jb2RlciwgcGlwZV9jb25maWcp Owo+ID4gwqB9Cj4gPiDCoAo+ID4gLXN0YXRpYyBib29sCj4gPiAtaHN3X2RkaV9wbGxfc2VsZWN0 KHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAo+ID4gLQkJwqDCoMKgc3RydWN0IGludGVs X2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gPiAtCQnCoMKgwqBzdHJ1Y3QgaW50ZWxfZW5jb2Rl ciAqZW5jb2RlcikKPiA+IC17Cj4gPiAtCXN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsOwo+ ID4gLQo+ID4gLQlwbGwgPSBpbnRlbF9nZXRfc2hhcmVkX2RwbGwoaW50ZWxfY3J0YywgY3J0Y19z dGF0ZSwKPiA+IC0JCQkJwqDCoMKgwqBlbmNvZGVyKTsKPiAKPiBJIGhhdmUgYSByZWxhdGVkIHF1 ZXN0aW9uLCBub3QgYSBwYXRjaCByZXZpZXcgOikgTG9va3MgbGlrZSB3ZSBjYXJlCj4gb25seQo+ IGFib3V0IHRoZSBib29sZWFuIHJldHVybmVkIGZyb20gaW50ZWxfZ2V0X3NoYXJlZF9kcGxsKCku IENvdWxkIG5vdAo+IGZpbmQKPiBhbnkgY2FsbGVyIHRoYXQgdXNlcyB0aGUgcmV0dXJuZWQgJ3N0 cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqJy4KPiBTaG91bGQKPiBpdCdzIHNpZ25hdHVyZSBiZSBz aW1wbHkgY2hhbmdlZCB0byByZXR1cm4gYSBib29sP8KgCgpUaGVyZSBhcmUgb25seSB0d28gY2Fs bGVycy4gSXQgd291bGQgYmUgcG9zc2libGUgdG8gY2hhbmdlIHRoZQpzaWduYXR1cmUsIGFsdGhv dWdoIEkgZG9uJ3Qgc2VlIG1hbnkgYmVuZWZpdHMgZnJvbSBkb2luZyBpdCBub3cuCgpQZXJoYXBz IGl0IHdvdWxkIGJlIGJldHRlciB0byB1bmlmeSB0aGUgZXJyb3IgaGFuZGxpbmcuCgo+IAo+IC1E Swo+ID4gCj4gPiAtCWlmICghcGxsKQo+ID4gLQkJRFJNX0RFQlVHX0RSSVZFUigiZmFpbGVkIHRv IGZpbmQgUExMIGZvciBwaXBlCj4gPiAlY1xuIiwKPiA+IC0JCQkJwqBwaXBlX25hbWUoaW50ZWxf Y3J0Yy0+cGlwZSkpOwo+ID4gLQo+ID4gLQlyZXR1cm4gcGxsOwo+ID4gLX0KPiA+IC0KPiA+IC1z dGF0aWMgYm9vbAo+ID4gLXNrbF9kZGlfcGxsX3NlbGVjdChzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50 ZWxfY3J0YywKPiA+IC0JCcKgwqDCoHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRl LAo+ID4gLQkJwqDCoMKgc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gPiAtewo+ID4g LQlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbDsKPiA+IC0KPiA+IC0JcGxsID0gaW50ZWxf Z2V0X3NoYXJlZF9kcGxsKGludGVsX2NydGMsIGNydGNfc3RhdGUsCj4gPiBlbmNvZGVyKTsKPiA+ IC0JaWYgKHBsbCA9PSBOVUxMKSB7Cj4gPiAtCQlEUk1fREVCVUdfRFJJVkVSKCJmYWlsZWQgdG8g ZmluZCBQTEwgZm9yIHBpcGUKPiA+ICVjXG4iLAo+ID4gLQkJCQnCoHBpcGVfbmFtZShpbnRlbF9j cnRjLT5waXBlKSk7Cj4gPiAtCQlyZXR1cm4gZmFsc2U7Cj4gPiAtCX0KPiA+IC0KPiA+IC0JcmV0 dXJuIHRydWU7Cj4gPiAtfQo+ID4gLQo+ID4gLXN0YXRpYyBib29sCj4gPiAtYnh0X2RkaV9wbGxf c2VsZWN0KHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAo+ID4gLQkJwqDCoMKgc3RydWN0 IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gPiAtCQnCoMKgwqBzdHJ1Y3QgaW50ZWxf ZW5jb2RlciAqZW5jb2RlcikKPiA+IC17Cj4gPiAtCXJldHVybiAhIWludGVsX2dldF9zaGFyZWRf ZHBsbChpbnRlbF9jcnRjLCBjcnRjX3N0YXRlLAo+ID4gZW5jb2Rlcik7Cj4gPiAtfQo+ID4gLQo+ ID4gwqAvKgo+ID4gwqAgKiBUcmllcyB0byBmaW5kIGEgKnNoYXJlZCogUExMIGZvciB0aGUgQ1JU QyBhbmQgc3RvcmUgaXQgaW4KPiA+IMKgICogaW50ZWxfY3J0Yy0+ZGRpX3BsbF9zZWwuCj4gPiBA QCAtMTE3OCwxOSArMTEzNywxNiBAQCBieHRfZGRpX3BsbF9zZWxlY3Qoc3RydWN0IGludGVsX2Ny dGMKPiA+ICppbnRlbF9jcnRjLAo+ID4gwqBib29sIGludGVsX2RkaV9wbGxfc2VsZWN0KHN0cnVj dCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAo+ID4gwqAJCQnCoMKgc3RydWN0IGludGVsX2NydGNf c3RhdGUgKmNydGNfc3RhdGUpCj4gPiDCoHsKPiA+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gdG9faTkxNShpbnRlbF9jcnRjLQo+ID4gPmJhc2UuZGV2KTsKPiA+IMKgCXN0 cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyID0KPiA+IMKgCQlpbnRlbF9kZGlfZ2V0X2NydGNf bmV3X2VuY29kZXIoY3J0Y19zdGF0ZSk7Cj4gPiArCXN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAq cGxsOwo+ID4gwqAKPiA+IC0JaWYgKElTX0dFTjlfQkMoZGV2X3ByaXYpKQo+ID4gLQkJcmV0dXJu IHNrbF9kZGlfcGxsX3NlbGVjdChpbnRlbF9jcnRjLCBjcnRjX3N0YXRlLAo+ID4gLQkJCQkJwqDC oGVuY29kZXIpOwo+ID4gLQllbHNlIGlmIChJU19HRU45X0xQKGRldl9wcml2KSkKPiA+IC0JCXJl dHVybiBieHRfZGRpX3BsbF9zZWxlY3QoaW50ZWxfY3J0YywgY3J0Y19zdGF0ZSwKPiA+IC0JCQkJ CcKgwqBlbmNvZGVyKTsKPiA+IC0JZWxzZQo+ID4gLQkJcmV0dXJuIGhzd19kZGlfcGxsX3NlbGVj dChpbnRlbF9jcnRjLCBjcnRjX3N0YXRlLAo+ID4gLQkJCQkJwqDCoGVuY29kZXIpOwo+ID4gKwlw bGwgPSBpbnRlbF9nZXRfc2hhcmVkX2RwbGwoaW50ZWxfY3J0YywgY3J0Y19zdGF0ZSwKPiA+IGVu Y29kZXIpOwo+ID4gKwlpZiAoIXBsbCkKPiA+ICsJCURSTV9ERUJVR19EUklWRVIoImZhaWxlZCB0 byBmaW5kIFBMTCBmb3IgcGlwZQo+ID4gJWNcbiIsCj4gPiArCQkJCcKgwqBwaXBlX25hbWUoaW50 ZWxfY3J0Yy0+cGlwZSkpOwo+ID4gKwo+ID4gKwlyZXR1cm4gcGxsOwo+ID4gwqB9Cj4gPiDCoAo+ ID4gwqB2b2lkIGludGVsX2RkaV9zZXRfcGlwZV9zZXR0aW5ncyhjb25zdCBzdHJ1Y3QgaW50ZWxf Y3J0Y19zdGF0ZQo+ID4gKmNydGNfc3RhdGUpCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=