From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: simplify intel_ddi_pll_select()
Date: Wed, 22 Mar 2017 14:40:01 -0300
Message-ID: <1490204401.25640.6.camel@intel.com>
References: <1490133430-13999-1-git-send-email-paulo.r.zanoni@intel.com>
 <20170322132104.GC31595@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C074A6E269
 for <intel-gfx@lists.freedesktop.org>; Wed, 22 Mar 2017 17:40:07 +0000 (UTC)
In-Reply-To: <20170322132104.GC31595@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

RW0gUXVhLCAyMDE3LTAzLTIyIMOgcyAxNToyMSArMDIwMCwgVmlsbGUgU3lyasOkbMOkIGVzY3Jl
dmV1Ogo+IE9uIFR1ZSwgTWFyIDIxLCAyMDE3IGF0IDA2OjU3OjEwUE0gLTAzMDAsIFBhdWxvIFph
bm9uaSB3cm90ZToKPiA+IAo+ID4gQmVjYXVzZSB7aHN3LHNrbCxieHR9X2RkaV9wbGxfc2VsZWN0
IGFsbCBwcmV0dHkgbXVjaCBkbyB0aGUgc2FtZQo+ID4gdGhpbmcKPiA+IGluIHNsaWdodGx5IGRp
ZmZlcmVudCB3YXlzLiBSZXBsYWNlIGV2ZXJ5dGhpbmcgd2l0aCBhIHNpbXBsZSBjb3B5Cj4gPiBv
Zgo+ID4gdGhlIGZ1bmN0aW9uIGFuZCBpbmxpbmUgaXQgaW5zaWRlIGludGxlX2RkaV9wbGxfc2Vs
ZWN0KCkuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5v
bmlAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rk
aS5jIHwgNTggKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gLS0tLS0tLS0tLS0tCj4g
PiDCoDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDUxIGRlbGV0aW9ucygtKQo+ID4g
Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+IGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+IGluZGV4IGQ4MjE0YmEuLmJkNmZk
MGIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4g
KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+IEBAIC0xMTI3LDQ3ICsx
MTI3LDYgQEAgdm9pZCBpbnRlbF9kZGlfY2xvY2tfZ2V0KHN0cnVjdAo+ID4gaW50ZWxfZW5jb2Rl
ciAqZW5jb2RlciwKPiA+IMKgCQlieHRfZGRpX2Nsb2NrX2dldChlbmNvZGVyLCBwaXBlX2NvbmZp
Zyk7Cj4gPiDCoH0KPiA+IMKgCj4gPiAtc3RhdGljIGJvb2wKPiA+IC1oc3dfZGRpX3BsbF9zZWxl
Y3Qoc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMsCj4gPiAtCQnCoMKgwqBzdHJ1Y3QgaW50
ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiA+IC0JCcKgwqDCoHN0cnVjdCBpbnRlbF9lbmNv
ZGVyICplbmNvZGVyKQo+ID4gLXsKPiA+IC0Jc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpwbGw7
Cj4gPiAtCj4gPiAtCXBsbCA9IGludGVsX2dldF9zaGFyZWRfZHBsbChpbnRlbF9jcnRjLCBjcnRj
X3N0YXRlLAo+ID4gLQkJCQnCoMKgwqDCoGVuY29kZXIpOwo+ID4gLQlpZiAoIXBsbCkKPiA+IC0J
CURSTV9ERUJVR19EUklWRVIoImZhaWxlZCB0byBmaW5kIFBMTCBmb3IgcGlwZQo+ID4gJWNcbiIs
Cj4gPiAtCQkJCcKgcGlwZV9uYW1lKGludGVsX2NydGMtPnBpcGUpKTsKPiA+IC0KPiA+IC0JcmV0
dXJuIHBsbDsKPiA+IC19Cj4gPiAtCj4gPiAtc3RhdGljIGJvb2wKPiA+IC1za2xfZGRpX3BsbF9z
ZWxlY3Qoc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMsCj4gPiAtCQnCoMKgwqBzdHJ1Y3Qg
aW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiA+IC0JCcKgwqDCoHN0cnVjdCBpbnRlbF9l
bmNvZGVyICplbmNvZGVyKQo+ID4gLXsKPiA+IC0Jc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpw
bGw7Cj4gPiAtCj4gPiAtCXBsbCA9IGludGVsX2dldF9zaGFyZWRfZHBsbChpbnRlbF9jcnRjLCBj
cnRjX3N0YXRlLAo+ID4gZW5jb2Rlcik7Cj4gPiAtCWlmIChwbGwgPT0gTlVMTCkgewo+ID4gLQkJ
RFJNX0RFQlVHX0RSSVZFUigiZmFpbGVkIHRvIGZpbmQgUExMIGZvciBwaXBlCj4gPiAlY1xuIiwK
PiA+IC0JCQkJwqBwaXBlX25hbWUoaW50ZWxfY3J0Yy0+cGlwZSkpOwo+ID4gLQkJcmV0dXJuIGZh
bHNlOwo+ID4gLQl9Cj4gPiAtCj4gPiAtCXJldHVybiB0cnVlOwo+ID4gLX0KPiA+IC0KPiA+IC1z
dGF0aWMgYm9vbAo+ID4gLWJ4dF9kZGlfcGxsX3NlbGVjdChzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50
ZWxfY3J0YywKPiA+IC0JCcKgwqDCoHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRl
LAo+ID4gLQkJwqDCoMKgc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gPiAtewo+ID4g
LQlyZXR1cm4gISFpbnRlbF9nZXRfc2hhcmVkX2RwbGwoaW50ZWxfY3J0YywgY3J0Y19zdGF0ZSwK
PiA+IGVuY29kZXIpOwo+ID4gLX0KPiA+IC0KPiA+IMKgLyoKPiA+IMKgICogVHJpZXMgdG8gZmlu
ZCBhICpzaGFyZWQqIFBMTCBmb3IgdGhlIENSVEMgYW5kIHN0b3JlIGl0IGluCj4gPiDCoCAqIGlu
dGVsX2NydGMtPmRkaV9wbGxfc2VsLgo+ID4gQEAgLTExNzgsMTkgKzExMzcsMTYgQEAgYnh0X2Rk
aV9wbGxfc2VsZWN0KHN0cnVjdCBpbnRlbF9jcnRjCj4gPiAqaW50ZWxfY3J0YywKPiA+IMKgYm9v
bCBpbnRlbF9kZGlfcGxsX3NlbGVjdChzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YywKPiA+
IMKgCQkJwqDCoHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ID4gwqB7Cj4g
PiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoaW50ZWxfY3J0
Yy0KPiA+ID5iYXNlLmRldik7Cj4gPiDCoAlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciA9
Cj4gPiDCoAkJaW50ZWxfZGRpX2dldF9jcnRjX25ld19lbmNvZGVyKGNydGNfc3RhdGUpOwo+ID4g
KwlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbDsKPiA+IMKgCj4gPiAtCWlmIChJU19HRU45
X0JDKGRldl9wcml2KSkKPiA+IC0JCXJldHVybiBza2xfZGRpX3BsbF9zZWxlY3QoaW50ZWxfY3J0
YywgY3J0Y19zdGF0ZSwKPiA+IC0JCQkJCcKgwqBlbmNvZGVyKTsKPiA+IC0JZWxzZSBpZiAoSVNf
R0VOOV9MUChkZXZfcHJpdikpCj4gPiAtCQlyZXR1cm4gYnh0X2RkaV9wbGxfc2VsZWN0KGludGVs
X2NydGMsIGNydGNfc3RhdGUsCj4gPiAtCQkJCQnCoMKgZW5jb2Rlcik7Cj4gPiAtCWVsc2UKPiA+
IC0JCXJldHVybiBoc3dfZGRpX3BsbF9zZWxlY3QoaW50ZWxfY3J0YywgY3J0Y19zdGF0ZSwKPiA+
IC0JCQkJCcKgwqBlbmNvZGVyKTsKPiA+ICsJcGxsID0gaW50ZWxfZ2V0X3NoYXJlZF9kcGxsKGlu
dGVsX2NydGMsIGNydGNfc3RhdGUsCj4gPiBlbmNvZGVyKTsKPiAKPiBJIHdvbmRlciBpZiBpbnRl
bF9kZGlfcGxsX3NlbGVjdCgpIGhhcyBhbnkgZ29vZCByZWFzb24gdG8gZXZlbiBleGlzdAo+IGFu
eW1vcmUuIEl0J3MganVzdCBjYWxsaW5nIHRoaXMgb25lIGZ1bmN0aW9uLCBzbyBtYXliZSB3ZSBz
aG91bGQganVzdAo+IGNhbGwgaXQgZGlyZWN0bHk/CgpZb3UncmUgcmlnaHQgaGVyZS4gVGhlbiB0
aGUgdHdvIGNhbGxlcnMgd291bGQgYmUKaGFzd2VsbF9jcnRjX2NvbXB1dGVfY2xvY2soKSBhbmQg
aXJvbmxha2VfY3J0Y19jb21wdXRlX2Nsb2NrKCksIHdoaWNoCm1ha2VzIGV2ZW4gbW9yZSBzZW5l
LiBJJ2xsIHN1Ym1pdCBhbm90aGVyIHBhdGNoLgoKPiAKPiA+IAo+ID4gKwlpZiAoIXBsbCkKPiA+
ICsJCURSTV9ERUJVR19EUklWRVIoImZhaWxlZCB0byBmaW5kIFBMTCBmb3IgcGlwZQo+ID4gJWNc
biIsCj4gPiArCQkJCcKgwqBwaXBlX25hbWUoaW50ZWxfY3J0Yy0+cGlwZSkpOwo+ID4gKwo+ID4g
KwlyZXR1cm4gcGxsOwo+IAo+IEkgd291bGQgcHJvYmFibHkgd3JpdGUgJ3BsbCAhPSBOVUxMJyBm
b3IgYSBiaXQgb2YgZXh0cmEgY2xhcml0eS4KCkFyZSB5b3UgdGFsa2luZyBhYm91dCB0aGUgcmV0
dXJuIHN0YXRlbWVudCBvciB0aGUgaWYgY29uZGl0aW9uPwoKSSdsbCBhc3N1bWUgeW91J3JlIHRh
bGtpbmcgYWJvdXQgdGhlIHJldHVybiBzdGF0ZW1lbnQuIEkgY2FuIGZpeCB0aGlzLgpBbm90aGVy
IHRoaW5nIHdvdWxkIGJlICJyZXR1cm4gISFwbGwiLiBJJ20gZmluZSB3aXRoIGFsbCBhcHByb2Fj
aGVzLgoKPiAKPiBFaXRoZXIgd2F5Cj4gUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmls
bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpUaGFua3MhCgo+IAo+ID4gCj4gPiDCoH0KPiA+
IMKgCj4gPiDCoHZvaWQgaW50ZWxfZGRpX3NldF9waXBlX3NldHRpbmdzKGNvbnN0IHN0cnVjdCBp
bnRlbF9jcnRjX3N0YXRlCj4gPiAqY3J0Y19zdGF0ZSkKPiA+IC0twqAKPiA+IDIuNy40Cj4gPiAK
PiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJ
bnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs
LWdmeAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ
bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0
cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK