intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: "Dong, Chuanxiao" <chuanxiao.dong@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "intel-gvt-dev@lists.freedesktop.org"
	<intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [PATCH v4] drm/i915/scheduler: add gvt notification for guc submission
Date: Mon, 27 Mar 2017 14:43:32 +0300	[thread overview]
Message-ID: <1490615012.3166.19.camel@linux.intel.com> (raw)
In-Reply-To: <17296D9F8FF2234F831FC3DF505A87A96321BCCB@SHSMSX103.ccr.corp.intel.com>

On ma, 2017-03-27 at 10:58 +0000, Dong, Chuanxiao wrote:
> >
> > > @@ -634,6 +636,8 @@ static void i915_guc_irq_handler(unsigned long data)
> > > 
> > >  		rq = port[0].request;
> > >  		while (rq && i915_gem_request_completed(rq)) {
> > >  			trace_i915_gem_request_out(rq);
> > > +			intel_gvt_notify_context_status(rq,
> > > +					INTEL_CONTEXT_SCHEDULE_OUT);
> > 
> > Code indent is still broken.
> Hi Joonas, I am sorry for not getting this code indent issue. The
> above code is just split by typing an enter due to longer than 80
> characters. Are you expecting to see the code like below? The 2nd
> line will be longer than 80 characters in below case. If this is fine
> then I will change this in the next version.
> > 			intel_gvt_notify_context_status(rq,
> > 							INTEL_CONTEXT_SCHEDULE_OUT);
> 

My bad, I missed one tab.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-03-27 11:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20  1:48 [PATCH] drm/i915/scheduler: add gvt notification for guc submission Chuanxiao Dong
2017-03-20  2:46 ` Zheng, Xiao
2017-03-20  3:19   ` Dong, Chuanxiao
2017-03-21  1:38     ` Zheng, Xiao
2017-03-21  1:58       ` Dong, Chuanxiao
2017-03-21  2:38 ` [PATCH v2] " Chuanxiao Dong
2017-03-21  3:07 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-03-21 11:23 ` ✗ Fi.CI.BAT: failure " Patchwork
2017-03-22  6:34 ` [PATCH v3] " Chuanxiao Dong
2017-03-23  5:29   ` Dong, Chuanxiao
2017-03-23  7:58     ` Tian, Kevin
2017-03-23  9:37   ` Joonas Lahtinen
2017-03-23  9:42     ` Chris Wilson
2017-03-23 13:43       ` Dong, Chuanxiao
2017-03-23 13:43     ` Dong, Chuanxiao
2017-03-23  9:51   ` Tvrtko Ursulin
2017-03-23 13:51     ` Dong, Chuanxiao
2017-03-24  1:49 ` [PATCH v4] " Chuanxiao Dong
2017-03-27  2:35   ` Dong, Chuanxiao
2017-03-27 10:14   ` Joonas Lahtinen
2017-03-27 10:58     ` Dong, Chuanxiao
2017-03-27 11:43       ` Joonas Lahtinen [this message]
2017-03-27 13:32 ` [PATCH v5] " Chuanxiao Dong
2017-03-27 13:49   ` Chris Wilson
2017-03-27 14:22     ` Dong, Chuanxiao
2017-03-27 14:33       ` Chris Wilson
2017-03-27 14:39         ` Dong, Chuanxiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490615012.3166.19.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chuanxiao.dong@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).