From: John Spotswood <john.a.spotswood@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"Srivatsa, Anusha" <anusha.srivatsa@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/i915/GuC/GLK: Load GuC on GLK
Date: Tue, 28 Mar 2017 17:32:49 -0700 [thread overview]
Message-ID: <1490747569.21875.1.camel@intel.com> (raw)
In-Reply-To: <1490745677.3198.2.camel@rdvivi-vienna>
On Tue, 2017-03-28 at 17:01 -0700, Vivi, Rodrigo wrote:
> On Tue, 2017-03-28 at 22:11 +0000, Srivatsa, Anusha wrote:
> >
> >
> > >
> > > -----Original Message-----
> > > From: Spotswood, John A
> > > Sent: Tuesday, March 28, 2017 2:35 PM
> > > To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> > > gfx@lists.freedesktop.org
> > > Cc: Mcgee, Jeff <jeff.mcgee@intel.com>; Vivi, Rodrigo <rodrigo.vi
> > > vi@intel.com>
> > > Subject: Re: [PATCH 1/2] drm/i915/GuC/GLK: Load GuC on GLK
> > >
> > >
> > > > @@ -73,6 +76,8 @@ MODULE_FIRMWARE(I915_BXT_GUC_UCODE);
> > > > #define I915_KBL_GUC_UCODE GUC_FW_PATH(kbl, KBL_FW_MAJOR,
> > > > KBL_FW_MINOR)
> > > > MODULE_FIRMWARE(I915_KBL_GUC_UCODE);
> > > >
> > > > +#define I915_GLK_GUC_UCODE GUC_FW_PATH(glk, GLK_FW_MAJOR,
> > > > GLK_FW_MINOR)
> > > You need a line after this #define that says the following:
> > > MODULE_FIRMWARE(I915_GLK_GUC_UCODE);
> >
> >
> > Hi John, we have decided to not use it in pre-production platforms.
> > Using MODULE_FIRMWARE is going to shout that the firmware is not
> > available in systems. Since we will not be releasing the firmware
> > binary to the public yet, it is unnecessary noise.
> +MODULE_FIRMARE() should be in a separated patch and only get merged
> after the firmware got released at 01.org propagated and merged to
> linux-firmware.git.
>
Makes sense. My mistake.
John
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-29 0:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1490130577-3679-1-git-send-email-anusha.srivatsa@intel.com>
2017-03-28 21:35 ` [PATCH 1/2] drm/i915/GuC/GLK: Load GuC on GLK John Spotswood
2017-03-28 22:11 ` Srivatsa, Anusha
2017-03-29 0:01 ` Vivi, Rodrigo
2017-03-29 0:32 ` John Spotswood [this message]
2017-03-30 13:52 ` Joonas Lahtinen
2017-03-30 20:24 Anusha Srivatsa
2017-03-30 23:31 ` John Spotswood
-- strict thread matches above, loose matches on Subject: below --
2017-03-21 21:10 Anusha Srivatsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490747569.21875.1.camel@intel.com \
--to=john.a.spotswood@intel.com \
--cc=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).