intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Do request retirement before marking engines as wedged
Date: Thu, 30 Mar 2017 15:17:26 +0300	[thread overview]
Message-ID: <1490876246.3067.6.camel@linux.intel.com> (raw)
In-Reply-To: <20170330082848.23702-1-chris@chris-wilson.co.uk>

On to, 2017-03-30 at 09:28 +0100, Chris Wilson wrote:
> As we declare an engine as wedged, we mark all of its active requests as
> in error. However, we don't want to mark successfully completed requests
> as in error, which requires us to retire those requests first.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

I still shiver when I see the stop_machine's around.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2017-03-30 12:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30  8:28 [PATCH] drm/i915: Do request retirement before marking engines as wedged Chris Wilson
2017-03-30 10:23 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-03-30 12:17 ` Joonas Lahtinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490876246.3067.6.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).