From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH v2] drm/i915/selftests: Silence compiler warning in igt_ctx_exec
Date: Wed, 24 May 2017 18:24:06 +0300 [thread overview]
Message-ID: <1495639446.3391.0.camel@linux.intel.com> (raw)
In-Reply-To: <20170523194412.1195-1-chris@chris-wilson.co.uk>
On ti, 2017-05-23 at 20:44 +0100, Chris Wilson wrote:
> The compiler doesn't always spot the guard that object is allocated on
> the first pass, leading to:
>
> drivers/gpu/drm/i915/selftests/i915_gem_context.c: warning: 'obj' may be used uninitialized in this function [-Wuninitialized]: => 370:8
>
> v2: Make it more obvious by setting obj to NULL on the first pass and
> any later pass where we need to reallocate.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: 791ff39ae32a ("drm/i915: Live testing for context execution")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> c: <drm-intel-fixes@lists.freedesktop.org> # v4.12-rc1+
Still not Cc?
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-24 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 19:44 [PATCH v2] drm/i915/selftests: Silence compiler warning in igt_ctx_exec Chris Wilson
2017-05-23 20:01 ` ✓ Fi.CI.BAT: success for drm/i915/selftests: Silence compiler warning in igt_ctx_exec (rev2) Patchwork
2017-05-24 5:33 ` Saarinen, Jani
2017-05-24 9:29 ` [PATCH v2] drm/i915/selftests: Silence compiler warning in igt_ctx_exec Tvrtko Ursulin
2017-05-24 11:05 ` Chris Wilson
2017-05-24 9:42 ` ✓ Fi.CI.BAT: success for drm/i915/selftests: Silence compiler warning in igt_ctx_exec (rev2) Patchwork
2017-05-24 15:24 ` Joonas Lahtinen [this message]
2017-05-24 15:37 ` [PATCH v2] drm/i915/selftests: Silence compiler warning in igt_ctx_exec Chris Wilson
2017-05-24 15:49 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495639446.3391.0.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).