From: Gerd Hoffmann <kraxel@redhat.com>
To: Xiaoguang Chen <xiaoguang.chen@intel.com>,
alex.williamson@redhat.com, chris@chris-wilson.co.uk,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
zhenyuw@linux.intel.com, zhiyuan.lv@intel.com,
intel-gvt-dev@lists.freedesktop.org, zhi.a.wang@intel.com,
kevin.tian@intel.com
Subject: Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations
Date: Mon, 29 May 2017 09:20:20 +0200 [thread overview]
Message-ID: <1496042420.21582.3.camel@redhat.com> (raw)
In-Reply-To: <1495874332-2851-5-git-send-email-xiaoguang.chen@intel.com>
> +struct vfio_vgpu_dmabuf_info {
> + __u32 argsz;
> + __u32 flags;
> + struct vfio_vgpu_plane_info plane_info;
> + __s32 fd;
> + __u32 pad;
> +};
Hmm, now you have argsz and flags twice in vfio_vgpu_dmabuf_info ...
I think we should have something like this:
struct vfio_vgpu_plane_info {
__u64 start;
__u64 drm_format_mod;
__u32 drm_format;
__u32 width;
__u32 height;
__u32 stride;
__u32 size;
__u32 x_pos;
__u32 y_pos;
__u32 padding;
};
struct vfio_vgpu_query_plane {
__u32 argsz;
__u32 flags;
struct vfio_vgpu_plane_info plane_info;
__u32 plane_id;
__u32 padding;
};
struct vfio_vgpu_create_dmabuf {
__u32 argsz;
__u32 flags;
struct vfio_vgpu_plane_info plane_info;
__u32 plane_id;
__s32 fd;
};
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-29 7:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 8:38 [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g Xiaoguang Chen
2017-05-27 8:38 ` [PATCH v6 1/6] drm/i915/gvt: Extend the GVT-g architecture to support vfio device region Xiaoguang Chen
2017-05-27 8:38 ` [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g Xiaoguang Chen
2017-05-31 4:47 ` Zhenyu Wang
2017-05-31 6:22 ` Chen, Xiaoguang
2017-05-31 6:30 ` Zhenyu Wang
2017-05-31 6:44 ` Chen, Xiaoguang
2017-05-27 8:38 ` [PATCH v6 3/6] drm/i915/gvt: Frame buffer decoder " Xiaoguang Chen
2017-05-31 5:12 ` Zhenyu Wang
2017-05-31 6:46 ` Chen, Xiaoguang
2017-05-27 8:38 ` [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Xiaoguang Chen
2017-05-29 7:20 ` Gerd Hoffmann [this message]
2017-05-31 6:18 ` Chen, Xiaoguang
2017-05-31 17:22 ` Kirti Wankhede
2017-06-01 3:01 ` Chen, Xiaoguang
2017-06-01 16:38 ` Alex Williamson
2017-06-01 18:46 ` Kirti Wankhede
2017-06-02 8:38 ` Gerd Hoffmann
2017-06-05 8:26 ` Kirti Wankhede
2017-06-06 7:59 ` Gerd Hoffmann
2017-05-27 8:38 ` [PATCH v6 5/6] drm/i915/gvt: Dmabuf support for GVT-g Xiaoguang Chen
2017-05-31 12:04 ` Gerd Hoffmann
2017-06-01 3:02 ` Chen, Xiaoguang
2017-06-01 9:15 ` Chris Wilson
2017-05-27 8:38 ` [PATCH v6 6/6] drm/i915/gvt: Adding interface so user space can get the dma-buf Xiaoguang Chen
2017-06-01 18:08 ` Alex Williamson
2017-06-02 3:24 ` Chen, Xiaoguang
2017-06-02 3:34 ` Alex Williamson
2017-06-02 9:31 ` Chen, Xiaoguang
2017-06-02 14:58 ` Alex Williamson
2017-06-02 15:23 ` Gerd Hoffmann
2017-06-05 2:39 ` Chen, Xiaoguang
2017-06-06 7:35 ` Gerd Hoffmann
2017-05-27 8:44 ` ✗ Fi.CI.BAT: failure for drm/i915/gvt: dma-buf support for GVT-g (rev6) Patchwork
2017-05-30 10:23 ` [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g Gerd Hoffmann
2017-05-31 2:29 ` Chen, Xiaoguang
2017-05-31 8:59 ` Gerd Hoffmann
2017-05-31 9:07 ` Chen, Xiaoguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496042420.21582.3.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoguang.chen@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).