[PATCH i-g-t] tests/chamelium: Set output pipe after mode change to refresh output

[PATCH i-g-t] tests/chamelium: Set output pipe after mode change to refresh output

[Paul Kocialkowski]

This adds a call to igt_output_set_pipe in orde to refresh output via
igt_output_refresh and ensure that mode override can take effect.

Without this change, using a lower resolution during frame dumps
series with mode changes (e.g. test_display_frame_dump) would not
commit the mode change to the output and leave it with a framebuffer
too small for the previously-commited resolution.

This would cause the test to fail. This allows it to pass.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
---
 tests/chamelium.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/chamelium.c b/tests/chamelium.c
index 2e14ccb9..76b14e95 100644
--- a/tests/chamelium.c
+++ b/tests/chamelium.c
@@ -322,6 +322,8 @@ enable_output(data_t *data,
 	igt_plane_set_fb(primary, fb);
 	igt_output_override_mode(output, mode);
 
+	igt_output_set_pipe(output, output->config.pipe);
+
 	/* Clear any color correction values that might be enabled */
 	igt_pipe_set_degamma_lut(primary->pipe, NULL, 0);
 	igt_pipe_set_gamma_lut(primary->pipe, NULL, 0);
-- 
2.13.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] tests/chamelium: Set output pipe after mode change to refresh output

[Lyude Paul]

On Wed, 2017-06-14 at 14:47 +0300, Paul Kocialkowski wrote:
> This adds a call to igt_output_set_pipe in orde to refresh output via
> igt_output_refresh and ensure that mode override can take effect.
> 
> Without this change, using a lower resolution during frame dumps
> series with mode changes (e.g. test_display_frame_dump) would not
> commit the mode change to the output and leave it with a framebuffer
> too small for the previously-commited resolution.
> 
> This would cause the test to fail. This allows it to pass.
> 
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>

Thanks for the important fix! This must have gotten broken with some
igt rework someone did down the line while I was gone. Will push in a
moment :).

> ---
>  tests/chamelium.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/chamelium.c b/tests/chamelium.c
> index 2e14ccb9..76b14e95 100644
> --- a/tests/chamelium.c
> +++ b/tests/chamelium.c
> @@ -322,6 +322,8 @@ enable_output(data_t *data,
>  	igt_plane_set_fb(primary, fb);
>  	igt_output_override_mode(output, mode);
>  
> +	igt_output_set_pipe(output, output->config.pipe);
> +
>  	/* Clear any color correction values that might be enabled
> */
>  	igt_pipe_set_degamma_lut(primary->pipe, NULL, 0);
>  	igt_pipe_set_gamma_lut(primary->pipe, NULL, 0);
-- 
Cheers,
	Lyude
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] tests/chamelium: Set output pipe after mode change to refresh output

[Paul Kocialkowski]

On Wed, 2017-06-14 at 18:16 -0400, Lyude Paul wrote:
> On Wed, 2017-06-14 at 14:47 +0300, Paul Kocialkowski wrote:
> > This adds a call to igt_output_set_pipe in orde to refresh output via
> > igt_output_refresh and ensure that mode override can take effect.
> > 
> > Without this change, using a lower resolution during frame dumps
> > series with mode changes (e.g. test_display_frame_dump) would not
> > commit the mode change to the output and leave it with a framebuffer
> > too small for the previously-commited resolution.
> > 
> > This would cause the test to fail. This allows it to pass.
> > 
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> 
> Reviewed-by: Lyude Paul <lyude@redhat.com>
> 
> Thanks for the important fix! This must have gotten broken with some
> igt rework someone did down the line while I was gone. Will push in a
> moment :).

Thanks for the review!

> > ---
> >  tests/chamelium.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/tests/chamelium.c b/tests/chamelium.c
> > index 2e14ccb9..76b14e95 100644
> > --- a/tests/chamelium.c
> > +++ b/tests/chamelium.c
> > @@ -322,6 +322,8 @@ enable_output(data_t *data,
> >  	igt_plane_set_fb(primary, fb);
> >  	igt_output_override_mode(output, mode);
> >  
> > +	igt_output_set_pipe(output, output->config.pipe);
> > +
> >  	/* Clear any color correction values that might be enabled
> > */
> >  	igt_pipe_set_degamma_lut(primary->pipe, NULL, 0);
> >  	igt_pipe_set_gamma_lut(primary->pipe, NULL, 0);
-- 
Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx