From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v9 5/7] vfio: Define vfio based dma-buf operations
Date: Wed, 21 Jun 2017 09:22:38 +0200
Message-ID: <1498029758.5802.1.camel@redhat.com>
References: <1497513611-2814-1-git-send-email-xiaoguang.chen@intel.com>
         <1497513611-2814-6-git-send-email-xiaoguang.chen@intel.com>
         <f19da207-a7f5-d3d3-4577-b071e7d75cf7@nvidia.com>
         <1497542438.29252.1.camel@redhat.com> <20170615143833.7526351b@w520.home>
         <24c4880b-24f5-ea07-834c-c77d3e895c78@nvidia.com>
         <20170616103959.3b6f1681@t450s.home> <1497854053.4207.2.camel@redhat.com>
         <20170619085409.26f5c14c@w520.home> <1497947703.16795.4.camel@redhat.com>
         <791b0316-1c83-622c-9cef-d54dae1209f9@nvidia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <791b0316-1c83-622c-9cef-d54dae1209f9@nvidia.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Kirti Wankhede <kwankhede@nvidia.com>, Alex Williamson <alex.williamson@redhat.com>
Cc: Xiaoguang Chen <xiaoguang.chen@intel.com>, chris@chris-wilson.co.uk, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, intel-gvt-dev@lists.freedesktop.org, zhi.a.wang@intel.com, kevin.tian@intel.com
List-Id: intel-gfx@lists.freedesktop.org

  Hi,

> We don't support cursor for console vnc. Ideally console vnc should
> be
> used by admin for configuration or during maintenance, which refresh
> primary surface at low refresh rate, 10 fps.

But you surely want a mouse pointer for the admin?
You render it directly to the primary surface then I guess?

> Right we need to know this at device initialization time for both
> cases
> to initialize VGACommonState structure for that device

Why do you need a VGACommonState?

> and also need
> NONE to decide whether to init console vnc or not. We have a
> mechanism
> to disable console vnc path and we recommend to disable it for better
> performance.

Hmm, maybe we should have a ioctl to configure the refresh rate, or a
ioctl to allow qemu ask for a refresh when needed?

qemu can throttle the display update rate, which for example happens in
case no vnc client is connected.  qemu updates the display only once
every few seconds then.

cheers,
  Gerd