From: Lyude Paul <lyude@redhat.com>
To: Martin Peres <martin.peres@linux.intel.com>,
Paul Kocialkowski <paul.kocialkowski@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 4/7] lib/igt_chamelium: Add support for configurable DUT suspend/resume delay
Date: Mon, 26 Jun 2017 17:14:07 -0400 [thread overview]
Message-ID: <1498511647.4147.7.camel@redhat.com> (raw)
In-Reply-To: <ae566a83-c664-9f22-5f6f-e97c24cd5c28@linux.intel.com>
> >
> > Fair enough, but at this point, only lib/igt_chamelium.c is using
> > igtrc and all
> > the parsing is implemented there.
> >
> > So one course of action here would be to move igtrc parsing outside
> > of
> > igt_chamelium (maybe to igt_core?) and use some global variable for
> > storing this
> > value. What do you think?
> >
>
> That seems like a plan, except you can just call a function that will
> do
> the parsing for you and return a structure with all the parameters.
> If
> it is called a second time, just return the cached value.
>
> What do you think, Lyude?
Yep, the reason it's called .igtrc is mainly because we were eventually
expecting someone else to start using it, and suspend/resume delay is
definitely something that will be useful for the rest of the tests
(I've got quite a few machines myself that i had to increase the delay
on just because the firmware was too slow when suspending/resuming). So
I'm all for it.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-06-26 21:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 13:59 [PATCH i-g-t 1/7] tests/chamelium: Update connector state without reprobe when possible Paul Kocialkowski
2017-06-26 13:59 ` [PATCH i-g-t 2/7] tests/chamelium: Check all connectors state for basic hotplug Paul Kocialkowski
2017-06-26 21:35 ` Lyude Paul
2017-06-26 13:59 ` [PATCH i-g-t 3/7] tests/chamelium: Use 50 ms delay to wait for connector change Paul Kocialkowski
2017-06-26 21:36 ` Lyude Paul
2017-06-26 13:59 ` [PATCH i-g-t 4/7] lib/igt_chamelium: Add support for configurable DUT suspend/resume delay Paul Kocialkowski
2017-06-26 14:25 ` Martin Peres
2017-06-26 14:33 ` Paul Kocialkowski
2017-06-26 15:15 ` Martin Peres
2017-06-26 21:14 ` Lyude Paul [this message]
2017-06-27 7:33 ` Paul Kocialkowski
2017-06-27 7:45 ` Paul Kocialkowski
2017-06-27 10:16 ` Paul Kocialkowski
2017-06-26 13:59 ` [PATCH i-g-t 5/7] tests/chamelium: Use " Paul Kocialkowski
2017-06-26 13:59 ` [PATCH i-g-t 6/7] tests/chamelium: Reduce the simple hotplug test toggle count for VGA Paul Kocialkowski
2017-06-26 13:59 ` [PATCH i-g-t 7/7] tests/chamelium: Disconnect connectors without extra reset Paul Kocialkowski
2017-06-26 22:17 ` Lyude Paul
2017-06-27 7:22 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498511647.4147.7.camel@redhat.com \
--to=lyude@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=martin.peres@linux.intel.com \
--cc=paul.kocialkowski@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).