From: Lyude Paul <lyude@redhat.com>
To: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 3/7] tests/chamelium: Use 50 ms delay to wait for connector change
Date: Mon, 26 Jun 2017 17:36:57 -0400 [thread overview]
Message-ID: <1498513017.4147.9.camel@redhat.com> (raw)
In-Reply-To: <20170626135906.32708-3-paul.kocialkowski@linux.intel.com>
rb'd and pushed, thanks!
On Mon, 2017-06-26 at 16:59 +0300, Paul Kocialkowski wrote:
> Using a 1 s delay seems too large for detecting a connector change,
> that
> may happen faster than this. Since the constraints on execution time
> are
> high, it is preferable to use a much smaller sleep time.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
> tests/chamelium.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/chamelium.c b/tests/chamelium.c
> index 5075a52f..15ed0f28 100644
> --- a/tests/chamelium.c
> +++ b/tests/chamelium.c
> @@ -135,7 +135,7 @@ wait_for_connector(data_t *data, struct
> chamelium_port *port,
> return;
> }
>
> - sleep(1);
> + usleep(50000);
> }
>
> igt_assert(finished);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-06-26 21:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 13:59 [PATCH i-g-t 1/7] tests/chamelium: Update connector state without reprobe when possible Paul Kocialkowski
2017-06-26 13:59 ` [PATCH i-g-t 2/7] tests/chamelium: Check all connectors state for basic hotplug Paul Kocialkowski
2017-06-26 21:35 ` Lyude Paul
2017-06-26 13:59 ` [PATCH i-g-t 3/7] tests/chamelium: Use 50 ms delay to wait for connector change Paul Kocialkowski
2017-06-26 21:36 ` Lyude Paul [this message]
2017-06-26 13:59 ` [PATCH i-g-t 4/7] lib/igt_chamelium: Add support for configurable DUT suspend/resume delay Paul Kocialkowski
2017-06-26 14:25 ` Martin Peres
2017-06-26 14:33 ` Paul Kocialkowski
2017-06-26 15:15 ` Martin Peres
2017-06-26 21:14 ` Lyude Paul
2017-06-27 7:33 ` Paul Kocialkowski
2017-06-27 7:45 ` Paul Kocialkowski
2017-06-27 10:16 ` Paul Kocialkowski
2017-06-26 13:59 ` [PATCH i-g-t 5/7] tests/chamelium: Use " Paul Kocialkowski
2017-06-26 13:59 ` [PATCH i-g-t 6/7] tests/chamelium: Reduce the simple hotplug test toggle count for VGA Paul Kocialkowski
2017-06-26 13:59 ` [PATCH i-g-t 7/7] tests/chamelium: Disconnect connectors without extra reset Paul Kocialkowski
2017-06-26 22:17 ` Lyude Paul
2017-06-27 7:22 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498513017.4147.9.camel@redhat.com \
--to=lyude@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paul.kocialkowski@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).