From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/2] drm/i915: Only wake the waiter from the interrupt if passed Date: Tue, 19 Sep 2017 10:23:03 +0100 Message-ID: <14d0691c-1b15-8ed8-e068-9cec39574a61@linux.intel.com> References: <20170918162734.21294-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id E6F236E53E for ; Tue, 19 Sep 2017 09:23:05 +0000 (UTC) In-Reply-To: <20170918162734.21294-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzA5LzIwMTcgMTc6MjcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBBcyB3ZSBub3cgY2hl Y2sgaWYgdGhlIHNlcW5vIGlzIGNvbXBsZXRlIGluIG9yZGVyIHRvIHNpZ25hbCB0aGUgZmVuY2Us Cj4gd2UgY2FuIGFsc28gZGVjaWRlIG5vdCB0byB3YWtlIHVwIHRoZSBmaXJzdF93YWl0ZXIgdW50 aWwgaXQgaXMgcmVhZHkKPiAoc2luY2UgaXQgaXMgd2FpdGluZyBvbiB0aGUgc2FtZSBzZXFubyku IFRoZSBvbmx5IGNhdmVhdCBpcyB0aGF0IGlmIHdlCj4gbmVlZCB0aGUgZW5naW5lLT5pcnFfc2Vx bm9fYmFycmllciB0byBlbmZvcmNlIHNvbWUgY29oZXJlbmN5IGJldHdlZW4gYW4KPiBpbnRlcnJ1 cHQgYW5kIHRoZSBzZXFubyByZWFkLCB3ZSBoYXZlIHRvIGFsd2F5cyB3YWtlIHRoZSB3YWl0ZXIg aW4gb3JkZXIKPiB0byBwZXJmb3JtIHRoYXQgaGVhdnl3ZWlnaHQgYmFycmllci4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzog VHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgfCAxNSArKysrKysrKysrLS0tLS0KPiAgIDEgZmls ZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9pcnEuYwo+IGluZGV4IDRkMGU4Zjc2ZWQxYS4uYmI2OWM1YjBlZmM0IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gQEAgLTEwMzgsNiArMTAzOCw4IEBAIHN0YXRpYyB2b2lk IG5vdGlmeV9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAlzcGluX2xv Y2soJmVuZ2luZS0+YnJlYWRjcnVtYnMuaXJxX2xvY2spOwo+ICAgCXdhaXQgPSBlbmdpbmUtPmJy ZWFkY3J1bWJzLmlycV93YWl0Owo+ICAgCWlmICh3YWl0KSB7Cj4gKwkJYm9vbCB3YWtldXAgPSBl bmdpbmUtPmlycV9zZXFub19iYXJyaWVyOwo+ICsKPiAgIAkJLyogV2UgdXNlIGEgY2FsbGJhY2sg ZnJvbSB0aGUgZG1hLWZlbmNlIHRvIHN1Ym1pdAo+ICAgCQkgKiByZXF1ZXN0cyBhZnRlciB3YWl0 aW5nIG9uIG91ciBvd24gcmVxdWVzdHMuIFRvCj4gICAJCSAqIGVuc3VyZSBtaW5pbXVtIGRlbGF5 IGluIHF1ZXVpbmcgdGhlIG5leHQgcmVxdWVzdCB0bwo+IEBAIC0xMDUwLDEyICsxMDUyLDE1IEBA IHN0YXRpYyB2b2lkIG5vdGlmeV9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkK PiAgIAkJICogYW5kIG1hbnkgd2FpdGVycy4KPiAgIAkJICovCj4gICAJCWlmIChpOTE1X3NlcW5v X3Bhc3NlZChpbnRlbF9lbmdpbmVfZ2V0X3NlcW5vKGVuZ2luZSksCj4gLQkJCQkgICAgICB3YWl0 LT5zZXFubykgJiYKPiAtCQkgICAgIXRlc3RfYml0KERNQV9GRU5DRV9GTEFHX1NJR05BTEVEX0JJ VCwKPiAtCQkJICAgICAgJndhaXQtPnJlcXVlc3QtPmZlbmNlLmZsYWdzKSkKPiAtCQkJcnEgPSBp OTE1X2dlbV9yZXF1ZXN0X2dldCh3YWl0LT5yZXF1ZXN0KTsKPiArCQkJCSAgICAgIHdhaXQtPnNl cW5vKSkgewo+ICsJCQl3YWtldXAgPSB0cnVlOwo+ICsJCQlpZiAoIXRlc3RfYml0KERNQV9GRU5D RV9GTEFHX1NJR05BTEVEX0JJVCwKPiArCQkJCSAgICAgICZ3YWl0LT5yZXF1ZXN0LT5mZW5jZS5m bGFncykpCj4gKwkJCQlycSA9IGk5MTVfZ2VtX3JlcXVlc3RfZ2V0KHdhaXQtPnJlcXVlc3QpOwo+ ICsJCX0KPiAgIAo+IC0JCXdha2VfdXBfcHJvY2Vzcyh3YWl0LT50c2spOwo+ICsJCWlmICh3YWtl dXApCj4gKwkJCXdha2VfdXBfcHJvY2Vzcyh3YWl0LT50c2spOwo+ICAgCX0gZWxzZSB7Cj4gICAJ CV9faW50ZWxfZW5naW5lX2Rpc2FybV9icmVhZGNydW1icyhlbmdpbmUpOwo+ICAgCX0KPiAKCkxv b2tzIHN0cmFpZ2h0Zm9yd2FyZCBlbm91Z2guCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4g PHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==