intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Kirti Wankhede <kwankhede@nvidia.com>,
	Alex Williamson <alex.williamson@redhat.com>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	zhiyuan.lv@intel.com, Xiaoguang Chen <xiaoguang.chen@intel.com>,
	intel-gvt-dev@lists.freedesktop.org
Subject: Re: [PATCH v9 5/7] vfio: Define vfio based dma-buf operations
Date: Fri, 14 Jul 2017 11:58:40 +0200	[thread overview]
Message-ID: <1500026320.28252.5.camel@redhat.com> (raw)
In-Reply-To: <42b821d9-9467-1679-3351-4a234243f520@nvidia.com>

  Hi,

> > > Right we need to know this at device initialization time for both
> > > cases
> > > to initialize VGACommonState structure for that device
> > 
> > Why do you need a VGACommonState?
> > 
> 
> We need to create a GRAPHIC_CONSOLE for vGPU device and specify
> GraphicHwOps so that from its .gfx_update callback, surface can be
> queried and updated.

Yes, you need GraphicHwOps, but there is no need to have a
VGACommonState for that.

> > > and also need
> > > NONE to decide whether to init console vnc or not. We have a
> > > mechanism
> > > to disable console vnc path and we recommend to disable it for
> > > better
> > > performance.
> > 
> > Hmm, maybe we should have a ioctl to configure the refresh rate, or
> > a
> > ioctl to allow qemu ask for a refresh when needed?
> > 
> 
> What is default refresh rate of QEMU if vnc is connected?

/* in ms */
#define GUI_REFRESH_INTERVAL_DEFAULT    30
#define GUI_REFRESH_INTERVAL_IDLE     3000

cheers,
  Gerd

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-07-14  9:58 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15  8:00 [PATCH v9 0/7] drm/i915/gvt: Dma-buf support for GVT-g Xiaoguang Chen
2017-06-15  8:00 ` [PATCH v9 1/7] drm/i915/gvt: Extend the GVT-g architecture Xiaoguang Chen
2017-06-15  8:00 ` [PATCH v9 2/7] drm/i915/gvt: OpRegion support for GVT-g Xiaoguang Chen
2017-06-15  8:00 ` [PATCH v9 3/7] drm: Extend the drm format Xiaoguang Chen
2017-06-15 10:21   ` Ville Syrjälä
2017-06-20  9:01     ` [Intel-gfx] " Zhang, Tina
2017-06-15  8:00 ` [PATCH v9 4/7] drm/i915/gvt: Frame buffer decoder support for GVT-g Xiaoguang Chen
2017-06-15  8:00 ` [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Xiaoguang Chen
2017-06-15 14:51   ` Kirti Wankhede
2017-06-15 16:00     ` Gerd Hoffmann
2017-06-15 20:38       ` Alex Williamson
2017-06-16 10:24         ` Gerd Hoffmann
2017-06-16 12:52           ` Alex Williamson
2017-06-16 13:32         ` Kirti Wankhede
2017-06-16 16:39           ` Alex Williamson
2017-06-16 18:28             ` Kirti Wankhede
2017-06-19  6:34             ` Gerd Hoffmann
2017-06-19 14:54               ` Alex Williamson
2017-06-20  8:35                 ` Gerd Hoffmann
2017-06-20 13:55                   ` Kirti Wankhede
2017-06-21  7:22                     ` Gerd Hoffmann
2017-07-12 13:18                       ` Kirti Wankhede
2017-07-14  9:58                         ` Gerd Hoffmann [this message]
2017-06-19  6:38           ` Gerd Hoffmann
2017-06-19 14:55             ` Alex Williamson
2017-06-20  8:41               ` Zhang, Tina
2017-06-20 10:57                 ` Gerd Hoffmann
2017-06-20 15:00                   ` [Intel-gfx] " Alex Williamson
2017-06-20 17:07                     ` Kirti Wankhede
2017-06-20 23:01                     ` Zhang, Tina
2017-06-20 23:22                       ` Alex Williamson
2017-06-21  9:20                         ` Zhang, Tina
2017-06-21 11:03                           ` [Intel-gfx] " Gerd Hoffmann
2017-06-21 18:59                             ` Alex Williamson
2017-06-22  8:30                               ` Gerd Hoffmann
2017-06-22 18:54                                 ` Alex Williamson
2017-06-23  7:26                                   ` Gerd Hoffmann
2017-06-23  7:49                                     ` [Intel-gfx] " Zhi Wang
2017-06-23  8:31                                       ` Gerd Hoffmann
2017-06-23 16:40                                         ` Alex Williamson
2017-06-23 17:15                                     ` Alex Williamson
2017-06-26  6:17                                       ` Gerd Hoffmann
2017-06-22  0:21                             ` Zhang, Tina
2017-06-21  7:34                     ` Gerd Hoffmann
2017-06-23 21:58                   ` Zhang, Tina
2017-06-26  6:39                     ` Gerd Hoffmann
2017-06-26 17:28                       ` Alex Williamson
2017-06-27  6:12                         ` Gerd Hoffmann
2017-06-28 12:48                           ` Zhang, Tina
2017-06-29  6:41                             ` Gerd Hoffmann
2017-06-29  8:39                               ` Daniel Vetter
2017-07-04  0:47                                 ` Zhang, Tina
2017-06-20 13:35               ` Kirti Wankhede
2017-06-15  8:00 ` [PATCH v9 6/7] drm/i915/gvt: Dmabuf support for GVT-g Xiaoguang Chen
2017-06-15  8:00 ` [PATCH v9 7/7] drm/i915/gvt: Adding user interface for dma-buf Xiaoguang Chen
2017-06-15  8:03 ` ✗ Fi.CI.BAT: failure for drm/i915/gvt: dma-buf support for GVT-g (rev9) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500026320.28252.5.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=kwankhede@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiaoguang.chen@intel.com \
    --cc=zhiyuan.lv@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).