From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/i915: Remove assertion from raw __i915_vma_unpin()
Date: Mon, 24 Jul 2017 11:55:00 +0300 [thread overview]
Message-ID: <1500886500.4382.0.camel@linux.intel.com> (raw)
In-Reply-To: <20170721145037.25105-2-chris@chris-wilson.co.uk>
On pe, 2017-07-21 at 15:50 +0100, Chris Wilson wrote:
> After we detect a i915_vma pin overflow, we call __i915_vma_unpin to
> cleanup. However, on an overflow the pin_count bitfield will be zero,
> triggering an assertion, even though we the intention is to merely warn
> and report the error back to the user (as historically the culprit has
> be a leak in the display code).
>
> Fixes: 20dfbde463c8 ("drm/i915: Wrap vma->pin_count accessors with small inline helpers")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-07-24 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 14:50 A bunch of execbuf regression fixes Chris Wilson
2017-07-21 14:50 ` [PATCH 1/4] drm/i915: Remove assertion from raw __i915_vma_unpin() Chris Wilson
2017-07-24 8:55 ` Joonas Lahtinen [this message]
2017-07-21 14:50 ` [PATCH 2/4] drm/i915: Only mark the execobject as pinned on success Chris Wilson
2017-07-24 8:57 ` Joonas Lahtinen
2017-07-21 14:50 ` [PATCH 3/4] drm/i915: Only skip updating execobject.offset after error Chris Wilson
2017-07-26 9:08 ` Joonas Lahtinen
2017-07-21 14:50 ` [PATCH 4/4] drm/i915: Force CPU synchronisation even if userspace requests ASYNC Chris Wilson
2017-07-26 10:19 ` Joonas Lahtinen
2017-07-26 10:45 ` Chris Wilson
2017-07-21 16:24 ` ✗ Fi.CI.BAT: warning for series starting with [1/4] drm/i915: Remove assertion from raw __i915_vma_unpin() Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500886500.4382.0.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).