From: Lyude Paul <lyude@redhat.com>
To: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/3] configure.ac: Make udev a dependency for chamelium
Date: Tue, 25 Jul 2017 13:06:05 -0400 [thread overview]
Message-ID: <1501002365.5682.2.camel@redhat.com> (raw)
In-Reply-To: <20170725124825.1936-1-paul.kocialkowski@linux.intel.com>
R-b'd and pushed, thanks!
On Tue, 2017-07-25 at 15:48 +0300, Paul Kocialkowski wrote:
> Chamelium testing has a hard dependency on udev. This makes this
> dependency explicit in configure instead of failing the build when it
> is missing.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
> configure.ac | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index dec3e923..a6ab9e4a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -194,6 +194,9 @@ if test "x$enable_chamelium" = xyes; then
> [AC_MSG_ERROR([Failed to find xmlrpc,
> required by chamelium. Use --disable-chamelium to disable chamelium
> support.])])
> PKG_CHECK_MODULES(PIXMAN, pixman-1, [],
> [AC_MSG_ERROR([Failed to find pixman,
> required by chamelium. Use --disable-chamelium to disable chamelium
> support.])])
> + if test x"$udev" != xyes; then
> + AC_MSG_ERROR([Failed to find udev, required by
> chamelium. Use --disable-chamelium to disable chamelium support.])
> + fi
> if test x"$glib" != xyes; then
> AC_MSG_ERROR([Failed to find glib, required by
> chamelium. Use --disable-chamelium to disable chamelium support.])
> fi
--
Cheers,
Lyude
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-07-25 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 12:48 [PATCH i-g-t 1/3] configure.ac: Make udev a dependency for chamelium Paul Kocialkowski
2017-07-25 12:48 ` [PATCH i-g-t 2/3] configure.ac: Disable chamelium by default and add enable argument Paul Kocialkowski
2017-07-25 17:07 ` Lyude Paul
2017-07-26 8:08 ` Paul Kocialkowski
2017-07-25 12:48 ` [PATCH i-g-t 3/3] README: Add information about chamelium dependencies Paul Kocialkowski
2017-07-25 17:06 ` Lyude Paul
2017-07-25 17:06 ` Lyude Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501002365.5682.2.camel@redhat.com \
--to=lyude@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paul.kocialkowski@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).