From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>,
James Ausmus <james.ausmus@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] lib/igt_debugfs: Remove support for legacy CRC api.
Date: Fri, 27 Oct 2017 10:05:39 +0200 [thread overview]
Message-ID: <15016736-9252-bc6b-817e-2ce69d6c4bb0@linux.intel.com> (raw)
In-Reply-To: <87o9otf3aa.fsf@intel.com>
Op 27-10-17 om 09:39 schreef Jani Nikula:
> On Thu, 26 Oct 2017, James Ausmus <james.ausmus@intel.com> wrote:
>> On Thu, Oct 26, 2017 at 01:38:51PM +0200, Maarten Lankhorst wrote:
>>> In kernel v4.10 the legacy crc api has been replaced by a generic
>>> drm crc API. While at it, fix igt_require_pipe_crc, the file cannot be
>>> opened any more when the crtc is not active after kernel commit 8038e09be5a3
>>> ("drm/crc: Only open CRC on atomic drivers when the CRTC is active.").
>>> Statting the file should be enough for testing it's supported.
>> What's the impact of this change on devices running older kernels - such
>> as KBL ChromeOS on 4.4?
> If you backport kernel features, you either also backport the new kernel
> CRC API, or forward port the igt support for the legacy debugfs if you
> want to use latest upstream igt?
It's part of the DRM api. Either you're using the old v4.4 kernel in which
case a lot of tests in IGT would have already failed, or when you backport
you backport the drm module too. Too much has changed between v4.4 and
drm-tip, there's no way you can just grab a current snapshot of the driver
and expect it to work in v4.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-27 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 11:38 [PATCH i-g-t] lib/igt_debugfs: Remove support for legacy CRC api Maarten Lankhorst
2017-10-26 12:52 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-10-26 14:56 ` ✓ Fi.CI.IGT: success " Patchwork
2017-10-26 17:23 ` [PATCH i-g-t] " James Ausmus
2017-10-27 7:39 ` Jani Nikula
2017-10-27 8:05 ` Maarten Lankhorst [this message]
2017-10-27 12:25 ` Petri Latvala
2017-11-02 13:20 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15016736-9252-bc6b-817e-2ce69d6c4bb0@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=james.ausmus@intel.com \
--cc=jani.nikula@intel.com \
--cc=tomi.p.sarvela@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox