public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mika Kahola <mika.kahola@intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC
Date: Wed, 02 Aug 2017 16:18:14 +0300	[thread overview]
Message-ID: <1501679894.16922.28.camel@intel.com> (raw)
In-Reply-To: <20170802124254.dkdzswr6ncw4r2um@platvala-desk.ger.corp.intel.com>

On Wed, 2017-08-02 at 15:42 +0300, Petri Latvala wrote:
> After a bit of digging into this n_words conundrum that I also could
> not understand, I found the issue Mika described.
> 
> kms_plane_multiple et al basically do
> 
> igt_crc_t crc;
> 
> 
> and then they pass &crc to test-internal helper functions, which pass
> the igt_crc_t* pointer to various igt lib functions. The problem is,
> those lib functions take igt_crc_t** so that they can give you the
> correct pointer, kms_plane* wrongly expect them to modify the passed
> object.
> 
> Mika, can you fix this while you're at it?
Right, we can do this without changing the original function call. I'll
throw a patch shortly.

Cheers,
Mika

> 
> 
> 
> --
> Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2017-08-02 13:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 12:45 [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC Mika Kahola
2017-07-31  8:13 ` Daniel Vetter
2017-07-31  9:04   ` Kahola, Mika
2017-08-02 11:36     ` Daniel Vetter
2017-08-02 11:38       ` Lofstedt, Marta
2017-08-02 12:06       ` Mika Kahola
2017-08-02 12:16         ` Daniel Vetter
2017-08-02 12:22           ` Mika Kahola
2017-08-02 12:42             ` Petri Latvala
2017-08-02 13:18               ` Mika Kahola [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501679894.16922.28.camel@intel.com \
    --to=mika.kahola@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox