public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
To: "Lofstedt, Marta" <marta.lofstedt@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s
Date: Fri, 04 Aug 2017 15:56:20 -0300	[thread overview]
Message-ID: <1501872980.2634.27.camel@intel.com> (raw)
In-Reply-To: <CA5F6A4B62957246A95956419746064382A344F6@IRSMSX106.ger.corp.intel.com>

Em Sex, 2017-08-04 às 09:47 +0000, Lofstedt, Marta escreveu:
> +Paolo
> 
> > -----Original Message-----
> > From: Lofstedt, Marta
> > Sent: Wednesday, June 28, 2017 2:17 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Latvala, Petri <petri.latvala@intel.com>; Lofstedt, Marta
> > <marta.lofstedt@intel.com>
> > Subject: [PATCH i-g-t] tests/kms_frontbuffer_tracking: increase FBC
> > wait
> > timeout to 5s
> > 
> > The subtests: igt@kms_frontbuffer_tracking@fbc-*draw*
> > has non-consistent results, pending between fail and pass.
> > The fails are always due to "FBC disabled".
> > With this increase in timeout the flip-flop behavior is no longer
> > reproducible.

This is a partial revert of:

64590c7b768dc8d8dd962f812d5ff5a39e7e8b54
    kms_frontbuffer_tracking: reduce the FBC wait timeout to 2s

(but there's no need to make it a full revert if you don't need)

It would be nice to investigate why we're needing 5 seconds instead of
2 now, the document it in the commit message. Also document that this
is a partial revert.

Acked-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101623
> > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> > ---
> >  tests/kms_frontbuffer_tracking.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_frontbuffer_tracking.c
> > b/tests/kms_frontbuffer_tracking.c
> > index c24e4a81..8bec5d5a 100644
> > --- a/tests/kms_frontbuffer_tracking.c
> > +++ b/tests/kms_frontbuffer_tracking.c
> > @@ -923,7 +923,7 @@ static bool fbc_stride_not_supported(void)
> > 
> >  static bool fbc_wait_until_enabled(void)  {
> > -	return igt_wait(fbc_is_enabled(), 2000, 1);
> > +	return igt_wait(fbc_is_enabled(), 5000, 1);
> >  }
> > 
> >  static bool psr_wait_until_enabled(void)
> > --
> > 2.11.0
> 
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-08-04 18:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 11:16 [PATCH i-g-t] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s Marta Lofstedt
2017-08-04  9:47 ` Lofstedt, Marta
2017-08-04 18:56   ` Paulo Zanoni [this message]
2017-08-07  6:51     ` Lofstedt, Marta
2017-08-07 14:54       ` Paulo Zanoni
2017-08-08 11:14         ` Lofstedt, Marta
2017-08-11 10:16           ` Lofstedt, Marta
2017-08-25 10:40 ` [PATCH i-g-t v2] " Marta Lofstedt
2017-08-25 10:46   ` Petri Latvala
2017-08-25 10:47   ` Chris Wilson
2017-08-25 11:54     ` Lofstedt, Marta
2017-08-25 12:50     ` Lofstedt, Marta
2017-08-25 13:11       ` Chris Wilson
2017-08-25 13:33         ` Lofstedt, Marta
2017-08-29  7:16           ` Lofstedt, Marta
2017-09-01 19:12         ` Paulo Zanoni
2017-09-04 10:45           ` Chris Wilson
2017-09-04 18:26             ` Paulo Zanoni
2017-08-25 12:24 ` ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s (rev2) Patchwork
2017-08-25 17:40 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501872980.2634.27.camel@intel.com \
    --to=paulo.r.zanoni@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=marta.lofstedt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox