public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Handle full s64 precision for wait-ioctl
Date: Fri, 11 Aug 2017 10:18:04 +0300	[thread overview]
Message-ID: <1502435884.3582.4.camel@linux.intel.com> (raw)
In-Reply-To: <150196245251.19198.17738666772629554772@mail.alporthouse.com>

On la, 2017-08-05 at 20:47 +0100, Chris Wilson wrote:
> Quoting Chris Wilson (2017-08-05 20:19:24)

<SNIP>

> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -4144,6 +4144,12 @@ static inline unsigned long msecs_to_jiffies_timeout(const unsigned int m)
> >  
> >  static inline unsigned long nsecs_to_jiffies_timeout(const u64 n)
> >  {
> > +#if NSEC_PER_SEC % HZ
> > +       /* nsecs_to_jiffies64() does not guard against overflow */
> > +       if (n >= (u64)MAX_JIFFY_OFFSET * NSEC_PER_SEC / HZ)
> > +               return MAX_JIFFY_OFFSET;
> 
> This still overflows, we need n / NSEC_PER_SEC >= MAX_JIFFY_OFFSET / HZ
> as MAX_JIFFY_OFFSET is ~LONG_MAX/2
> 
> Hmm, so div_u64(n, NSEC_PER_SEC) >= MAX_JIFFY_OFFSET / HZ ?

This reflects the original test best.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-08-11  7:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-05 19:19 [PATCH] drm/i915: Handle full s64 precision for wait-ioctl Chris Wilson
2017-08-05 19:47 ` Chris Wilson
2017-08-11  7:18   ` Joonas Lahtinen [this message]
2017-08-11  7:13 ` Joonas Lahtinen
2017-08-11 10:57 ` [PATCH v2] " Chris Wilson
2017-08-14 10:42   ` Joonas Lahtinen
2017-08-15 16:41     ` Chris Wilson
2017-08-11 11:27 ` ✓ Fi.CI.BAT: success for drm/i915: Handle full s64 precision for wait-ioctl (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502435884.3582.4.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox