public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
To: Lyude <lyude@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input
Date: Tue, 29 Aug 2017 15:08:23 +0300	[thread overview]
Message-ID: <1504008503.1448.6.camel@linux.intel.com> (raw)
In-Reply-To: <20170828145500.30655-1-paul.kocialkowski@linux.intel.com>

On Mon, 2017-08-28 at 17:55 +0300, Paul Kocialkowski wrote:
> Before capturing video, the Chamelium will always wait for the video
> input to be stable (and perform the FSM if it was not). This means
> that
> there is no need to explicitly do it beforehand.
> 
> When the receiver needs to be reset, the call will result in a
> timeout,
> after which the follow-up call to capture the video will perform the
> FSM
> that resets it. Skipping the explicit wait for video input stable
> allows
> the Chamelium to perform the FSM directly, which saves valuable time.
> 
> Removing the associated call does not negatively impact the execution
> of
> the CRC and frame comparison tests either.

I got an email from the mailer daemon indicating that this patch could
not be delivered to Lyude.

Lyude: did you receive the patch or should I resend it?

> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
>  tests/chamelium.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tests/chamelium.c b/tests/chamelium.c
> index 484bb537..e3d81357 100644
> --- a/tests/chamelium.c
> +++ b/tests/chamelium.c
> @@ -474,9 +474,6 @@ enable_output(data_t *data,
>  	if (chamelium_port_get_type(port) == DRM_MODE_CONNECTOR_VGA)
>  		usleep(250000);
>  
> -	chamelium_port_wait_video_input_stable(data->chamelium, port,
> -					       HOTPLUG_TIMEOUT);
> -
>  	drmModeFreeConnector(connector);
>  }
>  
-- 
Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-08-29 12:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28 14:55 [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input Paul Kocialkowski
2017-08-28 15:18 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-08-29 12:08 ` Paul Kocialkowski [this message]
2017-08-30 10:24   ` [PATCH i-g-t] " Paul Kocialkowski
2017-08-30 18:47     ` Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504008503.1448.6.camel@linux.intel.com \
    --to=paul.kocialkowski@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lyude@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox