Re: [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input

Lyude Paul
2017-08-30T18:47:19Z

On Wed, 2017-08-30 at 13:24 +0300, Paul Kocialkowski wrote:
> On Tue, 2017-08-29 at 15:08 +0300, Paul Kocialkowski wrote:
> > On Mon, 2017-08-28 at 17:55 +0300, Paul Kocialkowski wrote:
> > > Before capturing video, the Chamelium will always wait for the
> > > video
> > > input to be stable (and perform the FSM if it was not). This
> > > means
> > > that
> > > there is no need to explicitly do it beforehand.
> > >
> > > When the receiver needs to be reset, the call will result in a
> > > timeout,
> > > after which the follow-up call to capture the video will perform
> > > the
> > > FSM
> > > that resets it. Skipping the explicit wait for video input stable
> > > allows
> > > the Chamelium to perform the FSM directly, which saves valuable
> > > time.
> > >
> > > Removing the associated call does not negatively impact the
> > > execution
> > > of
> > > the CRC and frame comparison tests either.
> >
> > I got an email from the mailer daemon indicating that this patch
> > could
> > not be delivered to Lyude.
> >
> > Lyude: did you receive the patch or should I resend it?
>
> Either way, it's up at: https://patchwork.freedesktop.org/series/2943
> 2/
>
Yeah I didn't get it the first time but that's ok, weird though...

Anyway, R-B'd and pushed, thanks
> > > Signed-off-by: Paul Kocialkowski
> > > <paul.kocialkowski@linux.intel.com>
> > > ---
> > > tests/chamelium.c | 3 ---
> > > 1 file changed, 3 deletions(-)
> > >
> > > diff --git a/tests/chamelium.c b/tests/chamelium.c
> > > index 484bb537..e3d81357 100644
> > > --- a/tests/chamelium.c
> > > +++ b/tests/chamelium.c
> > > @@ -474,9 +474,6 @@ enable_output(data_t *data,
> > > if (chamelium_port_get_type(port) ==
> > > DRM_MODE_CONNECTOR_VGA)
> > > usleep(250000);
> > >
> > > - chamelium_port_wait_video_input_stable(data->chamelium,
> > > port,
> > > - HOTPLUG_TIMEOUT);
> > > -
> > > drmModeFreeConnector(connector);
> > > }
> > >
--
Cheers,
Lyude