public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Vidya Srinivas <vidya.srinivas@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Vidya Srinivas <vidya.srinivas@intel.com>
Subject: [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"
Date: Tue,  5 Sep 2017 15:14:31 +0530	[thread overview]
Message-ID: <1504604671-17237-1-git-send-email-vidya.srinivas@intel.com> (raw)
In-Reply-To: <E7C9878FBA1C6D42A1CA3F62AEB6945F7EFF80AB@BGSMSX104.gar.corp.intel.com>

From: Uma Shankar <uma.shankar@intel.com>

This reverts commit bbdf0b2ff32aa75c7bd167569130e9391d2e6282.

Disable device ready before shutdown command was added previously to avoid a
split screen issue seen on dual link DSI panels. As of now, dual link is not
supported and will need some rework in the upstream code. For single link DSI
panels, the change is not required. This will cause failure in sending SHUTDOWN
packet during disable. Hence reverting the change. Will handle the change
as part of dual link enabling in upstream.

Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 drivers/gpu/drm/i915/intel_dsi.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 2a0f5d3..fc25d7d 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -892,8 +892,6 @@ static void intel_dsi_disable(struct intel_encoder *encoder,
 			      const struct intel_crtc_state *old_crtc_state,
 			      const struct drm_connector_state *old_conn_state)
 {
-	struct drm_device *dev = encoder->base.dev;
-	struct drm_i915_private *dev_priv = dev->dev_private;
 	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
 	enum port port;
 
@@ -903,15 +901,6 @@ static void intel_dsi_disable(struct intel_encoder *encoder,
 	intel_panel_disable_backlight(old_conn_state);
 
 	/*
-	 * Disable Device ready before the port shutdown in order
-	 * to avoid split screen
-	 */
-	if (IS_BROXTON(dev_priv)) {
-		for_each_dsi_port(port, intel_dsi->ports)
-			I915_WRITE(MIPI_DEVICE_READY(port), 0);
-	}
-
-	/*
 	 * According to the spec we should send SHUTDOWN before
 	 * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing
 	 * has shown that the v3 sequence works for v2 VBTs too
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-09-05  9:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01  7:50 [PATCH 0/2] drm/i915/dsi: Fix error on DSI video mode command Mika Kahola
2017-09-01  7:51 ` [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's Mika Kahola
2017-09-01 13:43   ` Ville Syrjälä
2017-09-04  7:59     ` Mika Kahola
2017-09-04 15:04       ` Ville Syrjälä
2017-09-05  8:33         ` Mika Kahola
2017-09-05  9:27           ` Shankar, Uma
2017-09-05  9:44             ` Vidya Srinivas [this message]
2017-09-05 10:43               ` [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command" Mika Kahola
2017-09-13  8:05                 ` Jani Nikula
2017-09-12 10:02               ` Chauhan, Madhav
2017-09-13  8:09                 ` Jani Nikula
2017-09-13  8:13                   ` Chauhan, Madhav
2017-09-05 13:16             ` [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's Ville Syrjälä
2017-09-05 14:55               ` Shankar, Uma
2017-09-05 15:10                 ` Ville Syrjälä
2017-09-01  7:51 ` [PATCH 2/2] drm/i915/dsi: Replace MIPI command error message with debug message Mika Kahola
2017-09-13  8:09   ` Jani Nikula
2017-09-01  8:08 ` ✓ Fi.CI.BAT: success for drm/i915/dsi: Fix error on DSI video mode command Patchwork
2017-09-01  9:34 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-09-05  9:53 ` ✓ Fi.CI.BAT: success for drm/i915/dsi: Fix error on DSI video mode command (rev2) Patchwork
2017-09-05 11:03 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504604671-17237-1-git-send-email-vidya.srinivas@intel.com \
    --to=vidya.srinivas@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox