From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Subject: Re: [PATCH 2/2] drm/i915: Simplify i915_reg_read_ioctl
Date: Fri, 08 Sep 2017 14:22:40 +0300
Message-ID: <1504869760.19824.13.camel@linux.intel.com>
References: <20170908092935.1278-1-joonas.lahtinen@linux.intel.com>
 <20170908092935.1278-2-joonas.lahtinen@linux.intel.com>
 <150486562871.21199.11391519626765311056@mail.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 2D2CD6EB18
 for <intel-gfx@lists.freedesktop.org>; Fri,  8 Sep 2017 11:22:57 +0000 (UTC)
In-Reply-To: <150486562871.21199.11391519626765311056@mail.alporthouse.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel graphics driver community testing & development <intel-gfx@lists.freedesktop.org>
Cc: Jani Nikula <jani.nikula@intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCAyMDE3LTA5LTA4IGF0IDExOjEzICswMTAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4g
UXVvdGluZyBKb29uYXMgTGFodGluZW4gKDIwMTctMDktMDggMTA6Mjk6MzUpCj4gPiBDb252ZXJ0
IHRvIHVzZSB0aGUgZnJlc2hseSBhdmFpbGFibGUgbWFkZSBJTlRFTF9HRU5fTUFTSyBmb3IgZWFz
aWVyCj4gPiBncmVwcGluZyBhbmQgaW1wcm92ZSBmdW5jdGlvbiByZWFkYWJpbGl0eSBhbmQgY2xh
cmlmeSB0aGUgVUFCSQo+ID4gZG9jdW1lbnRhdGlvbi4KPiA+IAo+ID4gTm8gZnVuY3Rpb25hbCBj
aGFuZ2VzLgo+ID4gCj4gPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVs
LmNvbT4KPiA+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+
IFNpZ25lZC1vZmYtYnk6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4Lmlu
dGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5j
IHwgODEgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIGluY2x1ZGUv
dWFwaS9kcm0vaTkxNV9kcm0uaCAgICAgICAgIHwgIDYgKystCj4gPiAgMiBmaWxlcyBjaGFuZ2Vk
LCA0NCBpbnNlcnRpb25zKCspLCA0MyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBh
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfdW5jb3JlLmMKPiA+IGluZGV4IDFiMzhlYjk0ZDQ2MS4uNzRmMTM1ZDI0N2ExIDEw
MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPiA+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4gPiBAQCAtMTI5Miw3MiAr
MTI5Miw3MSBAQCB2b2lkIGludGVsX3VuY29yZV9maW5pKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl
ICpkZXZfcHJpdikKPiA+ICAgICAgICAgaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9yZXNldChkZXZf
cHJpdiwgZmFsc2UpOwo+ID4gIH0KPiA+ICAKPiA+IC0jZGVmaW5lIEdFTl9SQU5HRShsLCBoKSBH
RU5NQVNLKChoKSAtIDEsIChsKSAtIDEpCj4gPiAtCj4gPiAtc3RhdGljIGNvbnN0IHN0cnVjdCBy
ZWdpc3Rlcl93aGl0ZWxpc3Qgewo+ID4gLSAgICAgICBpOTE1X3JlZ190IG9mZnNldF9sZHcsIG9m
ZnNldF91ZHc7Cj4gPiAtICAgICAgIHVpbnQzMl90IHNpemU7Cj4gPiAtICAgICAgIC8qIHN1cHBv
cnRlZCBnZW5zLCAweDEwIGZvciA0LCAweDMwIGZvciA0IGFuZCA1LCBldGMuICovCj4gPiAtICAg
ICAgIHVpbnQzMl90IGdlbl9iaXRtYXNrOwo+ID4gLX0gd2hpdGVsaXN0W10gPSB7Cj4gPiAtICAg
ICAgIHsgLm9mZnNldF9sZHcgPSBSSU5HX1RJTUVTVEFNUChSRU5ERVJfUklOR19CQVNFKSwKPiA+
IC0gICAgICAgICAub2Zmc2V0X3VkdyA9IFJJTkdfVElNRVNUQU1QX1VEVyhSRU5ERVJfUklOR19C
QVNFKSwKPiA+IC0gICAgICAgICAuc2l6ZSA9IDgsIC5nZW5fYml0bWFzayA9IEdFTl9SQU5HRSg0
LCAxMCkgfSwKPiA+IC19Owo+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcmVnX3doaXRlbGlzdCB7
Cj4gPiArICAgICAgIGk5MTVfcmVnX3Qgb2Zmc2V0X2xkdzsKPiA+ICsgICAgICAgaTkxNV9yZWdf
dCBvZmZzZXRfdWR3Owo+ID4gKyAgICAgICB1bnNpZ25lZCBsb25nIGdlbl9tYXNrOwo+ID4gKyAg
ICAgICB1OCBzaXplOwo+ID4gK30gcmVnX3JlYWRfd2hpdGVsaXN0W10gPSB7ewo+IAo+IEhtbSwg
V29uJ3Qge3sgbG9vayB1bnVzdWFsIGlmIHdlIGV2ZXIgc2F5IGFkZCBhbGwgdGhlIG90aGVyIHJp
bmcKPiB0aW1lc3RhbXBzIHRvIHRoZSB3aGl0ZSBsaXN0PyBPciBwcm9ibGVtIGZvciBhbm90aGVy
IGRheT8KCkhtbT8KCndoaXRlbGlzdFtdID0ge3sKCS5hID0geCwKCS5iID0geQp9LCB7CgkuYSA9
IHcsCgkuYiA9IHoKfX07Cgo+IAo+ID4gKyAgICAgICAub2Zmc2V0X2xkdyA9IFJJTkdfVElNRVNU
QU1QKFJFTkRFUl9SSU5HX0JBU0UpLAo+ID4gKyAgICAgICAub2Zmc2V0X3VkdyA9IFJJTkdfVElN
RVNUQU1QX1VEVyhSRU5ERVJfUklOR19CQVNFKSwKPiA+ICsgICAgICAgLmdlbl9tYXNrID0gSU5U
RUxfR0VOX01BU0soNCwgMTApLAo+ID4gKyAgICAgICAuc2l6ZSA9IDgKPiA+ICt9fTsKCjxTTklQ
PgoKPiA+IC0gICAgICAgLyogV2UgdXNlIHRoZSBsb3cgYml0cyB0byBlbmNvZGUgZXh0cmEgZmxh
Z3MgYXMgdGhlIHJlZ2lzdGVyIHNob3VsZAo+ID4gLSAgICAgICAgKiBiZSBuYXR1cmFsbHkgYWxp
Z25lZCAoYW5kIHRob3NlIHRoYXQgYXJlIG5vdCBzbyBhbGlnbmVkIG1lcmVseQo+ID4gLSAgICAg
ICAgKiBsaW1pdCB0aGUgYXZhaWxhYmxlIGZsYWdzIGZvciB0aGF0IHJlZ2lzdGVyKS4KPiA+IC0g
ICAgICAgICovCj4gPiAtICAgICAgIG9mZnNldF9sZHcgPSBlbnRyeS0+b2Zmc2V0X2xkdzsKPiA+
IC0gICAgICAgb2Zmc2V0X3VkdyA9IGVudHJ5LT5vZmZzZXRfdWR3Owo+ID4gLSAgICAgICBzaXpl
ID0gZW50cnktPnNpemU7Cj4gPiAtICAgICAgIHNpemUgfD0gcmVnLT5vZmZzZXQgXiBpOTE1X21t
aW9fcmVnX29mZnNldChvZmZzZXRfbGR3KTsKPiA+ICsgICAgICAgR0VNX0JVR19PTihod2VpZ2h0
OChlbnRyeS0+c2l6ZSkgIT0gMSk7Cj4gPiArICAgICAgIEdFTV9CVUdfT04oZW50cnktPnNpemUg
PiA4KTsKPiAKPiBTZW5zaWJsZSBhc3NlcnRpb25zLCBidXQgd2UgYWxyZWFkeSBkZXBlbmRpbmcg
b24gZW50cnktPnNpemUgYmVpbmcgd2VsbAo+IGRlZmluZWQgdG8gZ2V0IHRvIGhlcmUuIFNvIG1v
dmUgaXQgdXAuIEFsc28gaHdlaWdodDgoeCkgIT0gMSBpcwo+ICFpc19wb3dlcl9vZl8yKHgpCgpZ
ZWFoLCBtYWtlcyBzZW5zZS4KCj4gPiAgCj4gPiAtICAgICAgIGludGVsX3J1bnRpbWVfcG1fZ2V0
KGRldl9wcml2KTsKPiA+ICsgICAgICAgZmxhZ3MgPSByZWctPm9mZnNldCAmIH5pOTE1X21taW9f
cmVnX29mZnNldChlbnRyeS0+b2Zmc2V0X2xkdyk7Cj4gPiAgCj4gPiAtICAgICAgIHN3aXRjaCAo
c2l6ZSkgewo+ID4gLSAgICAgICBjYXNlIDggfCAxOgo+ID4gLSAgICAgICAgICAgICAgIHJlZy0+
dmFsID0gSTkxNV9SRUFENjRfMngzMihvZmZzZXRfbGR3LCBvZmZzZXRfdWR3KTsKPiA+IC0gICAg
ICAgICAgICAgICBicmVhazsKPiA+ICsgICAgICAgaW50ZWxfcnVudGltZV9wbV9nZXQoZGV2X3By
aXYpOwo+ID4gKyAgICAgICBzd2l0Y2ggKGVudHJ5LT5zaXplKSB7Cj4gPiAgICAgICAgIGNhc2Ug
ODoKPiA+IC0gICAgICAgICAgICAgICByZWctPnZhbCA9IEk5MTVfUkVBRDY0KG9mZnNldF9sZHcp
Owo+ID4gKyAgICAgICAgICAgICAgIGlmIChmbGFncyAmIEk5MTVfUkVHX1JFQURfOEJfV0EpCj4g
Cj4gV2UncmUgbG9zaW5nIC1FSU5WQUwgZm9yIHRoZSBpbnZhbGlkIGZsYWcgY29tYmluYXRpb25z
LiBDYW4gSSB0ZW1wdCB5b3UKPiB0byB1c2UgKGVudHJ5LT5zaXplIHwgZmxhZ3MpPwoKSG1tLCBJ
IHdhbnRlZCB0byBhdm9pZCB0aGUgbWFza2luZyB3aXRoIDEgYW5kIDIgaWYgd2UgZ2V0IG1vcmUg
dGhhbiBvbmUKZmxhZy4gT2YgY291cnNlIGlmIHdlIGFzc3VtZSB0aGV5IHdvbid0IG5lZWQgZmxh
Z3MsIHdlIGNvdWxkIGtlZXAgaXQuCgpzd2l0Y2ggKGVudHJ5LT5zaXplIHwgKGZsYWdzIDw8IDQp
KSArIGNhc2UgOCB8IChJOTE1X1JFR19SRUFEXzhCX1dBIDw8CjQpIGZlZWxzIGJpdCBsaWtlIGEg
aGFjaywgdG9vLgoKV2hpY2ggb25lIGlzIGxlc3MgY29uZnVzaW5nPwoKUmVnYXJkcywgSm9vbmFz
Ci0tIApKb29uYXMgTGFodGluZW4KT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKSW50ZWwg
Q29ycG9yYXRpb24KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4
Cg==