From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH v13 2/5] drm/i915: Introduce private PAT management Date: Mon, 11 Sep 2017 11:59:45 +0300 Message-ID: <1505120385.4107.21.camel@linux.intel.com> References: <1505103993-9009-1-git-send-email-zhi.a.wang@intel.com> <1505103993-9009-2-git-send-email-zhi.a.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1505103993-9009-2-git-send-email-zhi.a.wang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Zhi Wang , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org Cc: Rodrigo Vivi , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE3LTA5LTExIGF0IDEyOjI2ICswODAwLCBaaGkgV2FuZyB3cm90ZToKPiBUaGUg cHJpdmF0ZSBQQVQgbWFuYWdlbWVudCBpcyB0byBzdXBwb3J0IFBQQVQgZW50cnkgbWFuaXB1bGF0 aW9uLiBUd28KPiBBUElzIGFyZSBpbnRyb2R1Y2VkIGZvciBkeW5hbWljYWxseSBtYW5hZ2luZyBQ UEFUIGVudHJpZXM6IGludGVsX3BwYXRfZ2V0Cj4gYW5kIGludGVsX3BwYXRfcHV0Lgo+IAo+IGlu dGVsX3BwYXRfZ2V0IHdpbGwgc2VhcmNoIGZvciBhbiBleGlzdGluZyBQUEFUIGVudHJ5IHdoaWNo IHBlcmZlY3RseQo+IG1hdGNoZXMgdGhlIHJlcXVpcmVkIFBQQVQgdmFsdWUuIElmIG5vdCwgaXQg d2lsbCB0cnkgdG8gYWxsb2NhdGUgYSBuZXcKPiBlbnRyeSBpZiB0aGVyZSBpcyBhbnkgYXZhaWxh YmxlIFBQQVQgaW5kZXhzLCBvciByZXR1cm4gYSBwYXJ0aWFsbHkKPiBtYXRjaGVkIFBQQVQgZW50 cnkgaWYgdGhlcmUgaXMgbm8gYXZhaWxhYmxlIFBQQVQgaW5kZXhlcy4KPiAKPiBpbnRlbF9wcGF0 X3B1dCB3aWxsIHB1dCBiYWNrIHRoZSBQUEFUIGVudHJ5IHdoaWNoIGNvbWVzIGZyb20KPiBpbnRl bF9wcGF0X2dldC4gSWYgaXQncyBkeW5hbWljYWxseSBhbGxvY2F0ZWQsIHRoZSByZWZlcmVuY2Ug Y291bnQgd2lsbAo+IGJlIGRlY3JlYXNlZC4gSWYgdGhlIHJlZmVyZW5jZSBjb3VudCB0dXJucyBp bnRvIHplcm8sIHRoZSBQUEFUIGluZGV4IGlzCj4gZnJlZWQgYWdhaW4uCj4gCj4gQmVzaWRlcywg YW5vdGhlciB0d28gY2FsbGJhY2tzIGFyZSBpbnRyb2R1Y2VkIHRvIHN1cHBvcnQgdGhlIHByaXZh dGUgUEFUCj4gbWFuYWdlbWVudCBmcmFtZXdvcmsuIE9uZSBpcyBwcGF0LT51cGRhdGVfaHcoKSwg d2hpY2ggd3JpdGVzIHRoZSBQUEFUCj4gY29uZmlndXJhdGlvbnMgaW4gcHBhdC0+ZW50cmllcyBp bnRvIEhXLiBBbm90aGVyIG9uZSBpcyBwcGF0LT5tYXRjaCwgd2hpY2gKPiB3aWxsIHJldHVybiBh IHNjb3JlIHRvIHNob3cgaG93IHR3byBQUEFUIHZhbHVlcyBtYXRjaCB3aXRoIGVhY2ggb3RoZXIu Cj4gCj4gdjEyOgo+IAo+IC0gRml4IGEgcHJvYmxlbSAibm90IHJldHVybmluZyB0aGUgZW50cnkg b2YgYmVzdCBzY29yZSIuIChaaGVueXUpCgpUaGlzIGNoYW5nZSBzaG91bGQgaGF2ZSByZXN1bHRl ZCBpbiBhZGRpbmcgYW4gaW5kaWNhdGlvbiB0aGF0IENocmlzCnJldmlld2VkIG9ubHkgYSBwcmV2 aW91cyB2ZXJzaW9uIG9mIHRoZSBwYXRjaC4KCj4gCj4gdjc6Cj4gCj4gLSBLZWVwIGFsbCB0aGUg cmVnaXN0ZXIgd3JpdGVzIHVuY2hhbmdlZCBpbiB0aGlzIHBhdGNoLiAoSm9vbmFzKQo+IAo+IHY2 Ogo+IAo+IC0gQWRkcmVzcyBhbGwgY29tbWVudHMgZnJvbSBDaHJpczoKPiBodHRwOi8vd3d3LnNw aW5pY3MubmV0L2xpc3RzL2ludGVsLWdmeC9tc2cxMzY4NTAuaHRtbAo+IAo+IC0gQWRkcmVzcyBh bGwgY29tbWVudHMgZnJvbSBKb29uYXM6Cj4gaHR0cDovL3d3dy5zcGluaWNzLm5ldC9saXN0cy9p bnRlbC1nZngvbXNnMTM2ODQ1Lmh0bWwKPiAKPiB2NToKPiAKPiAtIEFkZCBjaGVjayBhbmQgd2Fy bm5pbmdzIGZvciB0aG9zZSBwbGF0Zm9ybXMgd2hpY2ggZG9uJ3QgaGF2ZSBQUEFULgo+IAo+IHYz Ogo+IAo+IC0gSW50cm9kdWNlIGRpcnR5IGJpdG1hcCBmb3IgUFBBVCByZWdpc3RlcnMuIChDaHJp cykKPiAtIENoYW5nZSB0aGUgbmFtZSBvZiB0aGUgcG9pbnRlciAiZGV2X3ByaXYiIHRvICJpOTE1 Ii4gKENocmlzKQo+IC0gaW50ZWxfcHBhdF97Z2V0LCBwdXR9IHJldHVybnMvdGFrZXMgYSBjb25z dCBpbnRlbF9wcGF0X2VudHJ5ICouIChDaHJpcykKPiAKPiB2MjoKPiAKPiAtIEFQSSByZS1kZXNp Z24uIChDaHJpcykKPiAKPiBSZXZpZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13 aWxzb24uY28udWs+Cj4gQ2M6IEJlbiBXaWRhd3NreSA8YmVuamFtaW4ud2lkYXdza3lAaW50ZWwu Y29tPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gQ2M6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBKb29uYXMgTGFodGlu ZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogWmhp IFdhbmcgPHpoaS5hLndhbmdAaW50ZWwuY29tPgoKPFNOSVA+Cgo+ICsvKioKPiArICogaW50ZWxf cHBhdF9nZXQgLSBnZXQgYSB1c2FibGUgUFBBVCBlbnRyeQo+ICsgKiBAaTkxNTogaTkxNSBkZXZp Y2UgaW5zdGFuY2UKPiArICogQHZhbHVlOiB0aGUgUFBBVCB2YWx1ZSByZXF1aXJlZCBieSB0aGUg Y2FsbGVyCj4gKyAqCj4gKyAqIFRoZSBmdW5jdGlvbiB0cmllcyB0byBzZWFyY2ggaWYgdGhlcmUg aXMgYW4gZXhpc3RpbmcgUFBBVCBlbnRyeSB3aGljaAo+ICsgKiBtYXRjaGVzIHdpdGggdGhlIHJl cXVpcmVkIHZhbHVlLiBJZiBwZXJmZWN0bHkgbWF0Y2hlZCwgdGhlIGV4aXN0aW5nIFBQQVQKPiAr ICogZW50cnkgd2lsbCBiZSB1c2VkLiBJZiBvbmx5IHBhcnRpYWxseSBtYXRjaGVkLCBpdCB3aWxs IHRyeSB0byBjaGVjayBpZgo+ICsgKiB0aGVyZSBpcyBhbnkgYXZhaWxhYmxlIFBQQVQgaW5kZXgu IElmIHllcywgaXQgd2lsbCBhbGxvY2F0ZSBhIG5ldyBQUEFUCj4gKyAqIGluZGV4IGZvciB0aGUg cmVxdWlyZWQgZW50cnkgYW5kIHVwZGF0ZSB0aGUgSFcuIElmIG5vdCwgdGhlIHBhcnRpYWxseQo+ ICsgKiBtYXRjaGVkIGVudHJ5IHdpbGwgYmUgdXNlZC4KPiArICovCj4gK2NvbnN0IHN0cnVjdCBp bnRlbF9wcGF0X2VudHJ5ICoKPiAraW50ZWxfcHBhdF9nZXQoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmk5MTUsIHU4IHZhbHVlKQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfcHBhdCAqcHBhdCA9ICZp OTE1LT5wcGF0Owo+ICsJc3RydWN0IGludGVsX3BwYXRfZW50cnkgKmVudHJ5Owo+ICsJdW5zaWdu ZWQgaW50IHNjYW5uZWQsIGJlc3Rfc2NvcmU7Cj4gKwlpbnQgaTsKPiArCj4gKwlHRU1fQlVHX09O KCFwcGF0LT5tYXhfZW50cmllcyk7Cj4gKwo+ICsJc2Nhbm5lZCA9IGJlc3Rfc2NvcmUgPSAwOwoK WW91IGNhbiBkcm9wIHRoaXMgZXh0cmEgbmV3bGluZS4KCj4gKwlmb3JfZWFjaF9zZXRfYml0KGks IHBwYXQtPnVzZWQsIHBwYXQtPm1heF9lbnRyaWVzKSB7Cj4gKwkJdW5zaWduZWQgaW50IHNjb3Jl Owo+ICsKPiArCQlzY29yZSA9IHBwYXQtPm1hdGNoKHBwYXQtPmVudHJpZXNbaV0udmFsdWUsIHZh bHVlKTsKPiArCQlpZiAoc2NvcmUgPiBiZXN0X3Njb3JlKSB7CgpJZiB5b3Ugc2V0ICJlbnRyeSA9 ICZwcGF0LT5lbnRyaWVzW2ldOyIgaGVyZSBhbHJlYWR5LgoKPiArCQkJaWYgKHNjb3JlID09IElO VEVMX1BQQVRfUEVSRkVDVF9NQVRDSCkgewo+ICsJCQkJa3JlZl9nZXQoJnBwYXQtPmVudHJpZXNb aV0ucmVmKTsKPiArCQkJCXJldHVybiAmcHBhdC0+ZW50cmllc1tpXTsKClRoZXNlIGJlY29tZSAi a3JlZl9nZXQoJmVudHJ5LT5yZWYpOyIgYW5kICJyZXR1cm4gZW50cnk7IgoKPiArc3RhdGljIHVu c2lnbmVkIGludCBiZHdfcHJpdmF0ZV9wYXRfbWF0Y2godTggc3JjLCB1OCBkc3QpCj4gK3sKPiAr CXVuc2lnbmVkIGludCBzY29yZSA9IDA7Cj4gKwo+ICsJLyogQ2FjaGUgYXR0cmlidXRlIGhhcyB0 byBiZSBtYXRjaGVkLiAqLwo+ICsJaWYgKEdFTjhfUFBBVF9HRVRfQ0Eoc3JjKSAhPSBHRU44X1BQ QVRfR0VUX0NBKGRzdCkpCj4gKwkJcmV0dXJuIDA7CgpXZSdyZSBub3QgZ2l2aW5nIGFueSBwb2lu dHMgZm9yIHdoZW4gb25seSBjYWNoZSBhdHRyaWJ1dGUgbWF0Y2hlcz8gRG9lcwpub3QgdGhpcyBy ZXN1bHQgaW4gRU5PU1BDIHdoZW4gd2Ugd291bGQgaGF2ZSBhbiBlbnRyeSB3aXRoIG1hdGNoaW5n CiJjYWNoZSBhdHRyaWJ1dGUiLCBidXQgbm8gb3RoZXIgbWF0Y2hpbmcgZW50cmllcyB3aGlsZSBQ UEFUIGlzIGZ1bGwuCgoJc28gbWF5YmUgc2NvcmUgKz0gNCBoZXJlPwoKPiArCj4gKwlpZiAoR0VO OF9QUEFUX0dFVF9UQyhzcmMpID09IEdFTjhfUFBBVF9HRVRfVEMoZHN0KSkKPiArCQlzY29yZSAr PSAyOwo+ICsKPiArCWlmIChHRU44X1BQQVRfR0VUX0FHRShzcmMpID09IEdFTjhfUFBBVF9HRVRf QUdFKGRzdCkpCj4gKwkJc2NvcmUgKz0gMTsKPiArCj4gKwlpZiAoc2NvcmUgPT0gMykKCgkoc2Nv cmUgPT0gNykgcmVzcGVjdGl2ZWx5LgoKPiArCQlyZXR1cm4gSU5URUxfUFBBVF9QRVJGRUNUX01B VENIOwo+ICsKPiArCXJldHVybiBzY29yZTsKPiArfQo+ICsKPiArc3RhdGljIHVuc2lnbmVkIGlu dCBjaHZfcHJpdmF0ZV9wYXRfbWF0Y2godTggc3JjLCB1OCBkc3QpCj4gK3sKPiArCXJldHVybiAo Q0hWX1BQQVRfR0VUX1NOT09QKHNyYykgPT0gQ0hWX1BQQVRfR0VUX1NOT09QKGRzdCkpID8KPiAr CQlJTlRFTF9QUEFUX1BFUkZFQ1RfTUFUQ0ggOiAwOwoKVGhpcyBoYW5kbGVzIHRoZSBzaXR1YXRp b24gY29ycmVjdGx5LCB3aGVuIHNub29waW5nIGlzIHRoZSBvbmx5CmF0dHJpYnV0ZSBsb29rZWQg Zm9yLgoKV2l0aCB0aGUgQkRXIGF0dHJpYnV0ZSBmaXggc2NvcmluZywgdGhpcyBpczsKClJldmll d2VkLWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+ CgpSZW1lbWJlciB0byBhZGQgdG8gdGhlIGVuZCBvZiB0aGUgdGFnIGxpc3QgOykKClJlZ2FyZHMs IEpvb25hcwotLSAKSm9vbmFzIExhaHRpbmVuCk9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVy CkludGVsIENvcnBvcmF0aW9uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=