public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Samu Kaajas <samu.kaajas@intel.com>,
	Jari Tahvanainen <jari.tahvanainen@intel.com>
Subject: Re: [PATCH] drm/i915: Disable DMC powersaving during GT operations
Date: Mon, 18 Sep 2017 16:40:35 +0300	[thread overview]
Message-ID: <1505742035.14048.53.camel@linux.intel.com> (raw)
In-Reply-To: <150522048993.29947.8471983241609081359@mail.alporthouse.com>

+ Jari & Samu

On Tue, 2017-09-12 at 13:48 +0100, Chris Wilson wrote:
> Quoting Chris Wilson (2017-09-12 13:37:32)
> > diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c
> > index 813a3b546d6e..3c8ebdb5b0b4 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_request.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_request.c
> > @@ -254,6 +254,9 @@ static void mark_busy(struct drm_i915_private *i915)
> >         intel_runtime_pm_get_noresume(i915);
> >         i915->gt.awake = true;
> >  
> 
> /*
>  * The DMC doesn't behave well when it is active (i.e the system is
>  * idle). It continually tries to toggle DC_STATE_EN causing a
>  * severe slow down of the rest of the system (severe enough to trigger
>  * watchdogs and reboot the machine under CI testing).
>  *
>  * Known affected firmware:
>  * - skl_dmc_ver1_26.bin
>  * - bxt_dmc_ver1_07.bin
>  */

Has this patch been tested more widely, does it have negative
performance effects?

Regards, Joonas

> > +       if (i915->csr.dmc_payload)
> > +               intel_display_power_get(i915, POWER_DOMAIN_MODESET);
> > +
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-09-18 13:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-12 12:37 [PATCH] drm/i915: Disable DMC powersaving during GT operations Chris Wilson
2017-09-12 12:45 ` Tvrtko Ursulin
2017-09-12 12:57   ` Tvrtko Ursulin
2017-09-13  9:08     ` Imre Deak
2017-09-12 12:48 ` Chris Wilson
2017-09-18 13:40   ` Joonas Lahtinen [this message]
2017-09-19 12:22     ` Tahvanainen, Jari
2017-09-12 13:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-12 15:55 ` ✗ Fi.CI.IGT: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505742035.14048.53.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jari.tahvanainen@intel.com \
    --cc=samu.kaajas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox