Re: [PATCH 1/3] drm/i915: Assert the context is not closed on object-close

Chris Wilson
2017-08-24T14:25:52Z

Quoting Lofstedt, Marta (2017-08-22 12:59:59)
> Thanks Chris,
> With this series the test pin-pointed in the bug now pass.
>
> Tested-by: Marta Lofstedt <marta.lofstedt@intel.com>
>
> > -----Original Message-----
> > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf
> > Of Chris Wilson
> > Sent: Tuesday, August 22, 2017 2:05 PM
> > To: intel-gfx@lists.freedesktop.org
> > Subject: [Intel-gfx] [PATCH 1/3] drm/i915: Assert the context is not closed on
> > object-close
> >
> > During the context-close, we should be decoupling all the vma from the
> > object so that upon object-closing we shouldn't see any vma from the
> > already closed contexts. So include a check upon closing the object that the
> > context is still open.
> >
> > v2: Eek, the fpriv check is required for shared objects. Double eek, BAT
> > passed?
>
> Well, the KBL-shards results actually exposed the regression:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5429/shards-all.html
> So, could you remove that comment.

The comment is referrering to v1 of this patch which did manage to pass
BAT despite it being common practice on ggtt/aliasing_ppgtt setups.
-Chris