From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Shuo Liu <shuo.a.liu@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org
Subject: Re: [PATCH v4 1/3] drm/i915/gvt: Add gvt_debug in i915_params for GVT-g log classification
Date: Tue, 19 Sep 2017 16:20:20 +0300 [thread overview]
Message-ID: <1505827220.15429.15.camel@linux.intel.com> (raw)
In-Reply-To: <20170919100337.GA22243@shuo-intel.sh.intel.com>
On Tue, 2017-09-19 at 18:03 +0800, Shuo Liu wrote:
> On Tue 19.Sep'17 at 12:11:28 +0300, Joonas Lahtinen wrote:
> > The title should begin with "drm/i915:" not "drm/i915/gvt:".
>
> My fault. Will correct it.
> >
> > On Tue, 2017-09-19 at 15:54 +0800, Shuo Liu wrote:
> >
> > Commit message is always needed.
>
> OK, will add it.
> >
> > > Signed-off-by: Shuo Liu <shuo.a.liu@intel.com>
> >
> > <SNIP>
> >
> > > @@ -65,6 +65,7 @@ struct i915_params i915 __read_mostly = {
> > > .inject_load_failure = 0,
> > > .enable_dpcd_backlight = false,
> > > .enable_gvt = false,
> > > + .debug_gvt = 0,
> >
> > Let's try to keep the struct ordered.
>
> What's the order? I see it's different with struct definition.
Yeah, it seems to be messed. Leave it as it is, I'll send a fix for all
of them.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-19 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 7:54 [PATCH v4 1/3] drm/i915/gvt: Add gvt_debug in i915_params for GVT-g log classification Shuo Liu
2017-09-19 7:54 ` [PATCH v4 2/3] drm/i915/gvt: Change log function of kvmgt to common ones Shuo Liu
2017-09-19 7:54 ` [PATCH v4 3/3] drm/i915/gvt: Use debug_gvt to classify GVT-g log messages Shuo Liu
2017-09-19 9:11 ` [PATCH v4 1/3] drm/i915/gvt: Add gvt_debug in i915_params for GVT-g log classification Joonas Lahtinen
2017-09-19 10:03 ` Shuo Liu
2017-09-19 13:20 ` Joonas Lahtinen [this message]
2017-09-19 9:22 ` Chris Wilson
2017-09-19 10:17 ` Shuo Liu
2017-09-19 20:45 ` Zhenyu Wang
2017-09-20 2:21 ` Shuo Liu
2017-09-19 17:18 ` ✗ Fi.CI.BAT: failure for series starting with [v4,1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505827220.15429.15.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=shuo.a.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox