From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly Date: Fri, 22 Sep 2017 14:11:03 +0300 Message-ID: <1506078663.6232.65.camel@linux.intel.com> References: <20170919155534.25334-1-colin.king@canonical.com> <20170919214614.cfiolgznopouv34e@zhen-hp.sh.intel.com> <1505874923.2067.14.camel@perches.com> <20170920224406.jscthkglwfy3xhtf@zhen-hp.sh.intel.com> <1506004318.5382.4.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Wang, Zhi A" , Zhenyu Wang , Joe Perches Cc: "Gao, Fred" , David Airlie , "intel-gfx@lists.freedesktop.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Vivi, Rodrigo" , Colin King , "intel-gvt-dev@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyMDE3LTA5LTIxIGF0IDE2OjE3ICswMDAwLCBXYW5nLCBaaGkgQSB3cm90ZToKPiBI aSBKb29uYXM6Cj4gCj4gVGhhbmtzIGZvciB0aGUgaW50cm9kdWN0aW9uLiBJIGhhdmUgYmVlbiB0 aGlua2luZyBhYm91dCB0aGUKPiBwb3NzaWJpbGl0eSBvZiBpbnRyb2R1Y2luZyBHRU1fQlVHX09O IGludG8gR1ZULWcgcmVjZW50bHkgYW5kCj4gaW52ZXN0aWdhdGluZyBvbiBpdC4gSSdtIGp1c3Qg YSBiaXQgY29uZnVzZWQgYWJvdXQgdGhlIHVzYWdlIGJldHdlZW4KPiBHRU1fQlVHX09OIGFuZCBX QVJOX09OLgoKR0VNX0JVR19PTiBpcyBiYXNpY2FsbHkgdGhlcmUgdG8gY2F0Y2ggdGhpbmdzIHRo YXQgd2UgZG8gbm90IGV4cGVjdApldmVyIHRvIGhhcHBlbiB3aXRoaW4gdGhlIGRyaXZlci4gU28g d2Ugb2Z0ZW4gbGlzdCB0aGUgZnVuY3Rpb24KcHJlY29uZGl0aW9ucyBhcyBHRU1fQlVHX09OLiBJ dCdzIHRoZXJlIGZvciB0aGUgc2FtZSByZWFzb24gYXMgdGhlCmxvY2tkZXBfYXNzZXJ0X2hlbGQg YW5kIEtBU0FOLiBJdCdzIHNvbWV0aW1lcyBoZWF2eSBjaGVja3MgdGhhdCB3ZQpyZWFsbHkgd2Fu dCB0byBydW4gd2hlbiBmdW5jdGlvbmFsbHkgdmFsaWRhdGluZyBrZXJuZWwuCgpHRU1fQlVHX09O IGJlY2FtZSB0byBleGlzdGVuY2UgYmVjYXVzZSBhZGRpbmcgY2hlY2tzIGZvciBvYnZpb3VzCmNv bmRpdGlvbnMgYXQgdGhlIGNyaXRpY2FsIGNvbW1hbmQgc3VibWlzc2lvbiBwYXRoIEdFTSBpcyBu b3QKc3VzdGFpbmFibGUgZm9yIHBlcmZvcm1hbmNlIGluIHByb2R1Y3Rpb24uCgpUaGUgZXhwZWN0 YXRpb24gaXMgdGhhdCBlYWNoIEdFTV9CVUdfT04gaGFzIGEgdGVzdGNhc2UgaW4gSS1HLVQgdGhh dApoYXMgdGhlIHBvdGVudGlhbCB0byBoaXQgaXQgaWYgZHJpdmVyIHdhcyBtb2RpZmllZCBub3Qg dG8gcmVzcGVjdCB0aG9zZQpwcmVjb25kaXRpb25zLiBTbyBvbmNlIG91ciB0ZXN0ZXN0IHBhc3Nl cywgd2UgY2FuIGRpc2FibGUgdGhlCkdFTV9CVUdfT05zIGFuZCBiZSBjb25maWRlbnQgb2YgdGhl IGludGVybmFsIGRyaXZlciBxdWFsaXR5IGFuZCBnZXQgdGhlCnJlbGVhc2UgcGVyZm9ybWFuY2Uu CgpXQVJOX09OIGlzIG1vc3RseSB1c2VkIGZvciB0aGUgY2FzZXMgd2hlbiB0aGUgaGFyZHdhcmUg aXMgYmVoYXZpbmcKZGlmZmVyZW50bHkgdGhhbiB3ZSBleHBlY3QuIFdlIGNhbid0IHJlbW92ZSB0 aGVtIGFzIHdlIGRvbid0IGhhdmUgYWxsCnRoZSBoYXJkd2FyZSBpbiB0aGUgd29ybGQgdG8gdGVz dCwgYnV0IHdlIHRyeSB0byBleGVyY2lzZSB0aGVtIHRvbwp0aHJvdWdoIEktRy1Ucy4gVGhlIHRl c3Qgd2lsbCBvZnRlbiBiZSB0aGUgc3VidGVzdCB0aGF0IHdhcyB3cml0dGVuIHRvCnJlcHJvZHVj ZSB0aGUgcHJvYmxlbSB3aXRoIG91ciBleHBlY3RhdGlvbnMgb2YgaGFyZHdhcmUgaW4gY2FzZSBv ZgpoYW5ncyBhbmQgb3RoZXIgYnVncy4gQWZ0ZXIgd2UndmUgY29ycmVjdGVkIHRoZSBkcml2ZXIg YmVoYXZpb3VyLCBvcgpnb3QgYSBoYXJkd2FyZSBXL0EgYXNzaWduZWQsIHdlIGtlZXAgdGhlIHRl c3QgYW5kIGFkZCBhIFdBUk5fT04gdG8gbWFrZQpzdXJlIHRoZXJlIHdpbGwgYmUgbm8gcmVncmVz c2lvbiBiYWNrIHRvIHRoZSBzYW1lIHNpdHVhdGlvbi4KClRoaXMgaXMgYXQgbGVhc3Qgd2hhdCBz aG91bGQgaGFwcGVuLCBnaXZlbiB0aW1lIGNvbnN0cmFpbnRzLCB0aGVyZSBtYXkKYmUgdmFyaWF0 aW9ucy4KClVzZXIgYmVoYXZpbmcgdW5leHBlY3RlZGx5IHNob3VsZCBuZXZlciByZXN1bHQgaW4g V0FSTl9PTiAob3IgZXZlbgp3b3JzZSwgQlVHX09OKSwgc2hvdWxkIGFsd2F5cyBqdXN0IGJlIGRl YnVnIG1lc3NhZ2VzIGRpc3BsYXllZCAobm90IHRvCnRyaWdnZXIgdGhlIENJKSBhbmQgZXJyb3Jz IHByb3BhZ2F0ZWQgYmFjayB0byB1c2VyOgoKaHR0cHM6Ly8wMS5vcmcvbGludXhncmFwaGljcy9n ZngtZG9jcy9kcm0vZ3B1L2RybS11YXBpLmh0bWwjcmVjb21tZW5kZWQKLWlvY3RsLXJldHVybi12 YWx1ZXMKCkJhcmUgQlVHX09OIHNob3VsZCBvbmx5IGJlIHVzZWQgd2hlbiB0aGVyZSdzIHRoZSBk YW5nZXIgb2YgY29ycnVwdGluZwpzeXN0ZW0gbWVtb3J5IG9yIGZpbGVzeXN0ZW1zLCBzbyBmcm9t IGdyYXBoaWNzIGRyaXZlciwgdGhhdCdzIG5vdCB2ZXJ5Cm9mdGVuLiBDb250cm9sbGVkIHByb3Bh Z2F0aW9uIG9mIGVycm9ycyBhbmQgbWF5YmUgV0FSTl9PTiBpcyBhbHdheXMKcHJlZmVycmVkIGlm IHBvc3NpYmxlLgoKCj4gR0VNX0JVR19PTiBpcyBvbmx5IGVuYWJsZWQgd2hlbiBrZXJuZWwgZGVi dWcgaXMgZW5hYmxlZCwgd2hpY2ggbW9zdGx5Cj4gaXMgZGlzYWJsZWQgaW4gYSBwcm9kdWN0aW9u IGtlcm5lbC4gSW4gdGhlIGNhc2Ugb2YgaTkxNSwgSSdtIHN1cmUgaXQKPiB3aWxsIGJlIGVuYWJs ZWQgaW4gQ0kgdGVzdCBzbyB0aGF0IGl0IGNhbiBjYXRjaCBicm9rZW4gY29kZSBwYXRoLgo+IExv b2tpbmcgaW50byBHVlQtZywgdGhlIHNpbWlsYXIgc2NlbmFyaW8gaXMgd2UgZW5hYmxlIGl0IGlu IFFBIHRlc3QuCj4gCj4gTGV0J3Mgc2F5IEdFTV9CVUdfT04gY2FuIGRvIGl0cyB3b3JrIHZlcnkg d2VsbCBpbiBRQSB0ZXN0IGJ1dCBRQSB0ZXN0Cj4gaXMgbm90IGZ1bGx5IGNvdmVyZWQgYWxsIHRo ZSBjb25kaXRpb24sIHRoZW4gc29tZXRoaW5nIG1pZ2h0IGJlIHN0aWxsCj4gYnJva2VuIHdoZW4g aXQgY29tZXMgdG8gdGhlIHByb2R1Y3Rpb24ga2VybmVsIGZvciB1c2VyIGFuZCBHRU1fQlVHX09O Cj4gd2lsbCBiZSBkaXNhYmxlZCBhbmQgd2lsbCBub3QgY2F0Y2ggdGhhdCwgSSBndWVzcy4KPiAK PiBUaGF0J3MgbXkgY29uZnVzaW9uIHdoaWNoIHNjcmF0Y2hlZCBteSBtaW5kIGR1cmluZyB0aGUg aW52ZXN0aWdhdGlvbjoKPiBJZiBHRU1fQlVHX09OIGlzIG5vdCBhbHdheXMgd29ya2luZywgdGhl biBpdCBsb29rcyBXQVJOX09OIHNob3VsZAo+IGFsd2F5cyBiZSB1c2VkLi4uLiBFeHBlY3RlZCB0 byBsZWFybiBtb3JlIGFib3V0IHRoZSBzdG9yeSBiZWhpbmQuIDopCgpTbyBpZiB0aGUgc2F5aW5n IGlzIHNvbWUgb2JqZWN0IGlzICJuZXZlciBnb2luZyB0byBiZSBiaWdnZXIgdGhhbiAyRyIsCnRo ZXJlIHNob3VsZCBiZSBlaXRoZXI6CgoxLiBHRU1fQlVHX09OIGxpa2UgYXNzZXJ0aW9uIGZvciBp dCBhbmQgYSB0ZXN0IHRoYXQgdHJpZXMgdG8gaGl0IGl0LCBieQp0cnlpbmcgdG8gYWxsb2NhdGUg YSBodWdlIG9iamVjdCBmb3IgZXhhbXBsZSwgYW5kIHNob3VsZCBnZXQgcmVqZWN0aW9uCmFzIC1F SU5WQUwKCjIuIFRlc3QgdG8gc2VlIGlmIHRoZSBvYmplY3QgaXMgYmlnZ2VyLCBhbmQgcHJvcGFn YXRlIGJhY2sgdGhlIGVycm9yIGlmCml0IGlzLiBFaXRoZXIgcmVzdWx0aW5nIGluIHVzZXIgcmVw b3J0ZWQgZXJyb3IgaWYgdGhlIG9yaWdpbiBvZiB0aGUKb2JqZWN0IGlzIG91dHNpZGUgb2Yga2Vy bmVsIDwtPiBoYXJkd2FyZS4gT3IgYSBXQVJOX09OIGlmIGl0J3Mgc3RyYW5nZQpoYXJkd2FyZSBv ciBrZXJuZWwgZHJpdmVyIGJlaGF2aW9yLgoKWW91IHNob3VsZCBjaG9vc2UgZGVwZW5kaW5nIG9u IGhvdyBvZnRlbiB5b3VyIGZ1bmN0aW9uIGdldHMgY2FsbGVkLCBhbmQKaG93IGNyaXRpY2FsIHRo ZSBleGVjdXRpb24gdGltZSBpcy4KCkhvcGVmdWxseSB0aGlzIGNsYXJpZmllZCB0aGluZ3MuCgpS ZWdhcmRzLCBKb29uYXMKLS0gCkpvb25hcyBMYWh0aW5lbgpPcGVuIFNvdXJjZSBUZWNobm9sb2d5 IENlbnRlcgpJbnRlbCBDb3Jwb3JhdGlvbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK