* [PATCH i-g-t] tests/kms_frontbuffer_tracking: Try harder to collect CRC's
@ 2017-09-22 12:34 Mika Kahola
2017-09-22 15:25 ` Rodrigo Vivi
2017-09-22 16:15 ` ✗ Fi.CI.BAT: warning for " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Mika Kahola @ 2017-09-22 12:34 UTC (permalink / raw)
To: intel-gfx
It seems that at least with GLK with MIPI/DSI display, the first collected
CRC is bogus. To fix this, try to collect two CRC's instead of one.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101309
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
tests/kms_frontbuffer_tracking.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index a068c8a..df7cc6e 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1239,8 +1239,18 @@ static void print_crc(const char *str, struct both_crcs *crc)
static void collect_crcs(struct both_crcs *crcs, bool mandatory_sink_crc)
{
- igt_pipe_crc_collect_crc(pipe_crc, &crcs->pipe);
+ int n;
+ igt_crc_t *crc = NULL;
+
+ igt_pipe_crc_start(pipe_crc);
+ n = igt_pipe_crc_get_crcs(pipe_crc, 2, &crc);
+ igt_pipe_crc_stop(pipe_crc);
+ igt_assert(n > 0);
+ igt_assert_crc_equal(&crc[0], &crc[1]);
+ crcs->pipe = crc[0];
+
get_sink_crc(&crcs->sink, mandatory_sink_crc);
+ free(crc);
}
static void init_blue_crc(enum pixel_format format, bool mandatory_sink_crc)
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH i-g-t] tests/kms_frontbuffer_tracking: Try harder to collect CRC's
2017-09-22 12:34 [PATCH i-g-t] tests/kms_frontbuffer_tracking: Try harder to collect CRC's Mika Kahola
@ 2017-09-22 15:25 ` Rodrigo Vivi
2017-09-25 10:18 ` Mika Kahola
2017-09-22 16:15 ` ✗ Fi.CI.BAT: warning for " Patchwork
1 sibling, 1 reply; 4+ messages in thread
From: Rodrigo Vivi @ 2017-09-22 15:25 UTC (permalink / raw)
To: Mika Kahola, intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1923 bytes --]
Maybe we are missing a vblank wait somewhere on kernel CRC code?!
Or maybe o kernel we read and discard the first for GLK?! :/
Also this is pipe crc right?! Shouldn't it be independent of the panel at
the end?! Does it only happen with MIPI/DSI ?! Or it just happen on that
particular unity on CI that coincidentally has this panel?!
On Fri, Sep 22, 2017 at 5:40 AM Mika Kahola <mika.kahola@intel.com> wrote:
> It seems that at least with GLK with MIPI/DSI display, the first collected
> CRC is bogus. To fix this, try to collect two CRC's instead of one.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101309
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> tests/kms_frontbuffer_tracking.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_frontbuffer_tracking.c
> b/tests/kms_frontbuffer_tracking.c
> index a068c8a..df7cc6e 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -1239,8 +1239,18 @@ static void print_crc(const char *str, struct
> both_crcs *crc)
>
> static void collect_crcs(struct both_crcs *crcs, bool mandatory_sink_crc)
> {
> - igt_pipe_crc_collect_crc(pipe_crc, &crcs->pipe);
> + int n;
> + igt_crc_t *crc = NULL;
> +
> + igt_pipe_crc_start(pipe_crc);
> + n = igt_pipe_crc_get_crcs(pipe_crc, 2, &crc);
> + igt_pipe_crc_stop(pipe_crc);
> + igt_assert(n > 0);
> + igt_assert_crc_equal(&crc[0], &crc[1]);
> + crcs->pipe = crc[0];
> +
> get_sink_crc(&crcs->sink, mandatory_sink_crc);
> + free(crc);
> }
>
> static void init_blue_crc(enum pixel_format format, bool
> mandatory_sink_crc)
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
[-- Attachment #1.2: Type: text/html, Size: 2959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH i-g-t] tests/kms_frontbuffer_tracking: Try harder to collect CRC's
2017-09-22 15:25 ` Rodrigo Vivi
@ 2017-09-25 10:18 ` Mika Kahola
0 siblings, 0 replies; 4+ messages in thread
From: Mika Kahola @ 2017-09-25 10:18 UTC (permalink / raw)
To: Rodrigo Vivi, intel-gfx
On Fri, 2017-09-22 at 15:25 +0000, Rodrigo Vivi wrote:
>
> Maybe we are missing a vblank wait somewhere on kernel CRC code?!
> Or maybe o kernel we read and discard the first for GLK?! :/
> Also this is pipe crc right?! Shouldn't it be independent of the
> panel at the end?! Does it only happen with MIPI/DSI ?! Or it just
> happen on that particular unity on CI that coincidentally has this
> panel?!
Yes, this is pipe crc. It should be independent of the display panel.
GLK+MIPI/DSI was the first platform that hit this issue. There are
others such as BDW, CFL and CNL that seems to be affected by this
https://bugs.freedesktop.org/show_bug.cgi?id=102374
>
> On Fri, Sep 22, 2017 at 5:40 AM Mika Kahola <mika.kahola@intel.com>
> wrote:
> > It seems that at least with GLK with MIPI/DSI display, the first
> > collected
> > CRC is bogus. To fix this, try to collect two CRC's instead of one.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101309
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> > tests/kms_frontbuffer_tracking.c | 12 +++++++++++-
> > 1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_frontbuffer_tracking.c
> > b/tests/kms_frontbuffer_tracking.c
> > index a068c8a..df7cc6e 100644
> > --- a/tests/kms_frontbuffer_tracking.c
> > +++ b/tests/kms_frontbuffer_tracking.c
> > @@ -1239,8 +1239,18 @@ static void print_crc(const char *str,
> > struct both_crcs *crc)
> >
> > static void collect_crcs(struct both_crcs *crcs, bool
> > mandatory_sink_crc)
> > {
> > - igt_pipe_crc_collect_crc(pipe_crc, &crcs->pipe);
> > + int n;
> > + igt_crc_t *crc = NULL;
> > +
> > + igt_pipe_crc_start(pipe_crc);
> > + n = igt_pipe_crc_get_crcs(pipe_crc, 2, &crc);
> > + igt_pipe_crc_stop(pipe_crc);
> > + igt_assert(n > 0);
> > + igt_assert_crc_equal(&crc[0], &crc[1]);
> > + crcs->pipe = crc[0];
> > +
> > get_sink_crc(&crcs->sink, mandatory_sink_crc);
> > + free(crc);
> > }
> >
> > static void init_blue_crc(enum pixel_format format, bool
> > mandatory_sink_crc)
> > --
> > 2.7.4
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >
> --
> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br
>
--
Mika Kahola - Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: warning for tests/kms_frontbuffer_tracking: Try harder to collect CRC's
2017-09-22 12:34 [PATCH i-g-t] tests/kms_frontbuffer_tracking: Try harder to collect CRC's Mika Kahola
2017-09-22 15:25 ` Rodrigo Vivi
@ 2017-09-22 16:15 ` Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-09-22 16:15 UTC (permalink / raw)
To: Mika Kahola; +Cc: intel-gfx
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Try harder to collect CRC's
URL : https://patchwork.freedesktop.org/series/30760/
State : warning
== Summary ==
IGT patchset tested on top of latest successful build
b94a17d13fb5e03bbc7ef50ce88352b37ad06c85 tests/psr: Don't strcmp CRCs that are not NULL terminated.
with latest DRM-Tip kernel build CI_DRM_3124
e0e308721fd2 drm-tip: 2017y-09m-22d-13h-31m-38s UTC integration manifest
Test chamelium:
Subgroup dp-crc-fast:
pass -> FAIL (fi-kbl-7500u) fdo#102514
Test gem_ringfill:
Subgroup basic-default-hang:
dmesg-warn -> PASS (fi-pnv-d510) fdo#101600
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
fail -> PASS (fi-snb-2600) fdo#100215 +1
Test kms_force_connector_basic:
Subgroup force-connector-state:
pass -> SKIP (fi-ivb-3520m)
Subgroup force-edid:
pass -> SKIP (fi-ivb-3520m)
Subgroup force-load-detect:
pass -> SKIP (fi-ivb-3520m)
Subgroup prune-stale-modes:
pass -> SKIP (fi-ivb-3520m)
Test drv_module_reload:
Subgroup basic-no-display:
dmesg-warn -> PASS (fi-glk-1) fdo#102777
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#102777 https://bugs.freedesktop.org/show_bug.cgi?id=102777
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:440s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:472s
fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:416s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:523s
fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:275s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:508s
fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:502s
fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:506s
fi-cfl-s total:289 pass:223 dwarn:34 dfail:0 fail:0 skip:32 time:541s
fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:419s
fi-glk-1 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:569s
fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:430s
fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:407s
fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:438s
fi-ivb-3520m total:289 pass:257 dwarn:0 dfail:0 fail:0 skip:32 time:487s
fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:467s
fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:471s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:586s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:597s
fi-pnv-d510 total:289 pass:224 dwarn:0 dfail:0 fail:0 skip:65 time:541s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:451s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:757s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:496s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:471s
fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:576s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:1 skip:39 time:421s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_242/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-25 10:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-22 12:34 [PATCH i-g-t] tests/kms_frontbuffer_tracking: Try harder to collect CRC's Mika Kahola
2017-09-22 15:25 ` Rodrigo Vivi
2017-09-25 10:18 ` Mika Kahola
2017-09-22 16:15 ` ✗ Fi.CI.BAT: warning for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox