From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [RFC 1/2] drm/i915/uc: Move uC related types into dedicated header
Date: Wed, 27 Sep 2017 12:51:24 +0300 [thread overview]
Message-ID: <1506505884.5505.33.camel@linux.intel.com> (raw)
In-Reply-To: <20170926164827.38516-1-michal.wajdeczko@intel.com>
On Tue, 2017-09-26 at 16:48 +0000, Michal Wajdeczko wrote:
> In old header structure we were mixing type definitions and
> declarations that prevent us from exposing some functions
> as inline. Lets try to fix that.
>
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
This is a nice improvement. I see Sagar already provided detailed
review, so please address that (it's always good idea to reduce the
amount of forward declarations). Overall, this is:
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-09-27 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 16:48 [RFC 1/2] drm/i915/uc: Move uC related types into dedicated header Michal Wajdeczko
2017-09-26 16:48 ` [RFC 2/2] drm/i915: Make intel_guc_wopcm_size() inline Michal Wajdeczko
2017-09-27 6:36 ` Sagar Arun Kamble
2017-09-26 17:53 ` ✓ Fi.CI.BAT: success for series starting with [RFC,1/2] drm/i915/uc: Move uC related types into dedicated header Patchwork
2017-09-27 2:48 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-09-27 7:22 ` [RFC 1/2] " Sagar Arun Kamble
2017-09-27 10:58 ` Michal Wajdeczko
2017-09-27 9:51 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506505884.5505.33.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox