From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't mix inline functions with declarations
Date: Wed, 27 Sep 2017 12:57:02 +0300 [thread overview]
Message-ID: <1506506222.5505.39.camel@linux.intel.com> (raw)
In-Reply-To: <20170926143723.49692-1-michal.wajdeczko@intel.com>
On Tue, 2017-09-26 at 14:37 +0000, Michal Wajdeczko wrote:
> We group function forward declarations by file. There is no
> reason to mix these declarations with our unline functions.
I'd rather like to avoid these megaheaders completely, so that
intel_uc.h would be a base header with common structs and stuff and
intel_guc.h and intel_huc.h introduce the functions and stuff which is
then implemented by their respective ".c" files.
The files are still relatively easy, so the earlier it's done, the less
pain there should be.
Then, when the megaheader is broken, the functions should be in natural
order, regardless of being inline or not (that's a volatile thing, and
may change between kernel versions).
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-09-27 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 14:37 [PATCH] drm/i915: Don't mix inline functions with declarations Michal Wajdeczko
2017-09-26 14:46 ` Chris Wilson
2017-09-26 15:59 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-09-27 9:57 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506506222.5505.39.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox