From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/2] drm/i915/uc: Move uC related types into dedicated header
Date: Wed, 27 Sep 2017 14:36:28 +0300 [thread overview]
Message-ID: <1506512188.5505.49.camel@linux.intel.com> (raw)
In-Reply-To: <20170927112252.27660-1-michal.wajdeczko@intel.com>
On Wed, 2017-09-27 at 11:22 +0000, Michal Wajdeczko wrote:
> In old header structure we were mixing type definitions and
> declarations that prevent us from exposing some functions
> as inline. Lets try to fix that.
>
> v2: keep old order of the structs, pull fwif.h (Sagar)
>
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Like I mentioned in the other patch, lets make future ourselves life
easier and take this cleanup further;
intel_uc.{c,h}
intel_guc.{c,h} .h includes "intel_uc.h"
intel_huc.{c,h} ditto
intel_guc_ct.h includes "intel_guc.h"
That way we're not driving ourselves towards the spaghetti insanity
that i915_drv.h is currently. Aka. move a declaration, spend hours
fixing the ordering of things.
Regards, Joonas
PS. Free beer offered for the one to first remove all "filename.c"
sections from i915_drv.h
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-27 11:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 11:22 [PATCH v2 1/2] drm/i915/uc: Move uC related types into dedicated header Michal Wajdeczko
2017-09-27 11:22 ` [PATCH v2 2/2] drm/i915: Make intel_guc_wopcm_size() inline Michal Wajdeczko
2017-09-27 14:44 ` Sagar Arun Kamble
2017-09-29 9:12 ` Joonas Lahtinen
2017-09-27 11:36 ` Joonas Lahtinen [this message]
2017-09-29 10:37 ` [PATCH v2 1/2] drm/i915/uc: Move uC related types into dedicated header Joonas Lahtinen
2017-09-29 12:48 ` Michal Wajdeczko
2017-09-27 11:45 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] " Patchwork
2017-09-27 14:51 ` [PATCH v2 1/2] " Sagar Arun Kamble
2017-09-27 14:59 ` ✓ Fi.CI.IGT: success for series starting with [v2,1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506512188.5505.49.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox