From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm/i915: Make intel_guc_wopcm_size() inline
Date: Fri, 29 Sep 2017 12:12:01 +0300 [thread overview]
Message-ID: <1506676321.4729.34.camel@linux.intel.com> (raw)
In-Reply-To: <20170927112252.27660-2-michal.wajdeczko@intel.com>
On Wed, 2017-09-27 at 11:22 +0000, Michal Wajdeczko wrote:
> While here fix param and var types to match new naming rules.
>
> v2: update names and commit message (Sagar)
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Generally, when the function ends up being used only from single .c
file, you may drop the intel_ prefix and just have it as a private
inline.
So in intel_uc.c as "guc_wopcm_size".
We should try to have the related code in same files and avoid having
functions in the .h files to the extent we can. For example here this
is very much an implementation detail.
When moved there with the rename, this is;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-29 9:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 11:22 [PATCH v2 1/2] drm/i915/uc: Move uC related types into dedicated header Michal Wajdeczko
2017-09-27 11:22 ` [PATCH v2 2/2] drm/i915: Make intel_guc_wopcm_size() inline Michal Wajdeczko
2017-09-27 14:44 ` Sagar Arun Kamble
2017-09-29 9:12 ` Joonas Lahtinen [this message]
2017-09-27 11:36 ` [PATCH v2 1/2] drm/i915/uc: Move uC related types into dedicated header Joonas Lahtinen
2017-09-29 10:37 ` Joonas Lahtinen
2017-09-29 12:48 ` Michal Wajdeczko
2017-09-27 11:45 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] " Patchwork
2017-09-27 14:51 ` [PATCH v2 1/2] " Sagar Arun Kamble
2017-09-27 14:59 ` ✓ Fi.CI.IGT: success for series starting with [v2,1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506676321.4729.34.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox