From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/selftests: Replace wmb() with i915_gem_chipset_flush()
Date: Fri, 29 Sep 2017 12:31:22 +0300 [thread overview]
Message-ID: <1506677482.4729.37.camel@linux.intel.com> (raw)
In-Reply-To: <20170926153409.7928-1-chris@chris-wilson.co.uk>
On Tue, 2017-09-26 at 16:34 +0100, Chris Wilson wrote:
> Currently, we are being fairly lazy and only using a wmb() following an
> update to an active batch. Previously, we have found that to be
> insufficient to ensure that a write from the CPU reaches memory in a
> timely fashion, and in some caches we may need to flush a chipset cache.
> To that end, we have i915_gem_chipset_flush() so use it.
>
> Suggested-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-29 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 15:34 [PATCH] drm/i915/selftests: Replace wmb() with i915_gem_chipset_flush() Chris Wilson
2017-09-26 16:41 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-27 0:15 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-09-29 9:31 ` Joonas Lahtinen [this message]
2017-09-29 10:29 ` [PATCH] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506677482.4729.37.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox