From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [RFC PATCH v2 1/5] drm/i915: expose helper mapping exec flag engine to intel_engine_cs
Date: Fri, 29 Sep 2017 14:09:37 +0300 [thread overview]
Message-ID: <1506683377.4729.45.camel@linux.intel.com> (raw)
In-Reply-To: <20170922151057.24782-2-lionel.g.landwerlin@intel.com>
On Fri, 2017-09-22 at 16:10 +0100, Lionel Landwerlin wrote:
> This function will be used later by the per (context,engine) power
> programming interface.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 3 +++
> drivers/gpu/drm/i915/i915_gem_execbuffer.c | 18 +++++++++---------
> 2 files changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index f5d0e816008d..60c63f141a47 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -3380,6 +3380,9 @@ int i915_gem_set_domain_ioctl(struct drm_device *dev, void *data,
> struct drm_file *file_priv);
> int i915_gem_sw_finish_ioctl(struct drm_device *dev, void *data,
> struct drm_file *file_priv);
> +struct intel_engine_cs *i915_gem_engine_from_flags(struct drm_i915_private *dev_priv,
May wanna cut before function name here, too, to keep the readability.
Also, why would i915_select_engine be a bad name?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-29 11:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 15:10 [RFC PATCH v2 0/5] drm/i915: enable userspace to program slice/subslice programming Lionel Landwerlin
2017-09-22 15:10 ` [RFC PATCH v2 1/5] drm/i915: expose helper mapping exec flag engine to intel_engine_cs Lionel Landwerlin
2017-09-29 11:09 ` Joonas Lahtinen [this message]
2017-09-22 15:10 ` [RFC PATCH v2 2/5] drm/i915: Record both min/max eu_per_subslice in sseu_dev_info Lionel Landwerlin
2017-09-22 15:10 ` [RFC PATCH v2 3/5] drm/i915: Program RPCS for Broadwell Lionel Landwerlin
2017-09-22 15:10 ` [RFC PATCH v2 4/5] drm/i915: Record the sseu configuration per-context & engine Lionel Landwerlin
2017-09-29 11:18 ` Joonas Lahtinen
2017-09-22 15:10 ` [RFC PATCH v2 5/5] drm/i915: Expose RPCS (SSEU) configuration to userspace Lionel Landwerlin
2017-10-05 11:57 ` Tvrtko Ursulin
2017-10-05 13:24 ` Lionel Landwerlin
2017-10-05 15:17 ` Tvrtko Ursulin
2017-09-22 15:33 ` ✓ Fi.CI.BAT: success for drm/i915: enable userspace to program slice/subslice programming (rev2) Patchwork
2017-09-22 20:41 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-09-29 11:20 ` [RFC PATCH v2 0/5] drm/i915: enable userspace to program slice/subslice programming Joonas Lahtinen
2017-09-29 11:33 ` Lionel Landwerlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506683377.4729.45.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox