From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Weinan Li <weinan.z.li@intel.com>,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm/i915: enable to read CSB and CSB write pointer from HWSP in GVT-g VM
Date: Mon, 02 Oct 2017 13:03:30 +0300 [thread overview]
Message-ID: <1506938610.6755.42.camel@linux.intel.com> (raw)
In-Reply-To: <1506751032-7250-3-git-send-email-weinan.z.li@intel.com>
On Sat, 2017-09-30 at 13:57 +0800, Weinan Li wrote:
> Let GVT-g VM read the CSB and CSB write pointer from virtual HWSP, not all
> the host support this feature, need to check the BIT(3) of caps in PVINFO.
>
> Signed-off-by: Weinan Li <weinan.z.li@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
<SNIP>
> @@ -396,6 +393,12 @@ static bool csb_force_mmio(struct drm_i915_private *i915)
> if (intel_vtd_active())
> return true;
>
> + /* GVT emulation depends upon host kernel implementation, check
> + * support capbility by reading PV INFO before access HWSP.
> + */
The comment can be dropped completely, the code is self-descriptive.
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -722,7 +722,12 @@ static void intel_lrc_irq_handler(unsigned long data)
> &engine->status_page.page_addr[I915_HWS_CSB_BUF0_INDEX];
> unsigned int head, tail;
>
> - /* However GVT emulation depends upon intercepting CSB mmio */
> + /* However GVT-g emulation depends upon host kernel
> + * implementation, need to check support capbility by reading PV
> + * INFO before access HWSP. Beside from this, another special
> + * configuration may also need to force use mmio, like IOMMU
> + * enabled.
> + */
s/capbility/capability/ and please rephrase this to be a kerneldoc for
csb_use_mmio at the declaration.
> if (unlikely(execlists->csb_use_mmio)) {
> buf = (u32 * __force)
> (dev_priv->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_BUF_LO(engine, 0)));
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-02 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 5:57 [PATCH v2 0/2] enable virtual HWSP in GVT-g Weinan Li
2017-09-30 5:57 ` [PATCH v2 1/2] drm/i915/gvt: update CSB and CSB write pointer in virtual HWSP Weinan Li
2017-09-30 5:57 ` [PATCH v2 2/2] drm/i915: enable to read CSB and CSB write pointer from HWSP in GVT-g VM Weinan Li
2017-10-02 10:03 ` Joonas Lahtinen [this message]
2017-10-02 10:23 ` Chris Wilson
2017-10-02 11:37 ` Joonas Lahtinen
2017-10-09 3:02 ` Li, Weinan Z
2017-09-30 6:06 ` ✗ Fi.CI.BAT: failure for enable virtual HWSP in GVT-g Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506938610.6755.42.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=weinan.z.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox