Re: [PATCH v2 3/6] drm/i915/uc: Create intel_uc_init_mmio

[Joonas Lahtinen <joonas.lahtinen@linux.intel.com>]

On Mon, 2017-10-02 at 14:01 +0000, Michal Wajdeczko wrote:
> From: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> 
> This patch adds new function intel_uc_init_mmio which will initialize
> MMIO access related variables prior to uc load/init.
> 
> v2: Removed unnecessary export of guc_send_init_regs. Created
> intel_uc_init_mmio that currently wraps guc_init_send_regs. (Michal)
> 
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

<SNIP>

> +++ b/drivers/gpu/drm/i915/intel_uc.c
> @@ -137,6 +137,11 @@ static void guc_init_send_regs(struct intel_guc *guc)
>  	guc->send_regs.fw_domains = fw_domains;
>  }
>  

Please add kerneldoc.

> +void intel_uc_init_mmio(struct drm_i915_private *dev_priv)
> +{
> +	guc_init_send_regs(&dev_priv->guc);
> +}

<SNIP>

> +++ b/drivers/gpu/drm/i915/intel_uc.h
> @@ -137,6 +137,7 @@ struct intel_huc {
>  /* intel_uc.c */

I think this comment could have been dropped when moving to a separate
file :)

>  void intel_uc_sanitize_options(struct drm_i915_private *dev_priv);
>  void intel_uc_init_early(struct drm_i915_private *dev_priv);
> +void intel_uc_init_mmio(struct drm_i915_private *dev_priv);
>  void intel_uc_init_fw(struct drm_i915_private *dev_priv);
>  void intel_uc_fini_fw(struct drm_i915_private *dev_priv);
>  int intel_uc_init_hw(struct drm_i915_private *dev_priv);

This should really be after init_mmio to clarify the calling order, so
you may want to reorder this when doing the code motion. It should not
be possible to cause whitespace or compilation issues, so it's OK.

With the kerneldoc, this is;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx