* [PATCH] drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
@ 2017-10-02 20:31 Oscar Mateo
2017-10-02 21:10 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Oscar Mateo @ 2017-10-02 20:31 UTC (permalink / raw)
To: intel-gfx; +Cc: Ben Widawsky, Rodrigo Vivi
BSpec indicates exactly 16750 DWORDs (17 pages), plus one page for PPHWSP.
Suggested-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Fixes: 7fd0b1a ("drm/i915/cnl: Add Gen10 LRC size")
Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Ben Widawsky <ben@bwidawsk.net>
---
drivers/gpu/drm/i915/intel_engine_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index a28e2a8..febbb91 100644
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -39,7 +39,7 @@
#define GEN8_LR_CONTEXT_RENDER_SIZE (20 * PAGE_SIZE)
#define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE)
-#define GEN10_LR_CONTEXT_RENDER_SIZE (19 * PAGE_SIZE)
+#define GEN10_LR_CONTEXT_RENDER_SIZE (18 * PAGE_SIZE)
#define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE)
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
2017-10-02 20:31 [PATCH] drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size Oscar Mateo
@ 2017-10-02 21:10 ` Patchwork
2017-10-02 22:31 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-03 12:25 ` [PATCH] " Joonas Lahtinen
2 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2017-10-02 21:10 UTC (permalink / raw)
To: Oscar Mateo; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
URL : https://patchwork.freedesktop.org/series/31284/
State : success
== Summary ==
Series 31284v1 drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
https://patchwork.freedesktop.org/api/1.0/series/31284/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
dmesg-warn -> PASS (fi-cfl-s) fdo#103026
fdo#103026 https://bugs.freedesktop.org/show_bug.cgi?id=103026
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:453s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:472s
fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:398s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:570s
fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:290s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:525s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:534s
fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:541s
fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:532s
fi-cfl-s total:289 pass:257 dwarn:0 dfail:0 fail:0 skip:32 time:568s
fi-cnl-y total:289 pass:261 dwarn:1 dfail:0 fail:0 skip:27 time:617s
fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:441s
fi-glk-1 total:289 pass:258 dwarn:3 dfail:0 fail:0 skip:28 time:595s
fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:439s
fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:418s
fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:461s
fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:505s
fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:474s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:505s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:575s
fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:490s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:585s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:471s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:536s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:512s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:470s
fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:583s
fi-snb-2600 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:435s
fi-pnv-d510 failed to connect after reboot
14f3207683e165f826d0e5861944fc6f39e8e20f drm-tip: 2017y-10m-02d-20h-23m-38s UTC integration manifest
1f2eb31bd161 drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5872/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
2017-10-02 20:31 [PATCH] drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size Oscar Mateo
2017-10-02 21:10 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-02 22:31 ` Patchwork
2017-10-03 12:25 ` [PATCH] " Joonas Lahtinen
2 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2017-10-02 22:31 UTC (permalink / raw)
To: Oscar Mateo; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
URL : https://patchwork.freedesktop.org/series/31284/
State : success
== Summary ==
Test perf:
Subgroup polling:
pass -> FAIL (shard-hsw) fdo#102252 +1
Test kms_flip:
Subgroup wf_vblank-vs-dpms-interruptible:
dmesg-warn -> PASS (shard-hsw)
Subgroup modeset-vs-vblank-race:
pass -> DMESG-WARN (shard-hsw) fdo#102919
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102919 https://bugs.freedesktop.org/show_bug.cgi?id=102919
shard-hsw total:2429 pass:1330 dwarn:8 dfail:0 fail:8 skip:1083 time:10059s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5872/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
2017-10-02 20:31 [PATCH] drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size Oscar Mateo
2017-10-02 21:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-02 22:31 ` ✓ Fi.CI.IGT: " Patchwork
@ 2017-10-03 12:25 ` Joonas Lahtinen
2017-10-03 15:46 ` Oscar Mateo
2 siblings, 1 reply; 9+ messages in thread
From: Joonas Lahtinen @ 2017-10-03 12:25 UTC (permalink / raw)
To: Oscar Mateo, intel-gfx; +Cc: Ben Widawsky, Rodrigo Vivi
On Mon, 2017-10-02 at 13:31 -0700, Oscar Mateo wrote:
> BSpec indicates exactly 16750 DWORDs (17 pages), plus one page for PPHWSP.
Assuming this is;
Bspec: 1383
I'm actually getting 16801 DWORDs by copy-pasting to spreadsheet and
summing up. Are we looking from different places?
Both lead to the same amount of pages, but I'd like the commit message
to be correct for easier double-checking :) With commit message
corrected and the Bspec: tag added (or more correct Bspec: tag
specified), this is;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
2017-10-03 12:25 ` [PATCH] " Joonas Lahtinen
@ 2017-10-03 15:46 ` Oscar Mateo
2017-10-04 10:44 ` Joonas Lahtinen
0 siblings, 1 reply; 9+ messages in thread
From: Oscar Mateo @ 2017-10-03 15:46 UTC (permalink / raw)
To: Joonas Lahtinen, intel-gfx; +Cc: Ben Widawsky, Rodrigo Vivi
On 10/03/2017 05:25 AM, Joonas Lahtinen wrote:
> On Mon, 2017-10-02 at 13:31 -0700, Oscar Mateo wrote:
>> BSpec indicates exactly 16750 DWORDs (17 pages), plus one page for PPHWSP.
> Assuming this is;
>
> Bspec: 1383
>
> I'm actually getting 16801 DWORDs by copy-pasting to spreadsheet and
> summing up. Are we looking from different places?
No, we are looking at the same BSpec page, but you need to filter by
"CNL" (that will remove some fields). Even then, I'm now getting 16752
instead of 16750 (maybe they have updated some tags?).
I'll resend with the BSpec tag, the new count and your RB, if that's OK.
>
> Both lead to the same amount of pages, but I'd like the commit message
> to be correct for easier double-checking :) With commit message
> corrected and the Bspec: tag added (or more correct Bspec: tag
> specified), this is;
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
@ 2017-10-03 15:49 Oscar Mateo
0 siblings, 0 replies; 9+ messages in thread
From: Oscar Mateo @ 2017-10-03 15:49 UTC (permalink / raw)
To: intel-gfx; +Cc: Ben Widawsky, Rodrigo Vivi
BSpec indicates exactly 16752 DWORDs (17 pages), plus one page for PPHWSP.
BSpec: 1383
v2: Update count and add BSpec tag (Joonas)
Suggested-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Fixes: 7fd0b1a ("drm/i915/cnl: Add Gen10 LRC size")
Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Ben Widawsky <ben@bwidawsk.net>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/intel_engine_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index a75f5e8..25ef740 100644
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -39,7 +39,7 @@
#define GEN8_LR_CONTEXT_RENDER_SIZE (20 * PAGE_SIZE)
#define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE)
-#define GEN10_LR_CONTEXT_RENDER_SIZE (19 * PAGE_SIZE)
+#define GEN10_LR_CONTEXT_RENDER_SIZE (18 * PAGE_SIZE)
#define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE)
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
2017-10-03 15:46 ` Oscar Mateo
@ 2017-10-04 10:44 ` Joonas Lahtinen
0 siblings, 0 replies; 9+ messages in thread
From: Joonas Lahtinen @ 2017-10-04 10:44 UTC (permalink / raw)
To: Oscar Mateo, intel-gfx; +Cc: Ben Widawsky, Rodrigo Vivi
On Tue, 2017-10-03 at 08:46 -0700, Oscar Mateo wrote:
>
> On 10/03/2017 05:25 AM, Joonas Lahtinen wrote:
> > On Mon, 2017-10-02 at 13:31 -0700, Oscar Mateo wrote:
> > > BSpec indicates exactly 16750 DWORDs (17 pages), plus one page for PPHWSP.
> >
> > Assuming this is;
> >
> > Bspec: 1383
> >
> > I'm actually getting 16801 DWORDs by copy-pasting to spreadsheet and
> > summing up. Are we looking from different places?
>
> No, we are looking at the same BSpec page, but you need to filter by
> "CNL" (that will remove some fields). Even then, I'm now getting 16752
> instead of 16750 (maybe they have updated some tags?).
> I'll resend with the BSpec tag, the new count and your RB, if that's OK.
Yep, that's fine. Do include a note in the commit message that there
are exclusions of rows in the BSpec table, so when looking back, one is
reminded that copy and paste is not enough :)
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
@ 2017-10-04 15:39 Oscar Mateo
2017-10-05 17:05 ` Chris Wilson
0 siblings, 1 reply; 9+ messages in thread
From: Oscar Mateo @ 2017-10-04 15:39 UTC (permalink / raw)
To: intel-gfx; +Cc: Ben Widawsky, Rodrigo Vivi
BSpec indicates exactly 16752 DWORDs (17 pages), plus one page for PPHWSP. Please
notice that, when looking at the BSpec context image table, the right filter has
to be applied (e.g. "CNL") as some rows are excluded for specific GENs.
BSpec: 1383
v2: Update count and add BSpec tag (Joonas)
v3: Warning about filters in the commit message (Joonas)
Suggested-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Fixes: 7fd0b1a ("drm/i915/cnl: Add Gen10 LRC size")
Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Ben Widawsky <ben@bwidawsk.net>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/intel_engine_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index a75f5e8..25ef740 100644
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -39,7 +39,7 @@
#define GEN8_LR_CONTEXT_RENDER_SIZE (20 * PAGE_SIZE)
#define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE)
-#define GEN10_LR_CONTEXT_RENDER_SIZE (19 * PAGE_SIZE)
+#define GEN10_LR_CONTEXT_RENDER_SIZE (18 * PAGE_SIZE)
#define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE)
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size
2017-10-04 15:39 Oscar Mateo
@ 2017-10-05 17:05 ` Chris Wilson
0 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2017-10-05 17:05 UTC (permalink / raw)
To: Oscar Mateo, intel-gfx; +Cc: Ben Widawsky, Rodrigo Vivi
Quoting Oscar Mateo (2017-10-04 16:39:52)
> BSpec indicates exactly 16752 DWORDs (17 pages), plus one page for PPHWSP. Please
> notice that, when looking at the BSpec context image table, the right filter has
> to be applied (e.g. "CNL") as some rows are excluded for specific GENs.
>
> BSpec: 1383
>
> v2: Update count and add BSpec tag (Joonas)
> v3: Warning about filters in the commit message (Joonas)
>
> Suggested-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Fixes: 7fd0b1a ("drm/i915/cnl: Add Gen10 LRC size")
> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
And pushed. Thanks for the patch and review,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-10-05 17:06 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-02 20:31 [PATCH] drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size Oscar Mateo
2017-10-02 21:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-02 22:31 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-03 12:25 ` [PATCH] " Joonas Lahtinen
2017-10-03 15:46 ` Oscar Mateo
2017-10-04 10:44 ` Joonas Lahtinen
-- strict thread matches above, loose matches on Subject: below --
2017-10-03 15:49 Oscar Mateo
2017-10-04 15:39 Oscar Mateo
2017-10-05 17:05 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox