From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt] lib: Report the error from __gem_create()
Date: Tue, 03 Oct 2017 15:37:21 +0300 [thread overview]
Message-ID: <1507034241.4728.53.camel@linux.intel.com> (raw)
In-Reply-To: <20171003115059.27469-1-chris@chris-wilson.co.uk>
On Tue, 2017-10-03 at 12:50 +0100, Chris Wilson wrote:
> We have two style of ioctl wrappers. The principle interface does error
> checking on behalf of the caller (to avoid having lots of repetitious
> code in each test), and for the few cases where the error is important
> for the test, we also expose a double underscore version. Fix up
> __gem_create() to follow this pattern and report the negative error code
> returned by the kernel.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Oh, there were that few users...
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-03 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 11:50 [PATCH igt] lib: Report the error from __gem_create() Chris Wilson
2017-10-03 12:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-03 12:37 ` Joonas Lahtinen [this message]
2017-10-03 13:47 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-10-03 13:52 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507034241.4728.53.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox