From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Paul Subject: Re: [PATCH v3] drm/i915/mst: Use MST sideband message transactions for dpms control Date: Wed, 04 Oct 2017 15:03:22 -0400 Message-ID: <1507143802.8401.5.camel@redhat.com> References: <20170913200615.9351-1-dhinakaran.pandiyan@intel.com> <20171003142211.860-1-jani.nikula@intel.com> <87shez47v8.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 49FE06E74F for ; Wed, 4 Oct 2017 19:03:24 +0000 (UTC) In-Reply-To: <87shez47v8.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Dhinakaran Pandiyan , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE3LTEwLTA0IGF0IDExOjQ3ICswMzAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiBP biBUdWUsIDAzIE9jdCAyMDE3LCBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPiB3 cm90ZToKPiA+IEZyb206IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5A aW50ZWwuY29tPgo+ID4gCj4gPiBVc2UgdGhlIFBPV0VSX0RPV05fUEhZIGFuZCBQT1dFUl9VUF9Q SFkgc2lkZWJhbmQgbWVzc2FnZSB0cmFuc2FjdGlvbnMgdG8KPiA+IHNldCBwb3dlciBzdGF0ZXMg Zm9yIGRvd25zdHJlYW0gc2lua3MuIEFwYXJ0IGZyb20gZ2l2aW5nIHVzIHRoZSBhYmlsaXR5Cj4g PiB0byBzZXQgcG93ZXIgc3RhdGUgZm9yIGluZGl2aWR1YWwgc2lua3MsIHRoaXMgZml4ZXMgdGhl IGJlbG93IHRlc3QgZm9yCj4gPiBtZS4KPiA+IAo+ID4gJCB4cmFuZHIgLS1kaXNwbGF5IDowIC0t b3V0cHV0IERQLTItMi04IC0tb2ZmCj4gPiAkIHhyYW5kciAtLWRpc3BsYXkgOjAgLS1vdXRwdXQg RFAtMi0yLTEgLS1vZmYKPiA+ICQgeHJhbmRyIC0tZGlzcGxheSA6MCAtLW91dHB1dCBEUC0yLTIt OCAtLWF1dG8gI0JsYWNrIHNjcmVlbgo+ID4gJCB4cmFuZHIgLS1kaXNwbGF5IDowIC0tb3V0cHV0 IERQLTItMi0xIC0tYXV0bwo+ID4gCj4gPiB2MjogTW9kaWZ5IGFuZCBkb2N1bWVudCB0aGUgZHBt cyBhbmQgcG9ydCBkaXNhYmxlIG9yZGVyIChWaWxsZSkKPiA+ICAgICBBZGQgY29tbWVudCBleHBs YWluaW5nIGlzX21zdCA9ICFjcnRjX3N0YXRlIGVxdWl2YWxlbmNlKFZpbGxlLAo+ID4gTWFhcnRl bikKPiA+IAo+ID4gdjMgYnkgSmFuaTogcmViYXNlCj4gPiAKPiA+IFJlZmVyZW5jZXM6IGh0dHBz Oi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTkwOTYzCj4gPiBSZWZlcmVu Y2VzOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD04ODEyNAo+ ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g PiBDYzogTHl1ZGUgPGx5dWRlQHJlZGhhdC5jb20+Cj4gPiBDYzogTWFhcnRlbiBMYW5raG9yc3Qg PG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+IFJldmlld2VkLWJ5OiBMeXVk ZSBQYXVsIDxseXVkZUByZWRoYXQuY29tPgo+ID4gQWNrZWQtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0 IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gCj4gTHl1ZGUsIE1hYXJ0ZW4s IGNhbiB5b3UgY29uZmlybSB5b3VyIHJiL2FjayBvbiBteSByZWJhc2UgcGxlYXNlPwpMb29rcyBn b29kIHRvIG1lCj4gCj4gQlIsCj4gSmFuaS4KPiAKPiAKPiA+IFNpZ25lZC1vZmYtYnk6IERoaW5h a2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+ID4gU2lnbmVk LW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiA+IC0tLQo+ID4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jICAgIHwgMTggKysrKysrKysrKysrKyst LS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbXN0LmMgfCAxMCArKysrKysr Ky0tCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygt KQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMK PiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+IGluZGV4IDY1ZjRiNjc4 Njc5MS4uNTExYWE2MGUwMTc2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGRpLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4g PiBAQCAtMjE2Miw3ICsyMTYyLDggQEAgc3RhdGljIHZvaWQgaW50ZWxfZGRpX3ByZV9lbmFibGVf ZHAoc3RydWN0Cj4gPiBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4gIAkJaW50ZWxfcHJlcGFy ZV9kcF9kZGlfYnVmZmVycyhlbmNvZGVyKTsKPiA+ICAKPiA+ICAJaW50ZWxfZGRpX2luaXRfZHBf YnVmX3JlZyhlbmNvZGVyKTsKPiA+IC0JaW50ZWxfZHBfc2lua19kcG1zKGludGVsX2RwLCBEUk1f TU9ERV9EUE1TX09OKTsKPiA+ICsJaWYgKCFsaW5rX21zdCkKPiA+ICsJCWludGVsX2RwX3Npbmtf ZHBtcyhpbnRlbF9kcCwgRFJNX01PREVfRFBNU19PTik7Cj4gPiAgCWludGVsX2RwX3N0YXJ0X2xp bmtfdHJhaW4oaW50ZWxfZHApOwo+ID4gIAlpZiAocG9ydCAhPSBQT1JUX0EgfHwgSU5URUxfR0VO KGRldl9wcml2KSA+PSA5KQo+ID4gIAkJaW50ZWxfZHBfc3RvcF9saW5rX3RyYWluKGludGVsX2Rw KTsKPiA+IEBAIC0yMjM2LDEyICsyMjM3LDIxIEBAIHN0YXRpYyB2b2lkIGludGVsX2RkaV9wb3N0 X2Rpc2FibGUoc3RydWN0Cj4gPiBpbnRlbF9lbmNvZGVyICppbnRlbF9lbmNvZGVyLAo+ID4gIAl1 aW50MzJfdCB2YWw7Cj4gPiAgCWJvb2wgd2FpdCA9IGZhbHNlOwo+ID4gIAo+ID4gLQkvKiBvbGRf Y3J0Y19zdGF0ZSBhbmQgb2xkX2Nvbm5fc3RhdGUgYXJlIE5VTEwgd2hlbiBjYWxsZWQgZnJvbQo+ ID4gRFBfTVNUICovCj4gPiAtCj4gPiAgCWlmICh0eXBlID09IElOVEVMX09VVFBVVF9EUCB8fCB0 eXBlID09IElOVEVMX09VVFBVVF9FRFApIHsKPiA+ICsJCS8qCj4gPiArCQkgKiBvbGRfY3J0Y19z dGF0ZSBhbmQgb2xkX2Nvbm5fc3RhdGUgYXJlIE5VTEwgd2hlbiBjYWxsZWQKPiA+IGZyb20KPiA+ ICsJCSAqIERQX01TVC4gVGhlIG1haW4gY29ubmVjdG9yIGFzc29jaWF0ZWQgd2l0aCB0aGlzIHBv cnQKPiA+IGlzIG5ldmVyCj4gPiArCQkgKiBib3VuZCB0byBhIGNydGMgZm9yIE1TVC4KPiA+ICsJ CSAqLwo+ID4gKwkJYm9vbCBpc19tc3QgPSAhb2xkX2NydGNfc3RhdGU7Cj4gPiAgCQlzdHJ1Y3Qg aW50ZWxfZHAgKmludGVsX2RwID0gZW5jX3RvX2ludGVsX2RwKGVuY29kZXIpOwo+ID4gIAo+ID4g LQkJaW50ZWxfZHBfc2lua19kcG1zKGludGVsX2RwLCBEUk1fTU9ERV9EUE1TX09GRik7Cj4gPiAr CQkvKgo+ID4gKwkJICogUG93ZXIgZG93biBzaW5rIGJlZm9yZSBkaXNhYmxpbmcgdGhlIHBvcnQs IG90aGVyd2lzZQo+ID4gd2UgZW5kCj4gPiArCQkgKiB1cCBnZXR0aW5nIGludGVycnVwdHMgZnJv bSB0aGUgc2luayBvbiBkZXRlY3RpbmcgbGluawo+ID4gbG9zcy4KPiA+ICsJCSAqLwo+ID4gKwkJ aWYgKCFpc19tc3QpCj4gPiArCQkJaW50ZWxfZHBfc2lua19kcG1zKGludGVsX2RwLCBEUk1fTU9E RV9EUE1TX09GRik7Cj4gPiAgCX0KPiA+ICAKPiA+ICAJdmFsID0gSTkxNV9SRUFEKERESV9CVUZf Q1RMKHBvcnQpKTsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cF9tc3QuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYwo+ID4gaW5k ZXggOWEzOTZmNDgzZjhiLi4zYzEzMWUyNTQ0Y2YgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHBfbXN0LmMKPiA+IEBAIC0xNjIsMTQgKzE2MiwxOSBAQCBzdGF0aWMgdm9pZCBpbnRl bF9tc3RfcG9zdF9kaXNhYmxlX2RwKHN0cnVjdAo+ID4gaW50ZWxfZW5jb2RlciAqZW5jb2RlciwK PiA+ICAKPiA+ICAJZHJtX2RwX21zdF9kZWFsbG9jYXRlX3ZjcGkoJmludGVsX2RwLT5tc3RfbWdy LCBjb25uZWN0b3ItPnBvcnQpOwo+ID4gIAo+ID4gKwkvKgo+ID4gKwkgKiBQb3dlciBkb3duIG1z dCBwYXRoIGJlZm9yZSBkaXNhYmxpbmcgdGhlIHBvcnQsIG90aGVyd2lzZSB3ZQo+ID4gZW5kCj4g PiArCSAqIHVwIGdldHRpbmcgaW50ZXJydXB0cyBmcm9tIHRoZSBzaW5rIHVwb24gZGV0ZWN0aW5n IGxpbmsgbG9zcy4KPiA+ICsJICovCj4gPiArCWRybV9kcF9zZW5kX3Bvd2VyX3VwZG93bl9waHko JmludGVsX2RwLT5tc3RfbWdyLCBjb25uZWN0b3ItPnBvcnQsCj4gPiArCQkJCSAgICAgZmFsc2Up Owo+ID4gKwo+ID4gIAlpbnRlbF9kcC0+YWN0aXZlX21zdF9saW5rcy0tOwo+ID4gIAo+ID4gIAlp bnRlbF9tc3QtPmNvbm5lY3RvciA9IE5VTEw7Cj4gPiAgCWlmIChpbnRlbF9kcC0+YWN0aXZlX21z dF9saW5rcyA9PSAwKSB7Cj4gPiAgCQlpbnRlbF9kaWdfcG9ydC0+YmFzZS5wb3N0X2Rpc2FibGUo JmludGVsX2RpZ19wb3J0LT5iYXNlLAo+ID4gIAkJCQkJCSAgTlVMTCwgTlVMTCk7Cj4gPiAtCj4g PiAtCQlpbnRlbF9kcF9zaW5rX2RwbXMoaW50ZWxfZHAsIERSTV9NT0RFX0RQTVNfT0ZGKTsKPiA+ ICAJfQo+ID4gIAlEUk1fREVCVUdfS01TKCJhY3RpdmUgbGlua3MgJWRcbiIsIGludGVsX2RwLT5h Y3RpdmVfbXN0X2xpbmtzKTsKPiA+ICB9Cj4gPiBAQCAtMTk2LDYgKzIwMSw3IEBAIHN0YXRpYyB2 b2lkIGludGVsX21zdF9wcmVfZW5hYmxlX2RwKHN0cnVjdAo+ID4gaW50ZWxfZW5jb2RlciAqZW5j b2RlciwKPiA+ICAKPiA+ICAJRFJNX0RFQlVHX0tNUygiYWN0aXZlIGxpbmtzICVkXG4iLCBpbnRl bF9kcC0+YWN0aXZlX21zdF9saW5rcyk7Cj4gPiAgCj4gPiArCWRybV9kcF9zZW5kX3Bvd2VyX3Vw ZG93bl9waHkoJmludGVsX2RwLT5tc3RfbWdyLCBjb25uZWN0b3ItPnBvcnQsIAo+ID4gdHJ1ZSk7 Cj4gPiAgCWlmIChpbnRlbF9kcC0+YWN0aXZlX21zdF9saW5rcyA9PSAwKQo+ID4gIAkJaW50ZWxf ZGlnX3BvcnQtPmJhc2UucHJlX2VuYWJsZSgmaW50ZWxfZGlnX3BvcnQtPmJhc2UsCj4gPiAgCQkJ CQkJcGlwZV9jb25maWcsIE5VTEwpOwo+IAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK