From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Remove early invocations of i915_engines_cleanup()
Date: Mon, 09 Oct 2017 12:24:32 +0300 [thread overview]
Message-ID: <1507541072.6297.4.camel@linux.intel.com> (raw)
In-Reply-To: <20171007085659.2626-2-chris@chris-wilson.co.uk>
On Sat, 2017-10-07 at 09:56 +0100, Chris Wilson wrote:
> Engines are now only allocated during init_mmio, so we can forgo
> iterating over the empty list and calling kfree(NULL) prior to
> intel_engines_init_mmio().
>
> Fixes: 63ffbcdadcf2 ("drm/i915: Sanitize engine context sizes")
This use of the tag would be correct according to "Fixes:" part of:
https://www.kernel.org/doc/html/v4.13/process/submitting-patches.html#r
eviewer-s-statement-of-oversight
But it definitely says "bug" in there, so the other more stylistic
issues "Impact: None", indeed should not get a Fixes: tag.
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-09 9:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 8:56 [PATCH 1/2] drm/i915: Split uncore init into vfunc setup and mmio setup Chris Wilson
2017-10-07 8:56 ` [PATCH 2/2] drm/i915: Remove early invocations of i915_engines_cleanup() Chris Wilson
2017-10-09 9:24 ` Joonas Lahtinen [this message]
2017-10-07 9:19 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Split uncore init into vfunc setup and mmio setup Patchwork
2017-10-07 10:21 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-10-07 11:14 ` [PATCH 1/2] " Michal Wajdeczko
2017-10-07 15:28 ` Chris Wilson
2017-10-09 9:19 ` Joonas Lahtinen
2017-10-09 9:23 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507541072.6297.4.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox