From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 7/7] drm/i915: Early rejection of mappable GGTT pin attempts for large bo
Date: Mon, 09 Oct 2017 15:26:17 +0300 [thread overview]
Message-ID: <1507551977.6297.29.camel@linux.intel.com> (raw)
In-Reply-To: <20171009084401.29090-7-chris@chris-wilson.co.uk>
On Mon, 2017-10-09 at 09:44 +0100, Chris Wilson wrote:
> Currently, we reject attempting to pin a large bo into the mappable
> aperture, but only after trying to create the vma. Under debug kernels,
> repeatedly creating and freeing that vma for an oversized bo consumes
> one-third of the runtime for pwrite/pread tests is spent on
> kmalloc/kfree tracking. If we move the rejection to before creating that
> vma, we lose some accuracy of checking against the fence_size as opposed
> to object size, though the fence can never be smaller than the object.
> Note that the vma creation itself will reject an attempt to create a vma
> larger than the GTT so we can remove one redundant test.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-09 12:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 8:43 [PATCH 1/7] drm/i915: Pin fence for iomap Chris Wilson
2017-10-09 8:43 ` [PATCH 2/7] drm/i915: Consolidate get_fence with pin_fence Chris Wilson
2017-10-09 10:38 ` Joonas Lahtinen
2017-10-09 8:43 ` [PATCH 3/7] drm/i915: Track user GTT faulting per-vma Chris Wilson
2017-10-09 12:14 ` Joonas Lahtinen
2017-10-09 8:43 ` [PATCH 4/7] drm/i915: Check PIN_NONFAULT overlaps in evict_for_node Chris Wilson
2017-10-09 12:17 ` Joonas Lahtinen
2017-10-09 13:39 ` Chris Wilson
2017-10-09 8:43 ` [PATCH 5/7] drm/i915: Try a minimal attempt to insert the whole object for relocations Chris Wilson
2017-10-09 12:18 ` Joonas Lahtinen
2017-10-09 8:44 ` [PATCH 6/7] drm/i915: Avoid evicting user fault mappable vma for pread/pwrite Chris Wilson
2017-10-09 12:19 ` Joonas Lahtinen
2017-10-09 8:44 ` [PATCH 7/7] drm/i915: Early rejection of mappable GGTT pin attempts for large bo Chris Wilson
2017-10-09 12:26 ` Joonas Lahtinen [this message]
2017-10-09 9:15 ` ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Pin fence for iomap Patchwork
2017-10-09 10:16 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-09 13:51 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507551977.6297.29.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox