From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: s/sg_mask/sg_page_sizes/
Date: Mon, 09 Oct 2017 16:00:56 +0300 [thread overview]
Message-ID: <1507554056.6297.31.camel@linux.intel.com> (raw)
In-Reply-To: <20171009110024.29114-1-matthew.auld@intel.com>
On Mon, 2017-10-09 at 12:00 +0100, Matthew Auld wrote:
> It's a little unclear what the sg_mask actually is, so prefer the more
> meaningful name of sg_page_sizes.
>
> Suggested-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
<SNIP>
> @@ -2489,16 +2489,16 @@ void __i915_gem_object_set_pages(struct drm_i915_gem_object *obj,
> obj->mm.quirked = true;
> }
>
> - GEM_BUG_ON(!sg_mask);
> - obj->mm.page_sizes.phys = sg_mask;
> + GEM_BUG_ON(!sg_page_sizes);
> + obj->mm.page_sizes.phys = sg_page_sizes;
>
> /*
> - * Calculate the supported page-sizes which fit into the given sg_mask.
> - * This will give us the page-sizes which we may be able to use
> - * opportunistically when later inserting into the GTT. For example if
> - * phys=2G, then in theory we should be able to use 1G, 2M, 64K or 4K
> - * pages, although in practice this will depend on a number of other
> - * factors.
> + * Calculate the supported page-sizes which fit into the given
> + * sg_page_sizes. This will give us the page-sizes which we may be able
Double space before "This".
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-09 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 11:00 [PATCH] drm/i915: s/sg_mask/sg_page_sizes/ Matthew Auld
2017-10-09 11:34 ` Chris Wilson
2017-10-09 12:40 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-09 13:00 ` Joonas Lahtinen [this message]
2017-10-09 14:10 ` [PATCH] " Chris Wilson
2017-10-09 16:40 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507554056.6297.31.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox