From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Assert we do not try to expand VMA for hugepage inside GGTT
Date: Mon, 09 Oct 2017 16:03:12 +0300 [thread overview]
Message-ID: <1507554192.6297.32.camel@linux.intel.com> (raw)
In-Reply-To: <20171009092019.20747-1-chris@chris-wilson.co.uk>
On Mon, 2017-10-09 at 10:20 +0100, Chris Wilson wrote:
> We only apply the hugepage PD redirection inside the ppGTT, so during
> i915_vma_insert() we want to exclude the GGTT from the additional
> alignment constraints (thereby avoiding the extra GTT pressure from
> fragmentation). Add an assert to document that intention alongside the
> comment.
>
> v2: After discussion with Matthew, make it a blanket GGTT ban
> (previously we allowed the expansion for appgtt, and so indirectly
> ggtt). There are issues we need to fix before allowing the current
> appgtt to be used with hugepages, and if we do, we probably want more
> care over when to expand/align, as the mappable aperture inside the ggtt
> is precious.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.william.auld@gmail.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Reviewed-by: Matthew Auld <matthew.william.auld@gmail.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-09 13:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-08 13:43 [PATCH 1/3] drm/i915: Assert we do not try to expand VMA for hugepage inside GGTT Chris Wilson
2017-10-08 13:43 ` [PATCH 2/3] drm/i915: Retire after wait-for-idle on evict Chris Wilson
2017-10-08 13:56 ` Chris Wilson
2017-10-08 13:43 ` [PATCH 3/3] drm/i915: Replace manual checking for idleness with active_requests counter Chris Wilson
2017-10-09 8:37 ` Chris Wilson
2017-10-08 14:06 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Assert we do not try to expand VMA for hugepage inside GGTT Patchwork
2017-10-08 15:01 ` [PATCH 1/3] " Matthew Auld
2017-10-09 8:17 ` Chris Wilson
2017-10-08 15:07 ` ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork
2017-10-09 9:20 ` [PATCH v2] " Chris Wilson
2017-10-09 13:03 ` Joonas Lahtinen [this message]
2017-10-09 9:44 ` ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Assert we do not try to expand VMA for hugepage inside GGTT (rev2) Patchwork
2017-10-09 11:05 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507554192.6297.32.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox