From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use execlists_num_ports instead of size of array
Date: Tue, 10 Oct 2017 15:59:24 +0300 [thread overview]
Message-ID: <1507640364.7677.14.camel@linux.intel.com> (raw)
In-Reply-To: <20171010114857.13108-1-mika.kuoppala@intel.com>
On Tue, 2017-10-10 at 14:48 +0300, Mika Kuoppala wrote:
> There is function to tell how many ports we have, so use it.
> We still have direct relationship with array size and port count,
> so no harm was done.
>
> Fixes: 76e70087d360 ("drm/i915: Make execlist port count variable")
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
<SNIP>
> +++ b/drivers/gpu/drm/i915/i915_guc_submission.c
> @@ -500,7 +500,7 @@ static void i915_guc_submit(struct intel_engine_cs *engine)
> const unsigned int engine_id = engine->id;
> unsigned int n;
>
> - for (n = 0; n < ARRAY_SIZE(execlists->port); n++) {
> + for (n = 0; n < execlists_num_ports(execlists); n++) {
For a while I was looking this delta in reverse and could not figure it
out.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-10 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 11:48 [PATCH] drm/i915: Use execlists_num_ports instead of size of array Mika Kuoppala
2017-10-10 12:09 ` Chris Wilson
2017-10-10 12:27 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-10 12:59 ` Joonas Lahtinen [this message]
2017-10-10 13:42 ` [PATCH] " Mika Kuoppala
2017-10-10 15:58 ` ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507640364.7677.14.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox