* [PATCH] drm/i915: Simplify intel_sanitize_enable_ppgtt
@ 2017-10-10 14:33 Joonas Lahtinen
2017-10-10 15:56 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Joonas Lahtinen @ 2017-10-10 14:33 UTC (permalink / raw)
To: Intel graphics driver community testing & development; +Cc: Colin Ian King
Remove dead code around has_aliasing_ppgtt condition.
Suggested-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Colin Ian King <colin.king@canonical.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 4c605785e2b3..c549019ae91d 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -135,11 +135,12 @@ static inline void i915_ggtt_invalidate(struct drm_i915_private *i915)
int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
int enable_ppgtt)
{
- bool has_aliasing_ppgtt;
bool has_full_ppgtt;
bool has_full_48bit_ppgtt;
- has_aliasing_ppgtt = dev_priv->info.has_aliasing_ppgtt;
+ if (!dev_priv->info.has_aliasing_ppgtt)
+ return 0;
+
has_full_ppgtt = dev_priv->info.has_full_ppgtt;
has_full_48bit_ppgtt = dev_priv->info.has_full_48bit_ppgtt;
@@ -149,9 +150,6 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
has_full_48bit_ppgtt = intel_vgpu_has_full_48bit_ppgtt(dev_priv);
}
- if (!has_aliasing_ppgtt)
- return 0;
-
/*
* We don't allow disabling PPGTT for gen9+ as it's a requirement for
* execlists, the sole mechanism available to submit work.
@@ -188,7 +186,7 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
return 2;
}
- return has_aliasing_ppgtt ? 1 : 0;
+ return 1;
}
static int ppgtt_bind_vma(struct i915_vma *vma,
--
2.13.6
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Simplify intel_sanitize_enable_ppgtt
2017-10-10 14:33 [PATCH] drm/i915: Simplify intel_sanitize_enable_ppgtt Joonas Lahtinen
@ 2017-10-10 15:56 ` Patchwork
2017-10-10 21:51 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-11 9:57 ` [PATCH] " Chris Wilson
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-10 15:56 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Simplify intel_sanitize_enable_ppgtt
URL : https://patchwork.freedesktop.org/series/31665/
State : success
== Summary ==
Series 31665v1 drm/i915: Simplify intel_sanitize_enable_ppgtt
https://patchwork.freedesktop.org/api/1.0/series/31665/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:451s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:472s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:389s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:571s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:284s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:518s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:521s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:534s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:517s
fi-cfl-s total:289 pass:256 dwarn:1 dfail:0 fail:0 skip:32 time:559s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:619s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:424s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:597s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:434s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:414s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:456s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:513s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:472s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:507s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:579s
fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:491s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:590s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:658s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:464s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:653s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:532s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:501s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:474s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:583s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:431s
e30ce0d029c5b5483b51d9164cb5966a083af8de drm-tip: 2017y-10m-10d-15h-14m-09s UTC integration manifest
6394a1ed3cb9 drm/i915: Simplify intel_sanitize_enable_ppgtt
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5977/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Simplify intel_sanitize_enable_ppgtt
2017-10-10 14:33 [PATCH] drm/i915: Simplify intel_sanitize_enable_ppgtt Joonas Lahtinen
2017-10-10 15:56 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-10 21:51 ` Patchwork
2017-10-11 9:57 ` [PATCH] " Chris Wilson
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-10 21:51 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Simplify intel_sanitize_enable_ppgtt
URL : https://patchwork.freedesktop.org/series/31665/
State : success
== Summary ==
Test kms_atomic_transition:
Subgroup plane-all-transition:
skip -> PASS (shard-hsw)
Test kms_plane_multiple:
Subgroup legacy-pipe-B-tiling-x:
skip -> PASS (shard-hsw)
Test gem_userptr_blits:
Subgroup sync-unmap-cycles:
dmesg-warn -> PASS (shard-hsw) fdo#102886
fdo#102886 https://bugs.freedesktop.org/show_bug.cgi?id=102886
shard-hsw total:2552 pass:1431 dwarn:5 dfail:0 fail:13 skip:1103 time:9650s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5977/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Simplify intel_sanitize_enable_ppgtt
2017-10-10 14:33 [PATCH] drm/i915: Simplify intel_sanitize_enable_ppgtt Joonas Lahtinen
2017-10-10 15:56 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-10 21:51 ` ✓ Fi.CI.IGT: " Patchwork
@ 2017-10-11 9:57 ` Chris Wilson
2017-10-12 8:32 ` Joonas Lahtinen
2 siblings, 1 reply; 5+ messages in thread
From: Chris Wilson @ 2017-10-11 9:57 UTC (permalink / raw)
To: Joonas Lahtinen,
Intel graphics driver community testing & development
Cc: Colin Ian King
Quoting Joonas Lahtinen (2017-10-10 15:33:55)
> Remove dead code around has_aliasing_ppgtt condition.
>
> Suggested-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Colin Ian King <colin.king@canonical.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Simplify intel_sanitize_enable_ppgtt
2017-10-11 9:57 ` [PATCH] " Chris Wilson
@ 2017-10-12 8:32 ` Joonas Lahtinen
0 siblings, 0 replies; 5+ messages in thread
From: Joonas Lahtinen @ 2017-10-12 8:32 UTC (permalink / raw)
To: Chris Wilson,
Intel graphics driver community testing & development
Cc: Colin Ian King
On Wed, 2017-10-11 at 10:57 +0100, Chris Wilson wrote:
> Quoting Joonas Lahtinen (2017-10-10 15:33:55)
> > Remove dead code around has_aliasing_ppgtt condition.
> >
> > Suggested-by: Colin Ian King <colin.king@canonical.com>
> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Colin Ian King <colin.king@canonical.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Pushed the patch, thanks for reporting and review.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-12 8:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-10 14:33 [PATCH] drm/i915: Simplify intel_sanitize_enable_ppgtt Joonas Lahtinen
2017-10-10 15:56 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-10 21:51 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-11 9:57 ` [PATCH] " Chris Wilson
2017-10-12 8:32 ` Joonas Lahtinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox